LKML Archive on
help / color / mirror / Atom feed
From: Artur Rojek <>
To: Mark Brown <>, Rob Herring <>,
	Paul Cercueil <>,
	Thomas Bogendoerfer <>,
	Pavel Nadein <>
Cc: Pavel Nadein <>,,,,,
	Artur Rojek <>
Subject: [5.16][PATCH 0/3] Support for Ingenic JZ47xx SPI controller
Date: Tue, 31 Aug 2021 01:01:36 +0200	[thread overview]
Message-ID: <> (raw)


This patchset introduces support for SPI controllers found in the
Ingenic JZ47xx family of SoCs. Of particular note, this allows to
replace GPIO backed SPI on the MIPS Creator CI20 board. 

Checkpatch generates a `need consistent spacing around '*'` error on
this patchset, however I believe this is a false positive due to it
confusing a pointer with multiplication operator inside a macro.

I refrained from adding SPI pin groups into the bindings, as I felt that
would be enforcing a policy (SPI signals can be multiplexed on multiple
pin groups on the board, per use case). Instead, I included an example
pin configuration into the relevant commit description.

Other controllers already present in ci20.dts do specify their pin
groups, but I think this is bad practice. Do you have particular
guidelines on this?

Feel free to add your Tested-by, if you still have your CI20 setup
around :) I tested this driver with two SPI mode MMC/SD card readers and
also with the spi-loopback test driver. 


Artur Rojek (2):
  SPI: add Ingenic JZ47xx driver.
  MIPS: JZ4780: CI20: DTS: add SPI controller config

Paul Cercueil (1):
  dt-bindings: spi: Document Ingenic SPI controller bindings

 .../devicetree/bindings/spi/ingenic,spi.yaml  |  72 +++
 arch/mips/boot/dts/ingenic/ci20.dts           |   9 +-
 arch/mips/boot/dts/ingenic/jz4780.dtsi        |  44 +-
 drivers/spi/Kconfig                           |   9 +
 drivers/spi/Makefile                          |   1 +
 drivers/spi/spi-ingenic.c                     | 482 ++++++++++++++++++
 6 files changed, 602 insertions(+), 15 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/ingenic,spi.yaml
 create mode 100644 drivers/spi/spi-ingenic.c


             reply	other threads:[~2021-08-30 23:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 23:01 Artur Rojek [this message]
2021-08-30 23:01 ` [5.16][PATCH 1/3] dt-bindings: spi: Document Ingenic SPI controller bindings Artur Rojek
2021-08-30 23:18   ` Artur Rojek
2021-09-01  1:36   ` Rob Herring
2021-08-30 23:01 ` [5.16][PATCH 2/3] SPI: add Ingenic JZ47xx driver Artur Rojek
2021-08-30 23:01 ` [5.16][PATCH 3/3] MIPS: JZ4780: CI20: DTS: add SPI controller config Artur Rojek
2021-09-13 10:53 ` [5.16][PATCH 0/3] Support for Ingenic JZ47xx SPI controller Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [5.16][PATCH 0/3] Support for Ingenic JZ47xx SPI controller' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).