LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] bootconfig: Fix missing return check of xbc_node_compose_key function
@ 2021-08-31  3:32 Julio Faracco
  2021-08-31  7:40 ` Masami Hiramatsu
  0 siblings, 1 reply; 3+ messages in thread
From: Julio Faracco @ 2021-08-31  3:32 UTC (permalink / raw)
  To: mhiramat; +Cc: rostedt, mingo, linux-kernel

The function `xbc_show_list should` handle the keys during the
composition. Even the errors returned by the compose function. Instead
of removing the `ret` variable, it should save the value and show the
exact error. This missing variable is causing a compilation issue also.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
---
 tools/bootconfig/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
index f45fa992e01d..fd67496a947f 100644
--- a/tools/bootconfig/main.c
+++ b/tools/bootconfig/main.c
@@ -111,9 +111,11 @@ static void xbc_show_list(void)
 	char key[XBC_KEYLEN_MAX];
 	struct xbc_node *leaf;
 	const char *val;
+	int ret;
 
 	xbc_for_each_key_value(leaf, val) {
-		if (xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX) < 0) {
+		ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX);
+		if (ret < 0) {
 			fprintf(stderr, "Failed to compose key %d\n", ret);
 			break;
 		}
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-31  8:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31  3:32 [PATCH] bootconfig: Fix missing return check of xbc_node_compose_key function Julio Faracco
2021-08-31  7:40 ` Masami Hiramatsu
2021-08-31  8:04   ` Masami Hiramatsu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).