LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
@ 2021-08-31  1:25 zhaoxiao
  2021-08-31 17:10 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: zhaoxiao @ 2021-08-31  1:25 UTC (permalink / raw)
  To: davem, kuba, mcoquelin.stm32
  Cc: peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-stm32,
	linux-arm-kernel, linux-kernel, zhaoxiao

Change the pr_info to dev_err.

Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
v3:Remove the redundant blank line.
 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..f03f25d9adb0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -54,14 +54,13 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
 	bool mdio = false;
 
 	np = dev_of_node(&pdev->dev);
-
 	if (!np) {
-		pr_info("dwmac_loongson_pci: No OF node\n");
+		dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
 		return -ENODEV;
 	}
 
 	if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
-		pr_info("dwmac_loongson_pci: Incompatible OF node\n");
+		dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
 		return -ENODEV;
 	}
 
-- 
2.20.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
  2021-08-31  1:25 [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() zhaoxiao
@ 2021-08-31 17:10 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-08-31 17:10 UTC (permalink / raw)
  To: zhaoxiao
  Cc: davem, mcoquelin.stm32, peppe.cavallaro, alexandre.torgue,
	joabreu, netdev, linux-stm32, linux-arm-kernel, linux-kernel,
	John 'Warthog9' Hawley

On Tue, 31 Aug 2021 09:25:23 +0800 zhaoxiao wrote:
> Change the pr_info to dev_err.
> 
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>

Your patches seem to not show up on the netdev mailing list.
They do make it to lkml and linux-arm tho, strangely.

Are you seeing any errors when sending them?

Please repost this one and CC warthog9@kernel.org - let's see 
if it gets thru..

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-31 17:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31  1:25 [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() zhaoxiao
2021-08-31 17:10 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).