LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3 0/2] kselftests: clean configs
@ 2021-08-31 10:23 Li Zhijian
  2021-08-31 10:23 ` [PATCH v3 1/2] selftests/sync: Remove the deprecated config SYNC Li Zhijian
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Li Zhijian @ 2021-08-31 10:23 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, Rafael J. Wysocki,
	Viresh Kumar, linux-pm, kernel test robot

0Day will check if all configs listing under selftests are able
to be enabled properly.

For the missing configs, it will report something like:
LKP WARN miss config CONFIG_SYNC= of sync/config

CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Viresh Kumar <viresh.kumar@linaro.org>
CC: linux-pm@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>

Li Zhijian (2):
  selftests/sync: Remove the deprecated config SYNC
  selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST

 tools/testing/selftests/cpufreq/config | 2 +-
 tools/testing/selftests/sync/config    | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

-- 
2.31.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/2] selftests/sync: Remove the deprecated config SYNC
  2021-08-31 10:23 [PATCH v3 0/2] kselftests: clean configs Li Zhijian
@ 2021-08-31 10:23 ` Li Zhijian
  2021-08-31 10:23 ` [PATCH v3 2/2] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
  2021-08-31 16:50 ` [PATCH v3 0/2] kselftests: clean configs Shuah Khan
  2 siblings, 0 replies; 5+ messages in thread
From: Li Zhijian @ 2021-08-31 10:23 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, kernel test robot

SYNC was removed since
aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
LKP/0Day will check if all configs listing under selftests are able to
be enabled properly.

For the missing configs, it will report something like:
LKP WARN miss config CONFIG_SYNC= of sync/config

- it's not reasonable to keep the deprecated configs.
- configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

CC: Philip Li <philip.li@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

---
V3: update commit logs # Shuah
---
 tools/testing/selftests/sync/config | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/sync/config b/tools/testing/selftests/sync/config
index 1ab7e8130db2..47ff5afc3727 100644
--- a/tools/testing/selftests/sync/config
+++ b/tools/testing/selftests/sync/config
@@ -1,4 +1,3 @@
 CONFIG_STAGING=y
 CONFIG_ANDROID=y
-CONFIG_SYNC=y
 CONFIG_SW_SYNC=y
-- 
2.31.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 2/2] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-31 10:23 [PATCH v3 0/2] kselftests: clean configs Li Zhijian
  2021-08-31 10:23 ` [PATCH v3 1/2] selftests/sync: Remove the deprecated config SYNC Li Zhijian
@ 2021-08-31 10:23 ` Li Zhijian
  2021-08-31 12:05   ` Viresh Kumar
  2021-08-31 16:50 ` [PATCH v3 0/2] kselftests: clean configs Shuah Khan
  2 siblings, 1 reply; 5+ messages in thread
From: Li Zhijian @ 2021-08-31 10:23 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, Rafael J. Wysocki,
	Viresh Kumar, linux-pm

DEBUG_PI_LIST was renamed to DEBUG_PLIST since
8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")

- It's not reasonable to keep the deprecated configs.
- configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Viresh Kumar <viresh.kumar@linaro.org>
CC: linux-pm@vger.kernel.org
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

---
v3: update commit logs # Shuah
---
 tools/testing/selftests/cpufreq/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/cpufreq/config b/tools/testing/selftests/cpufreq/config
index 27ff72ebd0f5..75e900793e8a 100644
--- a/tools/testing/selftests/cpufreq/config
+++ b/tools/testing/selftests/cpufreq/config
@@ -6,7 +6,7 @@ CONFIG_CPU_FREQ_GOV_ONDEMAND=y
 CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
 CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y
 CONFIG_DEBUG_RT_MUTEXES=y
-CONFIG_DEBUG_PI_LIST=y
+CONFIG_DEBUG_PLIST=y
 CONFIG_DEBUG_SPINLOCK=y
 CONFIG_DEBUG_MUTEXES=y
 CONFIG_DEBUG_LOCK_ALLOC=y
-- 
2.31.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 2/2] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-31 10:23 ` [PATCH v3 2/2] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
@ 2021-08-31 12:05   ` Viresh Kumar
  0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2021-08-31 12:05 UTC (permalink / raw)
  To: Li Zhijian
  Cc: shuah, linux-kselftest, philip.li, linux-kernel,
	Rafael J. Wysocki, linux-pm

On 31-08-21, 18:23, Li Zhijian wrote:
> DEBUG_PI_LIST was renamed to DEBUG_PLIST since
> 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")
> 
> - It's not reasonable to keep the deprecated configs.
> - configs under kselftests are recommended by corresponding tests.
> So if some configs are missing, it will impact the testing results
> 
> CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> CC: Viresh Kumar <viresh.kumar@linaro.org>
> CC: linux-pm@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> 
> ---
> v3: update commit logs # Shuah
> ---
>  tools/testing/selftests/cpufreq/config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cpufreq/config b/tools/testing/selftests/cpufreq/config
> index 27ff72ebd0f5..75e900793e8a 100644
> --- a/tools/testing/selftests/cpufreq/config
> +++ b/tools/testing/selftests/cpufreq/config
> @@ -6,7 +6,7 @@ CONFIG_CPU_FREQ_GOV_ONDEMAND=y
>  CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
>  CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y
>  CONFIG_DEBUG_RT_MUTEXES=y
> -CONFIG_DEBUG_PI_LIST=y
> +CONFIG_DEBUG_PLIST=y
>  CONFIG_DEBUG_SPINLOCK=y
>  CONFIG_DEBUG_MUTEXES=y
>  CONFIG_DEBUG_LOCK_ALLOC=y

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/2] kselftests: clean configs
  2021-08-31 10:23 [PATCH v3 0/2] kselftests: clean configs Li Zhijian
  2021-08-31 10:23 ` [PATCH v3 1/2] selftests/sync: Remove the deprecated config SYNC Li Zhijian
  2021-08-31 10:23 ` [PATCH v3 2/2] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
@ 2021-08-31 16:50 ` Shuah Khan
  2 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2021-08-31 16:50 UTC (permalink / raw)
  To: Li Zhijian, shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Rafael J. Wysocki, Viresh Kumar,
	linux-pm, kernel test robot, Shuah Khan

On 8/31/21 4:23 AM, Li Zhijian wrote:
> 0Day will check if all configs listing under selftests are able
> to be enabled properly.
> 
> For the missing configs, it will report something like:
> LKP WARN miss config CONFIG_SYNC= of sync/config
> 
> CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> CC: Viresh Kumar <viresh.kumar@linaro.org>
> CC: linux-pm@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Li Zhijian (2):
>    selftests/sync: Remove the deprecated config SYNC
>    selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
> 
>   tools/testing/selftests/cpufreq/config | 2 +-
>   tools/testing/selftests/sync/config    | 1 -
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 

Thank you. These two patches will be queued up for 5.15

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-31 16:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 10:23 [PATCH v3 0/2] kselftests: clean configs Li Zhijian
2021-08-31 10:23 ` [PATCH v3 1/2] selftests/sync: Remove the deprecated config SYNC Li Zhijian
2021-08-31 10:23 ` [PATCH v3 2/2] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
2021-08-31 12:05   ` Viresh Kumar
2021-08-31 16:50 ` [PATCH v3 0/2] kselftests: clean configs Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).