LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of phy-connection-type
Date: Tue, 31 Aug 2021 13:59:17 +0000	[thread overview]
Message-ID: <20210831135916.ccvyc5intxs7rlal@skbuf> (raw)
In-Reply-To: <20210831134013.1625527-8-michael@walle.cc>

On Tue, Aug 31, 2021 at 03:40:13PM +0200, Michael Walle wrote:
> In linux both are identical, phy-mode is used more often, though. Also
> for the ls1028a both phy-connection-type and phy-mode was used, one for
> the enetc nodes and the other for the switch nodes. Unify them. But the
> main reason for this is that the device tree files can be shared with
> the u-boot ones; there the enetc driver only supports the "phy-mode"
> property.
> 
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---

Actually that is not really a valid reason in itself for this change.
The enetc U-Boot driver is perhaps a bit silly in that it calls
ofnode_read_string(dev_ofnode(dev), "phy-mode") manually, especially
since right below, it uses dm_eth_phy_connect() which searches for both.

So we are artificially restricting what we support. It would be fine to
do the dm_eth_phy_connect first, then use phy->interface for enetc_start_pcs().

Anyway, I do not mind the patch at all.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

  reply	other threads:[~2021-08-31 14:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 13:40 [PATCH 0/7] arm64: dts: ls1028: GPU support and cleanups Michael Walle
2021-08-31 13:40 ` [PATCH 1/7] arm64: dts: ls1028a: move pixel clock pll into /soc Michael Walle
2021-08-31 13:40 ` [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node " Michael Walle
2022-01-20  8:06   ` Leo Li
2022-01-20  8:17     ` Michael Walle
2021-08-31 13:40 ` [PATCH 3/7] arm64: dts: ls1028a: add Vivante GPU node Michael Walle
2021-08-31 13:40 ` [PATCH 4/7] arm64: dts: freescale: fix arm,sp805 compatible string Michael Walle
2021-08-31 13:40 ` [PATCH 5/7] arm64: dts: ls1028a: disable usb controller by default Michael Walle
2021-08-31 14:08   ` Vladimir Oltean
2021-08-31 13:40 ` [PATCH 6/7] arm64: dts: ls1028a: move PHY nodes to MDIO controller Michael Walle
2021-08-31 14:07   ` Vladimir Oltean
2021-08-31 13:40 ` [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of phy-connection-type Michael Walle
2021-08-31 13:59   ` Vladimir Oltean [this message]
2021-08-31 14:06     ` Michael Walle
2021-10-04 13:02 ` [PATCH 0/7] arm64: dts: ls1028: GPU support and cleanups Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210831135916.ccvyc5intxs7rlal@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of phy-connection-type' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).