LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev
Cc: Kari Argillander <kari.argillander@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] fs/ntfs3: Add missing header files to ntfs.h
Date: Tue, 31 Aug 2021 17:14:28 +0300	[thread overview]
Message-ID: <20210831141434.975175-2-kari.argillander@gmail.com> (raw)
In-Reply-To: <20210831141434.975175-1-kari.argillander@gmail.com>

We do not have header files at all in this file. Add following headers
and there is also explanation which for it was added. Note that
explanation might not be complete, but it just proofs it is needed.

<linux/blkdev.h> // SECTOR_SHIFT
<linux/build_bug.h> // static_assert()
<linux/kernel.h> // cpu_to_le64, cpu_to_le32, ALIGN
<linux/stddef.h> // offsetof()
<linux/string.h> // memcmp()
<linux/types.h> //__le32, __le16

"debug.h" // PtrOffset(), Add2Ptr()

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
 fs/ntfs3/ntfs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
index 0fd7bffb98d4..778be353ffe6 100644
--- a/fs/ntfs3/ntfs.h
+++ b/fs/ntfs3/ntfs.h
@@ -10,6 +10,15 @@
 #ifndef _LINUX_NTFS3_NTFS_H
 #define _LINUX_NTFS3_NTFS_H
 
+#include <linux/blkdev.h>
+#include <linux/build_bug.h>
+#include <linux/kernel.h>
+#include <linux/stddef.h>
+#include <linux/string.h>
+#include <linux/types.h>
+
+#include "debug.h"
+
 /* TODO: Check 4K MFT record and 512 bytes cluster. */
 
 /* Activate this define to use binary search in indexes. */
-- 
2.25.1


  reply	other threads:[~2021-08-31 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 14:14 [PATCH 0/7] fs/ntfs3: Refactor header includes Kari Argillander
2021-08-31 14:14 ` Kari Argillander [this message]
2021-08-31 14:14 ` [PATCH 2/7] fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h Kari Argillander
2021-08-31 14:14 ` [PATCH 3/7] fs/ntfs3: Add missing header and guards to lib/ headers Kari Argillander
2021-08-31 14:14 ` [PATCH 4/7] fs/ntfs3: Change right headers to bitfunc.c Kari Argillander
2021-08-31 14:14 ` [PATCH 5/7] fs/ntfs3: Change right headers to upcase.c Kari Argillander
2021-08-31 14:14 ` [PATCH 6/7] fs/ntfs3: Change right headers to lznt.c Kari Argillander
2021-08-31 17:54   ` kernel test robot
2021-08-31 18:43     ` Kari Argillander
2021-09-01  0:45   ` kernel test robot
2021-08-31 14:14 ` [PATCH 7/7] fs/ntfs3: Remove unneeded header files from c files Kari Argillander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210831141434.975175-2-kari.argillander@gmail.com \
    --to=kari.argillander@gmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --subject='Re: [PATCH 1/7] fs/ntfs3: Add missing header files to ntfs.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).