LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mtd: spi-nor: nxp-spifi: Make use of the helper function devm_platform_ioremap_resource_byname()
@ 2021-09-01 7:43 Cai Huoqing
2021-09-01 11:41 ` Pratyush Yadav
2021-10-19 10:17 ` Tudor.Ambarus
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-01 7:43 UTC (permalink / raw)
To: caihuoqing
Cc: Vladimir Zapolskiy, Tudor Ambarus, Michael Walle, Pratyush Yadav,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-arm-kernel, linux-mtd, linux-kernel
Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/mtd/spi-nor/controllers/nxp-spifi.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
index 2635c80231bb..9032b9ab2eaf 100644
--- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
+++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
@@ -381,20 +381,17 @@ static int nxp_spifi_probe(struct platform_device *pdev)
{
struct device_node *flash_np;
struct nxp_spifi *spifi;
- struct resource *res;
int ret;
spifi = devm_kzalloc(&pdev->dev, sizeof(*spifi), GFP_KERNEL);
if (!spifi)
return -ENOMEM;
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "spifi");
- spifi->io_base = devm_ioremap_resource(&pdev->dev, res);
+ spifi->io_base = devm_platform_ioremap_resource_byname(pdev, "spifi");
if (IS_ERR(spifi->io_base))
return PTR_ERR(spifi->io_base);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "flash");
- spifi->flash_base = devm_ioremap_resource(&pdev->dev, res);
+ spifi->flash_base = devm_platform_ioremap_resource_byname(pdev, "flash");
if (IS_ERR(spifi->flash_base))
return PTR_ERR(spifi->flash_base);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: spi-nor: nxp-spifi: Make use of the helper function devm_platform_ioremap_resource_byname()
2021-09-01 7:43 [PATCH] mtd: spi-nor: nxp-spifi: Make use of the helper function devm_platform_ioremap_resource_byname() Cai Huoqing
@ 2021-09-01 11:41 ` Pratyush Yadav
2021-10-19 10:17 ` Tudor.Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Pratyush Yadav @ 2021-09-01 11:41 UTC (permalink / raw)
To: Cai Huoqing
Cc: Vladimir Zapolskiy, Tudor Ambarus, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-arm-kernel,
linux-mtd, linux-kernel
On 01/09/21 03:43PM, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Pratyush Yadav <p.yadav@ti.com>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: nxp-spifi: Make use of the helper function devm_platform_ioremap_resource_byname()
2021-09-01 7:43 [PATCH] mtd: spi-nor: nxp-spifi: Make use of the helper function devm_platform_ioremap_resource_byname() Cai Huoqing
2021-09-01 11:41 ` Pratyush Yadav
@ 2021-10-19 10:17 ` Tudor.Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Tudor.Ambarus @ 2021-10-19 10:17 UTC (permalink / raw)
To: caihuoqing
Cc: vz, michael, p.yadav, miquel.raynal, richard, vigneshr,
linux-arm-kernel, linux-mtd, linux-kernel
On 9/1/21 10:43 AM, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19 10:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 7:43 [PATCH] mtd: spi-nor: nxp-spifi: Make use of the helper function devm_platform_ioremap_resource_byname() Cai Huoqing
2021-09-01 11:41 ` Pratyush Yadav
2021-10-19 10:17 ` Tudor.Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).