LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/7] fs/ntfs3: Refactor header includes
@ 2021-08-31 14:14 Kari Argillander
  2021-08-31 14:14 ` [PATCH 1/7] fs/ntfs3: Add missing header files to ntfs.h Kari Argillander
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: Kari Argillander @ 2021-08-31 14:14 UTC (permalink / raw)
  To: Konstantin Komarov, ntfs3; +Cc: Kari Argillander, linux-kernel

Right now header includes are big mess with ntfs3 imo. We cannot example
include ntfs3 headers without need of punch of includes to source file.
This patch set try to address that. When this patch series is applied we
can include any header file without need of include anything else. This
does not mean source file should rely what header file includes. Instead
it should include them by self also if it needs them.

When some include is added I have write why this is needed to commit
message. Hopefully this will help when someone wants to correct them
again. I have also just delete unnecessary headers from some .c files
and not added what is needed. Usually deleted headers where there
because ntfs_fs.h need them not file itself. When file was simple enough
I added all necessary linux headers.

I did not add linux/headers to all files yet. That is big job. This is
good starting point. I did try to build every file itself so this will
build like it should.

Please do not hesitate to tell if there is something wrong with this
series or somethings could be done better.

Kari Argillander (7):
  fs/ntfs3: Add missing header files to ntfs.h
  fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h
  fs/ntfs3: Add missing header and guards to lib/ headers
  fs/ntfs3: Change right headers to bitfunc.c
  fs/ntfs3: Change right headers to upcase.c
  fs/ntfs3: Change right headers to lznt.c
  fs/ntfs3: Remove unneeded header files from c files

 fs/ntfs3/attrib.c                |  5 -----
 fs/ntfs3/attrlist.c              |  3 ---
 fs/ntfs3/bitfunc.c               |  7 +------
 fs/ntfs3/bitmap.c                |  3 ---
 fs/ntfs3/dir.c                   |  3 ---
 fs/ntfs3/file.c                  |  1 -
 fs/ntfs3/frecord.c               |  3 ---
 fs/ntfs3/fslog.c                 |  4 ----
 fs/ntfs3/fsntfs.c                |  1 -
 fs/ntfs3/index.c                 |  1 -
 fs/ntfs3/inode.c                 |  2 --
 fs/ntfs3/lib/decompress_common.h |  5 +++++
 fs/ntfs3/lib/lib.h               |  6 ++++++
 fs/ntfs3/lznt.c                  | 10 +++++-----
 fs/ntfs3/namei.c                 |  4 ----
 fs/ntfs3/ntfs.h                  |  9 +++++++++
 fs/ntfs3/ntfs_fs.h               | 31 +++++++++++++++++++++++++++++++
 fs/ntfs3/record.c                |  3 ---
 fs/ntfs3/run.c                   |  2 --
 fs/ntfs3/super.c                 |  2 --
 fs/ntfs3/upcase.c                |  8 ++------
 fs/ntfs3/xattr.c                 |  3 ---
 22 files changed, 59 insertions(+), 57 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-09-01  0:46 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 14:14 [PATCH 0/7] fs/ntfs3: Refactor header includes Kari Argillander
2021-08-31 14:14 ` [PATCH 1/7] fs/ntfs3: Add missing header files to ntfs.h Kari Argillander
2021-08-31 14:14 ` [PATCH 2/7] fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h Kari Argillander
2021-08-31 14:14 ` [PATCH 3/7] fs/ntfs3: Add missing header and guards to lib/ headers Kari Argillander
2021-08-31 14:14 ` [PATCH 4/7] fs/ntfs3: Change right headers to bitfunc.c Kari Argillander
2021-08-31 14:14 ` [PATCH 5/7] fs/ntfs3: Change right headers to upcase.c Kari Argillander
2021-08-31 14:14 ` [PATCH 6/7] fs/ntfs3: Change right headers to lznt.c Kari Argillander
2021-08-31 17:54   ` kernel test robot
2021-08-31 18:43     ` Kari Argillander
2021-09-01  0:45   ` kernel test robot
2021-08-31 14:14 ` [PATCH 7/7] fs/ntfs3: Remove unneeded header files from c files Kari Argillander

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).