LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luca Coelho <luciano.coelho@intel.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	David Miller <davem@davemloft.net>,
	Netdev <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-wireless@vger.kernel.org,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [GIT PULL] Networking for v5.15
Date: Wed, 1 Sep 2021 12:41:31 -0700	[thread overview]
Message-ID: <20210901124131.0bc62578@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAHk-=wjB_zBwZ+WR9LOpvgjvaQn=cqryoKigod8QnZs=iYGEhA@mail.gmail.com>

On Wed, 1 Sep 2021 12:00:57 -0700 Linus Torvalds wrote:
> On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > No conflicts at the time of writing. There were conflicts with
> > char-misc but I believe Greg dropped the commits in question.  
> 
> Hmm. I already merged this earlier, but didn't notice a new warning on
> my desktop:

>   RTNL: assertion failed at net/wireless/core.c (61)
>   WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61
> wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211]
>   Call Trace:
>    nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211]
>    reg_process_self_managed_hint+0x23d/0x280 [cfg80211]
>    regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211]
>    iwl_mvm_init_mcc+0x170/0x190 [iwlmvm]
>    iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm]
>    iwl_opmode_register+0xd0/0x130 [iwlwifi]
>    init_module+0x23/0x1000 [iwlmvm]
> 
> They all seem to have that same issue, and it looks like the fix would
> be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look
> into it very much.
> 
> This is on my desktop, and I actually don't _use_ the wireless on this
> machine. I assume it still works despite the warnings, but they should
> get fixed.
> 
> I *don't* see these warnings on my laptop where I actually use
> wireless, but that one uses ath10k_pci, so it seems this is purely a
> iwlwifi issue.
> 
> I can't be the only one that sees this. Hmm?

Mm. Looking thru the recent commits there is a suspicious rtnl_unlock()
in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage").

CC Miri, Johannes

  reply	other threads:[~2021-09-01 19:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 20:37 Jakub Kicinski
2021-08-31 23:56 ` pr-tracker-bot
2021-09-01 19:00 ` Linus Torvalds
2021-09-01 19:41   ` Jakub Kicinski [this message]
2021-09-01 19:49     ` Johannes Berg
2021-09-01 21:48       ` Larry Finger
2021-09-02  9:33       ` Coelho, Luciano
2021-09-02 10:11         ` [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm() Luca Coelho
2021-09-02 10:39           ` David Miller
2021-09-02 15:55             ` Linus Torvalds
     [not found]         ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com>
2021-09-02 17:16           ` [GIT PULL] Networking for v5.15 Linus Torvalds
2021-09-02  5:55     ` Larry Finger
2021-09-02  7:07       ` Johannes Berg
2021-09-02  0:02 ` John Stultz
2021-09-02  9:25   ` Dan Carpenter
2021-09-02  9:28     ` Srinivas Kandagatla
2021-09-02 10:08       ` [PATCH net] net: qrtr: revert check in qrtr_endpoint_post() Dan Carpenter
2021-09-02 10:40         ` patchwork-bot+netdevbpf
2021-09-04  3:08     ` [GIT PULL] Networking for v5.15 John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901124131.0bc62578@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [GIT PULL] Networking for v5.15' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).