LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] tracing: synth events: increase max fields count
@ 2021-09-01 13:55 Artem Bityutskiy
  2021-09-02 20:54 ` Tom Zanussi
  0 siblings, 1 reply; 2+ messages in thread
From: Artem Bityutskiy @ 2021-09-01 13:55 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Tom Zanussi, linux-kernel, Artem Bityutskiy

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Sometimes it is useful to construct larger synthetic trace events. Increase
'SYNTH_FIELDS_MAX' (maximum number of fields in a synthetic event) from 32 to
64.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 kernel/trace/trace_synth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_synth.h b/kernel/trace/trace_synth.h
index 4007fe95cf42..b29595fe3ac5 100644
--- a/kernel/trace/trace_synth.h
+++ b/kernel/trace/trace_synth.h
@@ -5,7 +5,7 @@
 #include "trace_dynevent.h"
 
 #define SYNTH_SYSTEM		"synthetic"
-#define SYNTH_FIELDS_MAX	32
+#define SYNTH_FIELDS_MAX	64
 
 #define STR_VAR_LEN_MAX		MAX_FILTER_STR_VAL /* must be multiple of sizeof(u64) */
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: synth events: increase max fields count
  2021-09-01 13:55 [PATCH] tracing: synth events: increase max fields count Artem Bityutskiy
@ 2021-09-02 20:54 ` Tom Zanussi
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Zanussi @ 2021-09-02 20:54 UTC (permalink / raw)
  To: Artem Bityutskiy, Steven Rostedt; +Cc: linux-kernel

Hi Artem,

On Wed, 2021-09-01 at 16:55 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Sometimes it is useful to construct larger synthetic trace events.
> Increase
> 'SYNTH_FIELDS_MAX' (maximum number of fields in a synthetic event)
> from 32 to
> 64.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> ---
>  kernel/trace/trace_synth.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_synth.h b/kernel/trace/trace_synth.h
> index 4007fe95cf42..b29595fe3ac5 100644
> --- a/kernel/trace/trace_synth.h
> +++ b/kernel/trace/trace_synth.h
> @@ -5,7 +5,7 @@
>  #include "trace_dynevent.h"
>  
>  #define SYNTH_SYSTEM		"synthetic"
> -#define SYNTH_FIELDS_MAX	32
> +#define SYNTH_FIELDS_MAX	64
>  
>  #define STR_VAR_LEN_MAX		MAX_FILTER_STR_VAL /* must be
> multiple of sizeof(u64) */
>  

This looks fine, but it does also bloat the arrays that use it as a
size.  There's only one that I'd be worried about, the per-elt
hist_elt_data[] array, but I'll send a patch shortly that gets rid of
that limitation.

Acked-by: Tom Zanussi <zanussi@kernel.org>

Thanks!

Tom


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-02 20:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 13:55 [PATCH] tracing: synth events: increase max fields count Artem Bityutskiy
2021-09-02 20:54 ` Tom Zanussi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).