LKML Archive on
help / color / mirror / Atom feed
* [PATCH v2] Forbid passing 'HEAD' to --commit
@ 2021-09-01 14:52 Ariel Marcovitch
  2021-09-10  2:13 ` Masahiro Yamada
  0 siblings, 1 reply; 2+ messages in thread
From: Ariel Marcovitch @ 2021-09-01 14:52 UTC (permalink / raw)
  To: masahiroy, valentinrothberg; +Cc: arielmarcovitch, linux-kernel, linux-kbuild

As opposed to the --diff option, --commit can get ref names instead of
commit hashes.

When using the --commit option, the script resets the working directory
to the commit before the given ref, by adding '~' to the end of the ref.

However, the 'HEAD' ref is relative, and so when the working directory
is reset to 'HEAD~', 'HEAD' points to what was 'HEAD~'. Then when the
script resets to 'HEAD' it actually stays in the same commit. In this
case, the script won't report any cases because there is no diff between
the cases of the two refs.

Prevent the user from using HEAD refs.

A better solution might be to resolve the refs before doing the
reset, but for now just disallow such refs.

Signed-off-by: Ariel Marcovitch <>
Signed-off-by: Masahiro Yamada <>
 scripts/ | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/ b/scripts/
index b9b0f15e5880..c57c990c3244 100755
--- a/scripts/
+++ b/scripts/
@@ -102,6 +102,9 @@ def parse_options():
     if args.commit:
+        if args.commit.startswith('HEAD'):
+            sys.exit("The --commit option can't use the HEAD ref")
         args.find = False
     if args.ignore:

base-commit: 087e856cfb76e9eef9a3a6e000854794f3c36e24

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-10  2:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 14:52 [PATCH v2] Forbid passing 'HEAD' to --commit Ariel Marcovitch
2021-09-10  2:13 ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).