LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: luca@coelho.fi
Cc: torvalds@linux-foundation.org, johannes@sipsolutions.net,
	kuba@kernel.org, kvalo@codeaurora.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	miriam.rachel.korenblitz@intel.com
Subject: Re: [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm()
Date: Thu, 02 Sep 2021 11:39:08 +0100 (BST)	[thread overview]
Message-ID: <20210902.113908.1070444215922235089.davem@davemloft.net> (raw)
In-Reply-To: <20210902101101.383243-1-luca@coelho.fi>

From: Luca Coelho <luca@coelho.fi>
Date: Thu,  2 Sep 2021 13:11:01 +0300

> From: Luca Coelho <luciano.coelho@intel.com>
> 
> Due to a rebase damage, we lost the rtnl_lock() when the patch was
> sent out.  This causes an RTNL imbalance and failed assertions, due to
> missing RTNL protection, for instance:
> 
>   RTNL: assertion failed at net/wireless/reg.c (4025)
>   WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:4025 regulatory_set_wiphy_regd_sync+0x7f/0x90 [cfg80211]
>   Call Trace:
>    iwl_mvm_init_mcc+0x170/0x190 [iwlmvm]
>    iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm]
>    iwl_opmode_register+0xd0/0x130 [iwlwifi]
>    init_module+0x23/0x1000 [iwlmvm]
> 
> Fix this by adding the missing rtnl_lock() back to the code.
> 
> Fixes: eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage")
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

Linus, please just take this directly, thanks.

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2021-09-02 10:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 20:37 [GIT PULL] Networking for v5.15 Jakub Kicinski
2021-08-31 23:56 ` pr-tracker-bot
2021-09-01 19:00 ` Linus Torvalds
2021-09-01 19:41   ` Jakub Kicinski
2021-09-01 19:49     ` Johannes Berg
2021-09-01 21:48       ` Larry Finger
2021-09-02  9:33       ` Coelho, Luciano
2021-09-02 10:11         ` [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm() Luca Coelho
2021-09-02 10:39           ` David Miller [this message]
2021-09-02 15:55             ` Linus Torvalds
     [not found]         ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com>
2021-09-02 17:16           ` [GIT PULL] Networking for v5.15 Linus Torvalds
2021-09-02  5:55     ` Larry Finger
2021-09-02  7:07       ` Johannes Berg
2021-09-02  0:02 ` John Stultz
2021-09-02  9:25   ` Dan Carpenter
2021-09-02  9:28     ` Srinivas Kandagatla
2021-09-02 10:08       ` [PATCH net] net: qrtr: revert check in qrtr_endpoint_post() Dan Carpenter
2021-09-02 10:40         ` patchwork-bot+netdevbpf
2021-09-04  3:08     ` [GIT PULL] Networking for v5.15 John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902.113908.1070444215922235089.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=miriam.rachel.korenblitz@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).