LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Srini Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH net] net: qrtr: revert check in qrtr_endpoint_post()
Date: Thu, 2 Sep 2021 13:08:51 +0300	[thread overview]
Message-ID: <20210902100851.GD2151@kadam> (raw)
In-Reply-To: <38288aff-71d4-bde2-7547-dff5ca20091c@linaro.org>

I tried to make this check stricter as a hardenning measure but it broke
audo and wifi on these devices so revert it.

Fixes: aaa8e4922c88 ("net: qrtr: make checks in qrtr_endpoint_post() stricter")
Reported-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 net/qrtr/qrtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index 525e3ea063b1..ec2322529727 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
 		goto err;
 	}
 
-	if (!size || size & 3 || len != size + hdrlen)
+	if (!size || len != ALIGN(size, 4) + hdrlen)
 		goto err;
 
 	if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
-- 
2.20.1

  reply	other threads:[~2021-09-02 10:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 20:37 [GIT PULL] Networking for v5.15 Jakub Kicinski
2021-08-31 23:56 ` pr-tracker-bot
2021-09-01 19:00 ` Linus Torvalds
2021-09-01 19:41   ` Jakub Kicinski
2021-09-01 19:49     ` Johannes Berg
2021-09-01 21:48       ` Larry Finger
2021-09-02  9:33       ` Coelho, Luciano
2021-09-02 10:11         ` [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm() Luca Coelho
2021-09-02 10:39           ` David Miller
2021-09-02 15:55             ` Linus Torvalds
     [not found]         ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com>
2021-09-02 17:16           ` [GIT PULL] Networking for v5.15 Linus Torvalds
2021-09-02  5:55     ` Larry Finger
2021-09-02  7:07       ` Johannes Berg
2021-09-02  0:02 ` John Stultz
2021-09-02  9:25   ` Dan Carpenter
2021-09-02  9:28     ` Srinivas Kandagatla
2021-09-02 10:08       ` Dan Carpenter [this message]
2021-09-02 10:40         ` [PATCH net] net: qrtr: revert check in qrtr_endpoint_post() patchwork-bot+netdevbpf
2021-09-04  3:08     ` [GIT PULL] Networking for v5.15 John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902100851.GD2151@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH net] net: qrtr: revert check in qrtr_endpoint_post()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).