LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/3] MIPS: ralink: properly handle pci IO resources
@ 2021-08-22 16:10 Sergio Paracuellos
  2021-08-22 16:10 ` [PATCH v2 1/3] MIPS: ralink: don't define PC_IOBASE but increase IO_SPACE_LIMIT Sergio Paracuellos
                   ` (2 more replies)
  0 siblings, 3 replies; 19+ messages in thread
From: Sergio Paracuellos @ 2021-08-22 16:10 UTC (permalink / raw)
  To: tsbogend
  Cc: bhelgaas, matthias.bgg, gregkh, linux-mips, linux-pci,
	linux-staging, neil, linux-kernel

Hi all,

Defining PCI_IOBASE for MIPS ralink platform results in resource handling working
but the addresses generated for IO access being wrong, because the iomap tries to
ioremap it to a fixed virtual address (PCI_IOBASE), which can't work for KSEG1 
addresses. To get it working this way, we would need to put PCI_IOBASE somewhere
into KSEG2, which will create TLB entries for IO addresses, which most of the
time isn't needed on MIPS because of access via KSEG1. Instead of doing that and
taking into account that we need to get a valid IO address from 'pci_address_to_pio'
and ralink platforms have IO addresses higher than 0xffff, the following approach
will be preferred to get expected working behaviour from PCI core APIs and pci 
drivers working together:
 
1) Avoid to define PCI_IOBASE.
2) Set IO_SPACE_LIMIT to 0x1fffffff which is a valid range for this SoCs.
3) Return zero from 'pci_remap_iospace' if PCI_IOBASE is not defined.
3) Set ioport_resource end limit to this new IO_SPACE_LIMIT.

Doing in this way we end up with a properly working PCI IO in ralink SoCs.
These changes metioned above are in the three patches included in this series.

Thanks in advance for your time and comments.

Changes in v2 (only PATCH v2 2/3 afected):
  - Instead of avoid to call 'devm_pci_remap_iospace' fix 'pci_remap_iospace'
    to return zero for PCI_IOBASE not defined architectures.

Bjorn, I don't know if I should add any kind of 'Fixes' tag for this or
what is the way of handle this kind of changes inside the PCI tree. Thanks
in advance for clarification.

Sergio Paracuellos (3):
  MIPS: ralink: don't define PC_IOBASE but increase IO_SPACE_LIMIT
  PCI: fix 'pci_remap_iospace' for architectures with PCI_IOBASE not
    defined
  staging: mt7621-pci: set end limit for 'ioport_resource'

 arch/mips/include/asm/mach-ralink/spaces.h |  4 +---
 drivers/pci/pci.c                          | 12 ++++++------
 drivers/staging/mt7621-pci/pci-mt7621.c    |  2 ++
 3 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2021-09-22  4:28 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22 16:10 [PATCH v2 0/3] MIPS: ralink: properly handle pci IO resources Sergio Paracuellos
2021-08-22 16:10 ` [PATCH v2 1/3] MIPS: ralink: don't define PC_IOBASE but increase IO_SPACE_LIMIT Sergio Paracuellos
2021-09-02 11:08   ` Thomas Bogendoerfer
2021-08-22 16:10 ` [PATCH v2 2/3] PCI: fix 'pci_remap_iospace' for architectures with PCI_IOBASE not defined Sergio Paracuellos
2021-09-15 10:52   ` Sergio Paracuellos
2021-09-21 17:49   ` Bjorn Helgaas
2021-09-21 18:36     ` Sergio Paracuellos
2021-09-21 19:38       ` Bjorn Helgaas
2021-09-22  4:28         ` Sergio Paracuellos
2021-08-22 16:10 ` [PATCH v2 3/3] staging: mt7621-pci: set end limit for 'ioport_resource' Sergio Paracuellos
2021-08-27  9:01   ` Greg KH
2021-08-29 15:14     ` Sergio Paracuellos
2021-09-02  9:15       ` Greg KH
2021-09-02 10:15         ` Sergio Paracuellos
2021-09-02 11:08           ` Thomas Bogendoerfer
2021-09-02 11:19             ` Sergio Paracuellos
2021-09-21 15:28               ` Greg KH
2021-09-21 17:02                 ` Sergio Paracuellos
2021-09-21 17:08                   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).