LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Aakash Hemadri <aakashhemadri123@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] staging: r8188eu: incorrect type in assignment
Date: Fri, 3 Sep 2021 11:11:43 +0300 [thread overview]
Message-ID: <20210903074517.GG2151@kadam> (raw)
In-Reply-To: <YTCZTY1WsHhTBjUE@kroah.com>
On Thu, Sep 02, 2021 at 11:28:45AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Aug 28, 2021 at 04:40:46PM +0530, Aakash Hemadri wrote:
> > @@ -512,7 +512,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)
> > tag->tag_len = htons(MAGIC_CODE_LEN+RTL_RELAY_TAG_LEN+old_tag_len);
> >
> > /* insert the magic_code+client mac in relay tag */
> > - pMagic = (unsigned short *)tag->tag_data;
> > + pMagic = (__be16 *)tag->tag_data;
>
> Is this whole function ever actually called?
>
> Can someone run a ftrace on the driver to see if this function ever
> runs, and if not, remove it?
>
Yeah. That was my thinking when reviewing this patchset is that the NAT
stuff is probably not well tested. It's only used for WIFI_STATION_STATE
or WIFI_ADHOC_STATE.
I don't think it's dead code but having NAT code in the driver is the
wrong layer probably?
regards,
dan carpenter
next prev parent reply other threads:[~2021-09-03 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 11:10 [PATCH v5 0/3] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-28 11:10 ` [PATCH v5 1/3] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-09-02 9:25 ` Greg Kroah-Hartman
2021-08-28 11:10 ` [PATCH v5 2/3] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-28 11:37 ` Kari Argillander
2021-08-30 10:39 ` Dan Carpenter
2021-09-02 9:27 ` Greg Kroah-Hartman
2021-08-28 11:10 ` [PATCH v5 3/3] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-09-02 9:28 ` Greg Kroah-Hartman
2021-09-03 8:11 ` Dan Carpenter [this message]
2021-08-30 10:52 ` [PATCH v5 0/3] staging: r8188eu: fix sparse warnings Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903074517.GG2151@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=aakashhemadri123@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--subject='Re: [PATCH v5 3/3] staging: r8188eu: incorrect type in assignment' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).