LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [linux-rt-devel:linux-5.14.y-rt-rebase 242/262] kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended'
@ 2021-09-04 19:00 kernel test robot
2021-09-06 7:54 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-09-04 19:00 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: kbuild-all, linux-kernel, Thomas Gleixner
[-- Attachment #1: Type: text/plain, Size: 2121 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.14.y-rt-rebase
head: 654401743eaa08fb02fd57e7ca86dfeb16a8264f
commit: 4e1854e1da111e0c0c6bf1969677f61abdbb4363 [242/262] x86: Allow to enable RT
config: x86_64-randconfig-a012-20210905 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=4e1854e1da111e0c0c6bf1969677f61abdbb4363
git remote add linux-rt-devel https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
git fetch --no-tags linux-rt-devel linux-5.14.y-rt-rebase
git checkout 4e1854e1da111e0c0c6bf1969677f61abdbb4363
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended' [-Wmissing-prototypes]
249 | int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/rt_rwlock_is_contended +249 kernel/locking/spinlock_rt.c
ca72c3eba593af Thomas Gleixner 2021-08-15 248
ca72c3eba593af Thomas Gleixner 2021-08-15 @249 int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
ca72c3eba593af Thomas Gleixner 2021-08-15 250 {
ca72c3eba593af Thomas Gleixner 2021-08-15 251 return rw_base_is_contended(&rwlock->rwbase);
ca72c3eba593af Thomas Gleixner 2021-08-15 252 }
ca72c3eba593af Thomas Gleixner 2021-08-15 253 EXPORT_SYMBOL(rt_rwlock_is_contended);
ca72c3eba593af Thomas Gleixner 2021-08-15 254
:::::: The code at line 249 was first introduced by commit
:::::: ca72c3eba593af8b6cce096b656c6cebd412d9b6 locking/rwlock: Provide RT variant
:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29144 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-rt-devel:linux-5.14.y-rt-rebase 242/262] kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended'
2021-09-04 19:00 [linux-rt-devel:linux-5.14.y-rt-rebase 242/262] kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended' kernel test robot
@ 2021-09-06 7:54 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2021-09-06 7:54 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, linux-kernel, Thomas Gleixner, Peter Zijlstra
On 2021-09-05 03:00:56 [+0800], kernel test robot wrote:
> >> kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended' [-Wmissing-prototypes]
> 249 | int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
>
> vim +/rt_rwlock_is_contended +249 kernel/locking/spinlock_rt.c
>
> ca72c3eba593af Thomas Gleixner 2021-08-15 248
> ca72c3eba593af Thomas Gleixner 2021-08-15 @249 int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
> ca72c3eba593af Thomas Gleixner 2021-08-15 250 {
> ca72c3eba593af Thomas Gleixner 2021-08-15 251 return rw_base_is_contended(&rwlock->rwbase);
> ca72c3eba593af Thomas Gleixner 2021-08-15 252 }
> ca72c3eba593af Thomas Gleixner 2021-08-15 253 EXPORT_SYMBOL(rt_rwlock_is_contended);
> ca72c3eba593af Thomas Gleixner 2021-08-15 254
| $ git grep rwlock_is_contended include/linux/rwlock_rt.h
| include/linux/rwlock_rt.h:#define rwlock_is_contended(lock) (((void)(lock), 0))
shouldn't we wire it up?
Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-06 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 19:00 [linux-rt-devel:linux-5.14.y-rt-rebase 242/262] kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended' kernel test robot
2021-09-06 7:54 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).