LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] media: i2c: ths8200 needs V4L2_ASYNC
@ 2021-09-04 23:28 Randy Dunlap
2021-09-05 21:41 ` Lad, Prabhakar
2021-09-06 7:56 ` Sakari Ailus
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-09-04 23:28 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Lad, Prabhakar, Hans Verkuil,
Sakari Ailus, Ezequiel Garcia, Mauro Carvalho Chehab,
linux-media
Fix the build errors reported by the kernel test robot by
selecting V4L2_ASYNC:
mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'
Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210903.orig/drivers/media/i2c/Kconfig
+++ linux-next-20210903/drivers/media/i2c/Kconfig
@@ -597,6 +597,7 @@ config VIDEO_AK881X
config VIDEO_THS8200
tristate "Texas Instruments THS8200 video encoder"
depends on VIDEO_V4L2 && I2C
+ select V4L2_ASYNC
help
Support for the Texas Instruments THS8200 video encoder.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: ths8200 needs V4L2_ASYNC
2021-09-04 23:28 [PATCH] media: i2c: ths8200 needs V4L2_ASYNC Randy Dunlap
@ 2021-09-05 21:41 ` Lad, Prabhakar
2021-09-06 7:56 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2021-09-05 21:41 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, kernel test robot, Hans Verkuil, Sakari Ailus,
Ezequiel Garcia, Mauro Carvalho Chehab, linux-media
Hi Randy,
Thank you for the patch.
On Sun, Sep 5, 2021 at 12:28 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Fix the build errors reported by the kernel test robot by
> selecting V4L2_ASYNC:
>
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'
>
> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Ezequiel Garcia <ezequiel@collabora.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
Prabhakar
> --- linux-next-20210903.orig/drivers/media/i2c/Kconfig
> +++ linux-next-20210903/drivers/media/i2c/Kconfig
> @@ -597,6 +597,7 @@ config VIDEO_AK881X
> config VIDEO_THS8200
> tristate "Texas Instruments THS8200 video encoder"
> depends on VIDEO_V4L2 && I2C
> + select V4L2_ASYNC
> help
> Support for the Texas Instruments THS8200 video encoder.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: ths8200 needs V4L2_ASYNC
2021-09-04 23:28 [PATCH] media: i2c: ths8200 needs V4L2_ASYNC Randy Dunlap
2021-09-05 21:41 ` Lad, Prabhakar
@ 2021-09-06 7:56 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2021-09-06 7:56 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Lad, Prabhakar, Hans Verkuil,
Ezequiel Garcia, Mauro Carvalho Chehab, linux-media
On Sat, Sep 04, 2021 at 04:28:08PM -0700, Randy Dunlap wrote:
> Fix the build errors reported by the kernel test robot by
> selecting V4L2_ASYNC:
>
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'
>
> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Ezequiel Garcia <ezequiel@collabora.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-06 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 23:28 [PATCH] media: i2c: ths8200 needs V4L2_ASYNC Randy Dunlap
2021-09-05 21:41 ` Lad, Prabhakar
2021-09-06 7:56 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).