LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Takashi Iwai <tiwai@suse.de> Subject: [PATCH 5.14 11/14] ALSA: hda/realtek: Workaround for conflicting SSID on ASUS ROG Strix G17 Date: Mon, 6 Sep 2021 14:55:57 +0200 [thread overview] Message-ID: <20210906125448.557469841@linuxfoundation.org> (raw) In-Reply-To: <20210906125448.160263393@linuxfoundation.org> From: Takashi Iwai <tiwai@suse.de> commit 13d9c6b998aaa76fd098133277a28a21f2cc2264 upstream. ASUS ROG Strix G17 has the very same PCI and codec SSID (1043:103f) as ASUS TX300, and unfortunately, the existing quirk for TX300 is broken on ASUS ROG. Actually the device works without the quirk, so we'll need to clear the quirk before applying for this device. Since ASUS ROG has a different codec (ALC294 - while TX300 has ALC282), this patch adds a workaround for the device, just clearing the codec->fixup_id by checking the codec vendor_id. It's a bit ugly to add such a workaround there, but it seems to be the simplest way. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214101 Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210820143214.3654-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- sound/pci/hda/patch_realtek.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9522,6 +9522,16 @@ static int patch_alc269(struct hda_codec snd_hda_pick_fixup(codec, alc269_fixup_models, alc269_fixup_tbl, alc269_fixups); + /* FIXME: both TX300 and ROG Strix G17 have the same SSID, and + * the quirk breaks the latter (bko#214101). + * Clear the wrong entry. + */ + if (codec->fixup_id == ALC282_FIXUP_ASUS_TX300 && + codec->core.vendor_id == 0x10ec0294) { + codec_dbg(codec, "Clear wrong fixup for ASUS ROG Strix G17\n"); + codec->fixup_id = HDA_FIXUP_ID_NOT_SET; + } + snd_hda_pick_pin_fixup(codec, alc269_pin_fixup_tbl, alc269_fixups, true); snd_hda_pick_pin_fixup(codec, alc269_fallback_pin_fixup_tbl, alc269_fixups, false); snd_hda_pick_fixup(codec, NULL, alc269_fixup_vendor_tbl,
next prev parent reply other threads:[~2021-09-06 12:59 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-06 12:55 [PATCH 5.14 00/14] 5.14.2-rc1 review Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 01/14] ext4: fix race writing to an inline_data file while its xattrs are changing Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 02/14] ext4: fix e2fsprogs checksum failure for mounted filesystem Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 03/14] xtensa: fix kconfig unmet dependency warning for HAVE_FUTEX_CMPXCHG Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 04/14] USB: serial: pl2303: fix GL type detection Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 05/14] USB: serial: cp210x: fix control-characters error handling Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 06/14] USB: serial: cp210x: fix flow-control " Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 07/14] HID: usbhid: Fix flood of "control queue full" messages Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 08/14] HID: usbhid: Fix warning caused by 0-length input reports Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 09/14] ALSA: hda/realtek: Quirk for HP Spectre x360 14 amp setup Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 10/14] ALSA: usb-audio: Fix regression on Sony WALKMAN NW-A45 DAC Greg Kroah-Hartman 2021-09-06 12:55 ` Greg Kroah-Hartman [this message] 2021-09-06 12:55 ` [PATCH 5.14 12/14] ALSA: pcm: fix divide error in snd_pcm_lib_ioctl Greg Kroah-Hartman 2021-09-06 12:55 ` [PATCH 5.14 13/14] ALSA: usb-audio: Work around for XRUN with low latency playback Greg Kroah-Hartman 2021-09-06 12:56 ` [PATCH 5.14 14/14] media: stkwebcam: fix memory leak in stk_camera_probe Greg Kroah-Hartman 2021-09-06 15:49 ` [PATCH 5.14 00/14] 5.14.2-rc1 review Fox Chen 2021-09-07 6:21 ` Naresh Kamboju 2021-09-07 16:30 ` Florian Fainelli 2021-09-07 20:06 ` Shuah Khan 2021-09-07 23:06 ` Justin Forbes 2021-09-08 1:20 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210906125448.557469841@linuxfoundation.org \ --to=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).