LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Jian Cai <jiancai@google.com>
Cc: mike.leach@linaro.org, linux@roeck-us.net, dianders@chromium.org,
	mka@chromium.org, manojgupta@google.com, llozano@google.com,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	clang-built-linux@googlegroups.com,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Leo Yan <leo.yan@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings
Date: Mon, 6 Sep 2021 09:06:25 -0600	[thread overview]
Message-ID: <20210906150625.GA1228692@p14s> (raw)
In-Reply-To: <20210830172820.2840433-1-jiancai@google.com>

On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
> 
> drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> implicit declaration of function 'kzalloc' [-Werror,
> -Wimplicit-function-declaration]
>         csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
>                              GFP_KERNEL);
> 
> Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jian Cai <jiancai@google.com>
> ---
> 
> Changes v1 -> v2:
>   Format the commit message and add Fixes and Reviewed-by tag.
> 
>  drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
>  1 file changed, 1 insertion(+)
>

I have applied this patch to my local tree.  I will push it to the coresight-next
branch when 5.15-rc1 is published next week.

Thanks,
Mathieu

> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
>   */
>  
>  #include <linux/platform_device.h>
> +#include <linux/slab.h>
>  
>  #include "coresight-config.h"
>  #include "coresight-etm-perf.h"
> -- 
> 2.33.0.259.gc128427fd7-goog
> 

  reply	other threads:[~2021-09-06 15:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 17:28 Jian Cai
2021-09-06 15:06 ` Mathieu Poirier [this message]
2021-09-07 17:51   ` Doug Anderson
2021-09-07 17:58     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210906150625.GA1228692@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=coresight@lists.linaro.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiancai@google.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=llozano@google.com \
    --cc=manojgupta@google.com \
    --cc=mike.leach@linaro.org \
    --cc=mka@chromium.org \
    --cc=suzuki.poulose@arm.com \
    --subject='Re: [PATCH v2] coresight: syscfg: fix compiler warnings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).