LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yang Weijiang <weijiang.yang@intel.com>
To: pbonzini@redhat.com, jmattson@google.com, seanjc@google.com,
	like.xu.linux@gmail.com, vkuznets@redhat.com,
	wei.w.wang@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Yang Weijiang <weijiang.yang@intel.com>
Subject: Re: [PATCH v8 00/15] Introduce Architectural LBR for vPMU
Date: Tue, 7 Sep 2021 11:26:07 +0800	[thread overview]
Message-ID: <20210907032607.GA9143@intel.com> (raw)
In-Reply-To: <1629791777-16430-1-git-send-email-weijiang.yang@intel.com>

On Tue, Aug 24, 2021 at 03:56:02PM +0800, Yang Weijiang wrote:

Hi, Paolo and other maintainers,
Do you have any comments on this patch series? Arch LBR is desired by
customers on new Intel platforms, so we'd like to upstream these patches.

Thanks a lot!

> The Architectural Last Branch Records (LBRs) is published in the 319433-040
> release of Intel Architecture Instruction Set Extensions and Future Features
> Programming Reference[0].
> 
> The main advantages of Arch LBR are [1]:
> - Faster context switching due to XSAVES support and faster reset of
>   LBR MSRs via the new DEPTH MSR
> - Faster LBR read for a non-PEBS event due to XSAVES support, which
>   lowers the overhead of the NMI handler.
> - Linux kernel can support the LBR features without knowing the model
>   number of the current CPU.
> 
> >From end user's point of view, the usage of Arch LBR is the same as
> the Legacy LBR that has been merged in the mainline.
> 
> Note, there's one limitations for current guest Arch LBR implementation:
> Guest can only use the same LBR record depth as host, this is due to
> the special behavior of MSR_ARCH_LBR_DEPTH: a) On write to the MSR,
> it'll reset all Arch LBR recording MSRs to 0s. b) XRSTORS will reset all
> recording MSRs to 0s if the saved depth mismatches MSR_ARCH_LBR_DEPTH.
> 
> But this limitation won't impact guest perf tool usage.
> 
> [0] https://software.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-and-future-features-programming-reference.html
> [1] https://lore.kernel.org/lkml/1593780569-62993-1-git-send-email-kan.liang@linux.intel.com/
> 
> Previous version:
> v7: https://lkml.kernel.org/kvm/1628235745-26566-1-git-send-email-weijiang.yang@intel.com/
> 
> Changes in v8:
> 1. Per Like's review feedback, changed corresponding patches.
> 2. Refactored part of the code, i.e., arch lbr depth, control configuration, to make them more precise.
> 
> 
> Like Xu (6):
>   perf/x86/intel: Fix the comment about guest LBR support on KVM
>   perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
>   KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBR
>   KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL for guest Arch LBR
>   KVM: x86: Refine the matching and clearing logic for supported_xss
>   KVM: x86: Add XSAVE Support for Architectural LBR
> 
> Sean Christopherson (1):
>   KVM: x86: Report XSS as an MSR to be saved if there are supported
>     features
> 
> Yang Weijiang (8):
>   KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list
>   KVM: x86/pmu: Refactor code to support guest Arch LBR
>   KVM: x86: Refresh CPUID on writes to MSR_IA32_XSS
>   KVM: x86/vmx: Check Arch LBR config when return perf capabilities
>   KVM: nVMX: Add necessary Arch LBR settings for nested VM
>   KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guest
>   KVM: x86/vmx: Flip Arch LBREn bit on guest state change
>   KVM: x86/cpuid: Advise Arch LBR feature in CPUID
> 
>  arch/x86/events/intel/core.c     |   3 +-
>  arch/x86/events/intel/lbr.c      |   6 +-
>  arch/x86/include/asm/kvm_host.h  |   4 +
>  arch/x86/include/asm/msr-index.h |   1 +
>  arch/x86/include/asm/vmx.h       |   4 +
>  arch/x86/kvm/cpuid.c             |  54 ++++++++++-
>  arch/x86/kvm/vmx/capabilities.h  |  25 +++--
>  arch/x86/kvm/vmx/nested.c        |   6 +-
>  arch/x86/kvm/vmx/pmu_intel.c     | 159 ++++++++++++++++++++++++++++---
>  arch/x86/kvm/vmx/vmcs12.c        |   1 +
>  arch/x86/kvm/vmx/vmcs12.h        |   3 +-
>  arch/x86/kvm/vmx/vmx.c           |  64 ++++++++++++-
>  arch/x86/kvm/x86.c               |  24 ++++-
>  13 files changed, 311 insertions(+), 43 deletions(-)
> 
> -- 
> 2.25.1

      parent reply	other threads:[~2021-09-07  3:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  7:56 Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 01/15] perf/x86/intel: Fix the comment about guest LBR support on KVM Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 02/15] perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 03/15] KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 04/15] KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBR Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 05/15] KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL " Yang Weijiang
2021-08-25  7:59   ` kernel test robot
2021-08-27  1:06   ` kernel test robot
2021-08-24  7:56 ` [PATCH v8 06/15] KVM: x86/pmu: Refactor code to support " Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 07/15] KVM: x86: Refresh CPUID on writes to MSR_IA32_XSS Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 08/15] KVM: x86: Report XSS as an MSR to be saved if there are supported features Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 09/15] KVM: x86: Refine the matching and clearing logic for supported_xss Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 10/15] KVM: x86: Add XSAVE Support for Architectural LBR Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 11/15] KVM: x86/vmx: Check Arch LBR config when return perf capabilities Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 12/15] KVM: nVMX: Add necessary Arch LBR settings for nested VM Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 13/15] KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guest Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 14/15] KVM: x86/vmx: Flip Arch LBREn bit on guest state change Yang Weijiang
2021-08-24  7:56 ` [PATCH v8 15/15] KVM: x86/cpuid: Advise Arch LBR feature in CPUID Yang Weijiang
2021-10-15  0:01   ` Sean Christopherson
2021-10-15  1:28     ` Yang Weijiang
2021-10-15  2:05       ` Like Xu
2021-10-15 14:49         ` Sean Christopherson
2021-09-07  3:26 ` Yang Weijiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907032607.GA9143@intel.com \
    --to=weijiang.yang@intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=vkuznets@redhat.com \
    --cc=wei.w.wang@intel.com \
    --subject='Re: [PATCH v8 00/15] Introduce Architectural LBR for vPMU' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).