LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: "Suren Baghdasaryan" <surenb@google.com>,
	"Hridya Valsaraju" <hridya@google.com>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"John Reitan" <john.reitan@arm.com>,
	"Ørjan Eide" <orjan.eide@arm.com>,
	"Mark Underwood" <mark.underwood@arm.com>,
	"Gary Sweet" <gary.sweet@broadcom.com>,
	"Stephen Mansfield" <stephen.mansfield@imgtec.com>,
	"Cc: Android Kernel" <kernel-team@android.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported tracepoint
Date: Tue, 7 Sep 2021 13:49:23 -0400	[thread overview]
Message-ID: <20210907134923.2dd41a8a@gandalf.local.home> (raw)
In-Reply-To: <CAC_TJvdv+BSQh0vqWmA220op+b5=8=ZYrhXcmDRE-Fppo0zE0w@mail.gmail.com>

On Fri, 3 Sep 2021 15:36:03 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:

> On Fri, Sep 3, 2021 at 1:30 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Tue, 31 Aug 2021 17:02:29 +0000
> > Kalesh Singh <kaleshsingh@google.com> wrote:
> >  
> > > The existing gpu_mem_total tracepoint provides GPU drivers a uniform way
> > > to report the per-process and system-wide GPU memory usage. This
> > > tracepoint reports a single total of the GPU private allocations and the
> > > imported memory. [1]
> > >
> > > To allow distinguishing GPU private vs imported memory, add an
> > > imported_size field to the gpu_mem_total tracepoint. GPU drivers can use
> > > this new field to report the per-process and global GPU-imported memory
> > > in a uniform way.
> > >
> > > User space tools can detect and handle the old vs new gpu_mem_total
> > > format via the gpu_mem/gpu_mem_total/format file.
> > >
> > > [1] https://lore.kernel.org/r/20200302234840.57188-1-zzyiwei@google.com/
> > >
> > > Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
> > > ---
> > >  include/trace/events/gpu_mem.h | 17 +++++++++++------
> > >  1 file changed, 11 insertions(+), 6 deletions(-)
> > >  
> >
> > This is that trace event that doesn't have any in tree callers, right? I
> > thought there was going to be some soon.  
> 
> The trace event is currently used by the Android GPU drivers, and
> there is some work ongoing to add this in drm core upstream but it's
> not yet ready.
> 
> >
> > For the updates to the tracing side (besides not having any users), it
> > looks trivial to me.
> >
> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > But this needs to be pulled in by one of the GPU maintainers.  
> 
> Thanks for the review Steve. I'll resend adding the GPU maintainers.

OK, so it was Greg that gave me the Ack to accept it.

I'll need his Ack again for the update.

-- Steve

  reply	other threads:[~2021-09-07 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 17:02 Kalesh Singh
2021-09-02 16:29 ` Kalesh Singh
2021-09-03 20:30 ` Steven Rostedt
2021-09-03 22:36   ` Kalesh Singh
2021-09-07 17:49     ` Steven Rostedt [this message]
2021-09-07 17:52       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907134923.2dd41a8a@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=gary.sweet@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hridya@google.com \
    --cc=john.reitan@arm.com \
    --cc=kaleshsingh@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.underwood@arm.com \
    --cc=mingo@redhat.com \
    --cc=orjan.eide@arm.com \
    --cc=stephen.mansfield@imgtec.com \
    --cc=surenb@google.com \
    --subject='Re: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported tracepoint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).