LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Doug Anderson <dianders@chromium.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Jian Cai <jiancai@google.com>, Mike Leach <mike.leach@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Manoj Gupta <manojgupta@google.com>,
Luis Lozano <llozano@google.com>,
coresight@lists.linaro.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Leo Yan <leo.yan@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings
Date: Tue, 7 Sep 2021 10:58:23 -0700 [thread overview]
Message-ID: <20210907175823.GB235361@roeck-us.net> (raw)
In-Reply-To: <CAD=FV=Ukx_PRpfnLXEBajtts78ays=6+nGb+CRVn76xjyNkn5A@mail.gmail.com>
On Tue, Sep 07, 2021 at 10:51:53AM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 6, 2021 at 8:06 AM Mathieu Poirier
> <mathieu.poirier@linaro.org> wrote:
> >
> > On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> > > This fixes warnings with -Wimplicit-function-declaration, e.g.
> > >
> > > drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> > > implicit declaration of function 'kzalloc' [-Werror,
> > > -Wimplicit-function-declaration]
> > > csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> > > GFP_KERNEL);
> > >
> > > Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > Signed-off-by: Jian Cai <jiancai@google.com>
> > > ---
> > >
> > > Changes v1 -> v2:
> > > Format the commit message and add Fixes and Reviewed-by tag.
> > >
> > > drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> >
> > I have applied this patch to my local tree. I will push it to the coresight-next
> > branch when 5.15-rc1 is published next week.
>
> Out of curiosity, does the fact that it'll be in coresight-next mean
> that this will target v5.15 or v5.16? I usually think of "-next"
> branches as targeting one major version later, so I'd assume v5.16?
> ...but it would be nice if this warning could get fixed somewhere in
> v5.15.
>
Normally "when 5.15-rc1 is published" would imply v5.16.
Note that warnings are now reported as errors in mainline,
since -Werror is now enabled by default.
Guenter
prev parent reply other threads:[~2021-09-07 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 17:28 Jian Cai
2021-09-06 15:06 ` Mathieu Poirier
2021-09-07 17:51 ` Doug Anderson
2021-09-07 17:58 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907175823.GB235361@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexander.shishkin@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=coresight@lists.linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiancai@google.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llozano@google.com \
--cc=manojgupta@google.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mka@chromium.org \
--cc=suzuki.poulose@arm.com \
--subject='Re: [PATCH v2] coresight: syscfg: fix compiler warnings' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).