LKML Archive on
help / color / mirror / Atom feed
From: Steven Rostedt <>
To: Punit Agrawal <>
Subject: Re: [RESEND PATCH] tools/bootconfig: Fix a compilation issue with missing variable
Date: Tue, 7 Sep 2021 20:24:00 -0400	[thread overview]
Message-ID: <20210907202400.330f4ea4@rorschach.local.home> (raw)
In-Reply-To: <>

On Wed,  8 Sep 2021 08:07:10 +0900
Punit Agrawal <> wrote:

> While looking to build bootconfig tool in order to debug a kernel boot
> time issue I noticed that tool fails to compile. The broken changes
> were introduced by commit e5efaeb8a8f5 ("bootconfig: Support mixing a
> value and subkeys under a key").
> Fix the compile issue by introducing a "ret" variable to track the
> return value from xbc_node_compose_key().
> Fixes: e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under a key")
> Signed-off-by: Punit Agrawal <>
> Cc: Masami Hiramatsu <>
> Cc: Steven Rostedt <>
> ---
> (Apologies for the resend. I fat-fingered the email address for lkml)

And I'm resending my reply to have it recorded as well.

> Hi Masami,
> I am not sure what went wrong but the patch in the lore link[0]
> doesn't match the end result (bad merge?). You may want to recheck the
> other changes to make sure it all looks sane.

Thanks for reporting this. This is strange. Especially since it's all
scripts that are used to import these.

I do remember doing a rebase to fix some issues in another unrelated
patch. I wonder if I accidentally messed this up during that rebase :-/

I'll have to investigate this.

I'll checkout the tree before the affected patch, and reapply the
changes from my scripts to see if it wasn't my script that broke.

Again, thanks for reporting this!

-- Steve

  parent reply	other threads:[~2021-09-08  0:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 23:07 Punit Agrawal
2021-09-08  0:13 ` Masami Hiramatsu
2021-09-08  0:27   ` Steven Rostedt
2021-09-08  0:34   ` Masami Hiramatsu
2021-09-08  0:24 ` Steven Rostedt [this message]
2021-09-08  0:41   ` Masami Hiramatsu
2021-09-08  0:45     ` Steven Rostedt
2021-09-09  8:31       ` Punit Agrawal
2021-09-08  0:44 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907202400.330f4ea4@rorschach.local.home \ \ \ \ \
    --subject='Re: [RESEND PATCH] tools/bootconfig: Fix a compilation issue with missing variable' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).