From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724A7C433F5 for ; Fri, 10 Sep 2021 14:08:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55043611BF for ; Fri, 10 Sep 2021 14:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233799AbhIJOJ2 (ORCPT ); Fri, 10 Sep 2021 10:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbhIJOJ0 (ORCPT ); Fri, 10 Sep 2021 10:09:26 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF21C061574 for ; Fri, 10 Sep 2021 07:08:15 -0700 (PDT) Date: Fri, 10 Sep 2021 16:08:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1631282891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bSyyP9yahgxFA1b8RnoWYThoroPSM6gbfo1YmaotaKo=; b=tIMCArcKFzMnU5Qw4KZv75f/XpNJ5QosPdywYAK3mKVRKDj5ndlnpeKcU0PrPzXo5kttMs qIdgMQNlbhMZyRcg9T5/nEqUa8CKeFwLcdWfILSSF/BHyBxars+Tu159CdlCBb82vuASq2 hDAfeAviVKKpylcfxQdRCRN64G4+XoY5fXQsfP0voveFFIa/QkL7mjQT1/99ewfARlMgX/ QxjD/taJlOCV1O3Axu/4uQfPcnr4BHPLQHdR74ogN/faNjLLQYfBMpGiiuP1VY2RANo2q1 JmZo0nwSl+4mqSXPCEMekVj5buFVemOqu8kVy5T2BRZkPkiJRBNqwrYZoI+Ang== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1631282891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bSyyP9yahgxFA1b8RnoWYThoroPSM6gbfo1YmaotaKo=; b=7JsiFf4a9XWtWjkLYLcPu7V7CzWcBWXfEhw7EmXVMPCJ9OuhjMWbhKdaNnEcvd8ugkIuEy B/C0bg7ZrlSuLcBA== From: Sebastian Andrzej Siewior To: Marco Elver Cc: Andrew Morton , Shuah Khan , Tejun Heo , Lai Jiangshan , Andrey Konovalov , Walter Wu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vijayanand Jitta , Vinayak Menon , "Gustavo A. R. Silva" , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Aleksandr Nogikh , Taras Madan Subject: Re: [PATCH 3/6] lib/stackdepot: introduce __stack_depot_save() Message-ID: <20210910140810.jxb6sfgkdzefqgio@linutronix.de> References: <20210907141307.1437816-1-elver@google.com> <20210907141307.1437816-4-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210907141307.1437816-4-elver@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-09-07 16:13:04 [+0200], Marco Elver wrote: > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index c80a9f734253..cab6cf117290 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -339,6 +350,25 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, > fast_exit: > return retval; > } > +EXPORT_SYMBOL_GPL(__stack_depot_save); > + > +/** > + * stack_depot_save - Save a stack trace from an array > + * > + * @entries: Pointer to storage array > + * @nr_entries: Size of the storage array > + * @alloc_flags: Allocation gfp flags > + * > + * Context: Contexts where allocations via alloc_pages() are allowed. Could we add here something like (see __stack_depot_save() for details) since it has more verbose. Sebastian