LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] perf tools: Ignore Documentation dependency file
@ 2021-09-10 23:22 Ian Rogers
  2021-09-11 18:37 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2021-09-10 23:22 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
	linux-perf-users, linux-kernel
  Cc: Linus Torvalds, Ian Rogers

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Fixes: a81df63a5df3 ("perf doc: Fix doc.dep")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index e555e9729758..8e0163b7ef01 100644
--- a/tools/perf/.gitignore
+++ b/tools/perf/.gitignore
@@ -39,3 +39,4 @@ pmu-events/jevents
 feature/
 fixdep
 libtraceevent-dynamic-list
+Documentation/doc.dep
-- 
2.33.0.309.g3052b89438-goog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf tools: Ignore Documentation dependency file
  2021-09-10 23:22 [PATCH] perf tools: Ignore Documentation dependency file Ian Rogers
@ 2021-09-11 18:37 ` Arnaldo Carvalho de Melo
  2021-09-11 18:57   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-11 18:37 UTC (permalink / raw)
  To: Ian Rogers
  Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, linux-perf-users, linux-kernel,
	Linus Torvalds

Em Fri, Sep 10, 2021 at 04:22:49PM -0700, Ian Rogers escreveu:
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Fixes: a81df63a5df3 ("perf doc: Fix doc.dep")
> Signed-off-by: Ian Rogers <irogers@google.com>

Thanks for the patch, but you forgot to mention _why_ we should ignore
that file, I'll try to figure out.

- Arnaldo

> ---
>  tools/perf/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> index e555e9729758..8e0163b7ef01 100644
> --- a/tools/perf/.gitignore
> +++ b/tools/perf/.gitignore
> @@ -39,3 +39,4 @@ pmu-events/jevents
>  feature/
>  fixdep
>  libtraceevent-dynamic-list
> +Documentation/doc.dep
> -- 
> 2.33.0.309.g3052b89438-goog

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf tools: Ignore Documentation dependency file
  2021-09-11 18:37 ` Arnaldo Carvalho de Melo
@ 2021-09-11 18:57   ` Arnaldo Carvalho de Melo
  2021-09-12 16:21     ` Ian Rogers
  0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-11 18:57 UTC (permalink / raw)
  To: Ian Rogers
  Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, linux-perf-users, linux-kernel,
	Linus Torvalds

Em Sat, Sep 11, 2021 at 03:37:20PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 10, 2021 at 04:22:49PM -0700, Ian Rogers escreveu:
> > Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Fixes: a81df63a5df3 ("perf doc: Fix doc.dep")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> 
> Thanks for the patch, but you forgot to mention _why_ we should ignore
> that file, I'll try to figure out.

Added this, probably anodine, but better than nothing :-)

---
When building directly on the checked out repository the build process
produces a file that should be ignored, so add it to .gitignore.
---

 
- Arnaldo
> 
> > ---
> >  tools/perf/.gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> > index e555e9729758..8e0163b7ef01 100644
> > --- a/tools/perf/.gitignore
> > +++ b/tools/perf/.gitignore
> > @@ -39,3 +39,4 @@ pmu-events/jevents
> >  feature/
> >  fixdep
> >  libtraceevent-dynamic-list
> > +Documentation/doc.dep
> > -- 
> > 2.33.0.309.g3052b89438-goog
> 
> -- 
> 
> - Arnaldo

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf tools: Ignore Documentation dependency file
  2021-09-11 18:57   ` Arnaldo Carvalho de Melo
@ 2021-09-12 16:21     ` Ian Rogers
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Rogers @ 2021-09-12 16:21 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, linux-perf-users, linux-kernel,
	Linus Torvalds

On Sat, Sep 11, 2021 at 11:57 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Sat, Sep 11, 2021 at 03:37:20PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Sep 10, 2021 at 04:22:49PM -0700, Ian Rogers escreveu:
> > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> > > Fixes: a81df63a5df3 ("perf doc: Fix doc.dep")
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> >
> > Thanks for the patch, but you forgot to mention _why_ we should ignore
> > that file, I'll try to figure out.
>
> Added this, probably anodine, but better than nothing :-)
>
> ---
> When building directly on the checked out repository the build process
> produces a file that should be ignored, so add it to .gitignore.
> ---

Sounds good to me.

Thanks,
Ian

> - Arnaldo
> >
> > > ---
> > >  tools/perf/.gitignore | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> > > index e555e9729758..8e0163b7ef01 100644
> > > --- a/tools/perf/.gitignore
> > > +++ b/tools/perf/.gitignore
> > > @@ -39,3 +39,4 @@ pmu-events/jevents
> > >  feature/
> > >  fixdep
> > >  libtraceevent-dynamic-list
> > > +Documentation/doc.dep
> > > --
> > > 2.33.0.309.g3052b89438-goog
> >
> > --
> >
> > - Arnaldo
>
> --
>
> - Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-12 16:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 23:22 [PATCH] perf tools: Ignore Documentation dependency file Ian Rogers
2021-09-11 18:37 ` Arnaldo Carvalho de Melo
2021-09-11 18:57   ` Arnaldo Carvalho de Melo
2021-09-12 16:21     ` Ian Rogers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).