LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd'
@ 2021-09-11  0:38 kernel test robot
  2021-09-13 15:19 ` Daniel Borkmann
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-09-11  0:38 UTC (permalink / raw)
  To: Daniel Borkmann; +Cc: llvm, kbuild-all, Daniel Borkmann, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 38398 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-cgrp
head:   5a6e78baee7515884b93a90c5d03db601bc9063a
commit: f36377d0c40cce0cdeaff50031c268bc640d94f0 [2/4] bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode
config: i386-randconfig-r032-20210910 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f36377d0c40cce0cdeaff50031c268bc640d94f0
        git remote add dborkman https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git
        git fetch --no-tags dborkman pr/bpf-cgrp
        git checkout f36377d0c40cce0cdeaff50031c268bc640d94f0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
   include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter]
   static inline int bpf_trampoline_link_prog(struct bpf_prog *prog,
                                                               ^
   include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter]
                                              struct bpf_trampoline *tr)
                                                                     ^
   include/linux/bpf.h:775:63: warning: unused parameter 'prog' [-Wunused-parameter]
   static inline int bpf_trampoline_unlink_prog(struct bpf_prog *prog,
                                                                 ^
   include/linux/bpf.h:776:34: warning: unused parameter 'tr' [-Wunused-parameter]
                                                struct bpf_trampoline *tr)
                                                                       ^
   include/linux/bpf.h:780:61: warning: unused parameter 'key' [-Wunused-parameter]
   static inline struct bpf_trampoline *bpf_trampoline_get(u64 key,
                                                               ^
   include/linux/bpf.h:781:39: warning: unused parameter 'tgt_info' [-Wunused-parameter]
                                                           struct bpf_attach_target_info *tgt_info)
                                                                                          ^
   include/linux/bpf.h:785:62: warning: unused parameter 'tr' [-Wunused-parameter]
   static inline void bpf_trampoline_put(struct bpf_trampoline *tr) {}
                                                                ^
   include/linux/bpf.h:790:70: warning: unused parameter 'd' [-Wunused-parameter]
   static inline void bpf_dispatcher_change_prog(struct bpf_dispatcher *d,
                                                                        ^
   include/linux/bpf.h:791:29: warning: unused parameter 'from' [-Wunused-parameter]
                                                 struct bpf_prog *from,
                                                                  ^
   include/linux/bpf.h:792:29: warning: unused parameter 'to' [-Wunused-parameter]
                                                 struct bpf_prog *to) {}
                                                                  ^
   include/linux/bpf.h:793:55: warning: unused parameter 'address' [-Wunused-parameter]
   static inline bool is_bpf_image_address(unsigned long address)
                                                         ^
   include/linux/bpf.h:1012:68: warning: unused parameter 'type_id' [-Wunused-parameter]
   static inline const struct bpf_struct_ops *bpf_struct_ops_find(u32 type_id)
                                                                      ^
   include/linux/bpf.h:1016:52: warning: unused parameter 'btf' [-Wunused-parameter]
   static inline void bpf_struct_ops_init(struct btf *btf,
                                                      ^
   include/linux/bpf.h:1017:37: warning: unused parameter 'log' [-Wunused-parameter]
                                          struct bpf_verifier_log *log)
                                                                   ^
   include/linux/bpf.h:1020:51: warning: unused parameter 'data' [-Wunused-parameter]
   static inline bool bpf_try_module_get(const void *data, struct module *owner)
                                                     ^
   include/linux/bpf.h:1024:47: warning: unused parameter 'data' [-Wunused-parameter]
   static inline void bpf_module_put(const void *data, struct module *owner)
                                                 ^
   include/linux/bpf.h:1028:70: warning: unused parameter 'map' [-Wunused-parameter]
   static inline int bpf_struct_ops_map_sys_lookup_elem(struct bpf_map *map,
                                                                        ^
   include/linux/bpf.h:1029:18: warning: unused parameter 'key' [-Wunused-parameter]
                                                        void *key,
                                                              ^
   include/linux/bpf.h:1030:18: warning: unused parameter 'value' [-Wunused-parameter]
                                                        void *value)
                                                              ^
   include/linux/bpf.h:1407:44: warning: unused parameter 'map' [-Wunused-parameter]
   bpf_map_kmalloc_node(const struct bpf_map *map, size_t size, gfp_t flags,
                                              ^
   include/linux/bpf.h:1414:39: warning: unused parameter 'map' [-Wunused-parameter]
   bpf_map_kzalloc(const struct bpf_map *map, size_t size, gfp_t flags)
                                         ^
   include/linux/bpf.h:1420:44: warning: unused parameter 'map' [-Wunused-parameter]
   bpf_map_alloc_percpu(const struct bpf_map *map, size_t size, size_t align,
                                              ^
   In file included from drivers/gpu/drm/i915/i915_drv.c:39:
   In file included from include/linux/vga_switcheroo.h:34:
   In file included from include/linux/fb.h:6:
   In file included from include/uapi/linux/fb.h:6:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:23:
   In file included from include/linux/psi_types.h:4:
   include/linux/kthread.h:218:72: warning: unused parameter 'css' [-Wunused-parameter]
   static inline void kthread_associate_blkcg(struct cgroup_subsys_state *css) { }
                                                                          ^
   In file included from drivers/gpu/drm/i915/i915_drv.c:39:
   In file included from include/linux/vga_switcheroo.h:34:
   In file included from include/linux/fb.h:6:
   In file included from include/uapi/linux/fb.h:6:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   include/linux/cgroup-defs.h:720:72: warning: unused parameter 'tsk' [-Wunused-parameter]
   static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
                                                                          ^
   include/linux/cgroup-defs.h:731:70: warning: unused parameter 'tsk' [-Wunused-parameter]
   static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
                                                                        ^
>> include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline u16 sock_cgroup_prioidx(const struct sock_cgroup_data *skcd)
                                                                        ^
   include/linux/cgroup-defs.h:780:70: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline u32 sock_cgroup_classid(const struct sock_cgroup_data *skcd)
                                                                        ^
   include/linux/cgroup-defs.h:789:69: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline void sock_cgroup_set_prioidx(struct sock_cgroup_data *skcd,
                                                                       ^
>> include/linux/cgroup-defs.h:790:13: warning: unused parameter 'prioidx' [-Wunused-parameter]
                                              u16 prioidx)
                                                  ^
   include/linux/cgroup-defs.h:797:69: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline void sock_cgroup_set_classid(struct sock_cgroup_data *skcd,
                                                                       ^
>> include/linux/cgroup-defs.h:798:13: warning: unused parameter 'classid' [-Wunused-parameter]
                                              u32 classid)
                                                  ^
   In file included from drivers/gpu/drm/i915/i915_drv.c:39:
   In file included from include/linux/vga_switcheroo.h:34:
   In file included from include/linux/fb.h:6:
   In file included from include/uapi/linux/fb.h:6:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
   In file included from include/linux/writeback.h:12:
   include/linux/backing-dev-defs.h:282:52: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline bool wb_tryget(struct bdi_writeback *wb)
                                                      ^
   include/linux/backing-dev-defs.h:287:49: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline void wb_get(struct bdi_writeback *wb)
                                                   ^
   include/linux/backing-dev-defs.h:291:49: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline void wb_put(struct bdi_writeback *wb)
                                                   ^
   include/linux/backing-dev-defs.h:295:54: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
                                                        ^
   include/linux/backing-dev-defs.h:295:72: warning: unused parameter 'nr' [-Wunused-parameter]
   static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
                                                                          ^
   include/linux/backing-dev-defs.h:299:51: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline bool wb_dying(struct bdi_writeback *wb)
                                                     ^
   In file included from drivers/gpu/drm/i915/i915_drv.c:39:
   In file included from include/linux/vga_switcheroo.h:34:
   In file included from include/linux/fb.h:6:
   In file included from include/uapi/linux/fb.h:6:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
   In file included from include/linux/writeback.h:13:
   In file included from include/linux/blk_types.h:10:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:12:
   In file included from arch/x86/include/asm/cacheflush.h:8:
   include/asm-generic/cacheflush.h:21:53: warning: unused parameter 'mm' [-Wunused-parameter]
   static inline void flush_cache_mm(struct mm_struct *mm)
                                                       ^
   include/asm-generic/cacheflush.h:27:57: warning: unused parameter 'mm' [-Wunused-parameter]
   static inline void flush_cache_dup_mm(struct mm_struct *mm)
                                                           ^
   include/asm-generic/cacheflush.h:33:61: warning: unused parameter 'vma' [-Wunused-parameter]
   static inline void flush_cache_range(struct vm_area_struct *vma,
                                                               ^
   include/asm-generic/cacheflush.h:34:24: warning: unused parameter 'start' [-Wunused-parameter]
                                        unsigned long start,
                                                      ^
   include/asm-generic/cacheflush.h:35:24: warning: unused parameter 'end' [-Wunused-parameter]
                                        unsigned long end)
                                                      ^
   include/asm-generic/cacheflush.h:41:60: warning: unused parameter 'vma' [-Wunused-parameter]
   static inline void flush_cache_page(struct vm_area_struct *vma,
                                                              ^
   include/asm-generic/cacheflush.h:42:23: warning: unused parameter 'vmaddr' [-Wunused-parameter]
                                       unsigned long vmaddr,
                                                     ^
   include/asm-generic/cacheflush.h:43:23: warning: unused parameter 'pfn' [-Wunused-parameter]
                                       unsigned long pfn)
                                                     ^
   include/asm-generic/cacheflush.h:49:51: warning: unused parameter 'page' [-Wunused-parameter]
   static inline void flush_dcache_page(struct page *page)
                                                     ^
   include/asm-generic/cacheflush.h:57:65: warning: unused parameter 'mapping' [-Wunused-parameter]
   static inline void flush_dcache_mmap_lock(struct address_space *mapping)
                                                                   ^
   include/asm-generic/cacheflush.h:63:67: warning: unused parameter 'mapping' [-Wunused-parameter]
   static inline void flush_dcache_mmap_unlock(struct address_space *mapping)
                                                                     ^
   include/asm-generic/cacheflush.h:69:53: warning: unused parameter 'start' [-Wunused-parameter]
   static inline void flush_icache_range(unsigned long start, unsigned long end)
                                                       ^
   include/asm-generic/cacheflush.h:69:74: warning: unused parameter 'end' [-Wunused-parameter]
   static inline void flush_icache_range(unsigned long start, unsigned long end)
                                                                            ^
   include/asm-generic/cacheflush.h:79:61: warning: unused parameter 'vma' [-Wunused-parameter]
   static inline void flush_icache_page(struct vm_area_struct *vma,
                                                               ^
   include/asm-generic/cacheflush.h:80:23: warning: unused parameter 'page' [-Wunused-parameter]
                                        struct page *page)
                                                     ^
   include/asm-generic/cacheflush.h:86:66: warning: unused parameter 'vma' [-Wunused-parameter]
   static inline void flush_icache_user_page(struct vm_area_struct *vma,
                                                                    ^
   include/asm-generic/cacheflush.h:87:22: warning: unused parameter 'page' [-Wunused-parameter]
                                              struct page *page,
                                                           ^
   include/asm-generic/cacheflush.h:88:23: warning: unused parameter 'addr' [-Wunused-parameter]
                                              unsigned long addr, int len)
                                                            ^
   include/asm-generic/cacheflush.h:88:33: warning: unused parameter 'len' [-Wunused-parameter]
                                              unsigned long addr, int len)
--
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
   include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter]
   static inline int bpf_trampoline_link_prog(struct bpf_prog *prog,
                                                               ^
   include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter]
                                              struct bpf_trampoline *tr)
                                                                     ^
   include/linux/bpf.h:775:63: warning: unused parameter 'prog' [-Wunused-parameter]
   static inline int bpf_trampoline_unlink_prog(struct bpf_prog *prog,
                                                                 ^
   include/linux/bpf.h:776:34: warning: unused parameter 'tr' [-Wunused-parameter]
                                                struct bpf_trampoline *tr)
                                                                       ^
   include/linux/bpf.h:780:61: warning: unused parameter 'key' [-Wunused-parameter]
   static inline struct bpf_trampoline *bpf_trampoline_get(u64 key,
                                                               ^
   include/linux/bpf.h:781:39: warning: unused parameter 'tgt_info' [-Wunused-parameter]
                                                           struct bpf_attach_target_info *tgt_info)
                                                                                          ^
   include/linux/bpf.h:785:62: warning: unused parameter 'tr' [-Wunused-parameter]
   static inline void bpf_trampoline_put(struct bpf_trampoline *tr) {}
                                                                ^
   include/linux/bpf.h:790:70: warning: unused parameter 'd' [-Wunused-parameter]
   static inline void bpf_dispatcher_change_prog(struct bpf_dispatcher *d,
                                                                        ^
   include/linux/bpf.h:791:29: warning: unused parameter 'from' [-Wunused-parameter]
                                                 struct bpf_prog *from,
                                                                  ^
   include/linux/bpf.h:792:29: warning: unused parameter 'to' [-Wunused-parameter]
                                                 struct bpf_prog *to) {}
                                                                  ^
   include/linux/bpf.h:793:55: warning: unused parameter 'address' [-Wunused-parameter]
   static inline bool is_bpf_image_address(unsigned long address)
                                                         ^
   include/linux/bpf.h:1012:68: warning: unused parameter 'type_id' [-Wunused-parameter]
   static inline const struct bpf_struct_ops *bpf_struct_ops_find(u32 type_id)
                                                                      ^
   include/linux/bpf.h:1016:52: warning: unused parameter 'btf' [-Wunused-parameter]
   static inline void bpf_struct_ops_init(struct btf *btf,
                                                      ^
   include/linux/bpf.h:1017:37: warning: unused parameter 'log' [-Wunused-parameter]
                                          struct bpf_verifier_log *log)
                                                                   ^
   include/linux/bpf.h:1020:51: warning: unused parameter 'data' [-Wunused-parameter]
   static inline bool bpf_try_module_get(const void *data, struct module *owner)
                                                     ^
   include/linux/bpf.h:1024:47: warning: unused parameter 'data' [-Wunused-parameter]
   static inline void bpf_module_put(const void *data, struct module *owner)
                                                 ^
   include/linux/bpf.h:1028:70: warning: unused parameter 'map' [-Wunused-parameter]
   static inline int bpf_struct_ops_map_sys_lookup_elem(struct bpf_map *map,
                                                                        ^
   include/linux/bpf.h:1029:18: warning: unused parameter 'key' [-Wunused-parameter]
                                                        void *key,
                                                              ^
   include/linux/bpf.h:1030:18: warning: unused parameter 'value' [-Wunused-parameter]
                                                        void *value)
                                                              ^
   include/linux/bpf.h:1407:44: warning: unused parameter 'map' [-Wunused-parameter]
   bpf_map_kmalloc_node(const struct bpf_map *map, size_t size, gfp_t flags,
                                              ^
   include/linux/bpf.h:1414:39: warning: unused parameter 'map' [-Wunused-parameter]
   bpf_map_kzalloc(const struct bpf_map *map, size_t size, gfp_t flags)
                                         ^
   include/linux/bpf.h:1420:44: warning: unused parameter 'map' [-Wunused-parameter]
   bpf_map_alloc_percpu(const struct bpf_map *map, size_t size, size_t align,
                                              ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:23:
   In file included from include/linux/psi_types.h:4:
   include/linux/kthread.h:218:72: warning: unused parameter 'css' [-Wunused-parameter]
   static inline void kthread_associate_blkcg(struct cgroup_subsys_state *css) { }
                                                                          ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   include/linux/cgroup-defs.h:720:72: warning: unused parameter 'tsk' [-Wunused-parameter]
   static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
                                                                          ^
   include/linux/cgroup-defs.h:731:70: warning: unused parameter 'tsk' [-Wunused-parameter]
   static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
                                                                        ^
>> include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline u16 sock_cgroup_prioidx(const struct sock_cgroup_data *skcd)
                                                                        ^
   include/linux/cgroup-defs.h:780:70: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline u32 sock_cgroup_classid(const struct sock_cgroup_data *skcd)
                                                                        ^
   include/linux/cgroup-defs.h:789:69: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline void sock_cgroup_set_prioidx(struct sock_cgroup_data *skcd,
                                                                       ^
>> include/linux/cgroup-defs.h:790:13: warning: unused parameter 'prioidx' [-Wunused-parameter]
                                              u16 prioidx)
                                                  ^
   include/linux/cgroup-defs.h:797:69: warning: unused parameter 'skcd' [-Wunused-parameter]
   static inline void sock_cgroup_set_classid(struct sock_cgroup_data *skcd,
                                                                       ^
>> include/linux/cgroup-defs.h:798:13: warning: unused parameter 'classid' [-Wunused-parameter]
                                              u32 classid)
                                                  ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
   In file included from include/linux/writeback.h:12:
   include/linux/backing-dev-defs.h:282:52: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline bool wb_tryget(struct bdi_writeback *wb)
                                                      ^
   include/linux/backing-dev-defs.h:287:49: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline void wb_get(struct bdi_writeback *wb)
                                                   ^
   include/linux/backing-dev-defs.h:291:49: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline void wb_put(struct bdi_writeback *wb)
                                                   ^
   include/linux/backing-dev-defs.h:295:54: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
                                                        ^
   include/linux/backing-dev-defs.h:295:72: warning: unused parameter 'nr' [-Wunused-parameter]
   static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
                                                                          ^
   include/linux/backing-dev-defs.h:299:51: warning: unused parameter 'wb' [-Wunused-parameter]
   static inline bool wb_dying(struct bdi_writeback *wb)
                                                     ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
   In file included from include/linux/writeback.h:14:
   In file included from include/linux/blk-cgroup.h:23:
   In file included from include/linux/blkdev.h:8:
   include/linux/genhd.h:302:60: warning: unused parameter 'bdev' [-Wunused-parameter]
   static inline int bd_link_disk_holder(struct block_device *bdev,
                                                              ^
   include/linux/genhd.h:303:27: warning: unused parameter 'disk' [-Wunused-parameter]
                                         struct gendisk *disk)
                                                         ^
   include/linux/genhd.h:307:63: warning: unused parameter 'bdev' [-Wunused-parameter]
   static inline void bd_unlink_disk_holder(struct block_device *bdev,
                                                                 ^
   include/linux/genhd.h:308:23: warning: unused parameter 'disk' [-Wunused-parameter]
                                            struct gendisk *disk)
                                                            ^
   include/linux/genhd.h:311:63: warning: unused parameter 'disk' [-Wunused-parameter]
   static inline int bd_register_pending_holders(struct gendisk *disk)
                                                                 ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
   In file included from include/linux/writeback.h:14:
   In file included from include/linux/blk-cgroup.h:23:
   In file included from include/linux/blkdev.h:17:
   include/linux/bio.h:394:14: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
           if (sectors >= bio_sectors(bio))
               ~~~~~~~ ^  ~~~~~~~~~~~~~~~~
   include/linux/bio.h:516:51: warning: unused parameter 'bio' [-Wunused-parameter]
   static inline void bio_associate_blkg(struct bio *bio) { }
                                                     ^
   include/linux/bio.h:517:60: warning: unused parameter 'bio' [-Wunused-parameter]
   static inline void bio_associate_blkg_from_css(struct bio *bio,
                                                              ^
   include/linux/bio.h:518:41: warning: unused parameter 'css' [-Wunused-parameter]
                                                  struct cgroup_subsys_state *css)
                                                                              ^
   include/linux/bio.h:520:59: warning: unused parameter 'dst' [-Wunused-parameter]
   static inline void bio_clone_blkg_association(struct bio *dst,
                                                             ^
   include/linux/bio.h:521:24: warning: unused parameter 'src' [-Wunused-parameter]
                                                 struct bio *src) { }
                                                             ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
   In file included from include/linux/writeback.h:14:
   In file included from include/linux/blk-cgroup.h:23:
   include/linux/blkdev.h:866:58: warning: unused parameter 'rq' [-Wunused-parameter]
   static inline void rq_flush_dcache_pages(struct request *rq)
                                                            ^
   In file included from drivers/gpu/drm/i915/i915_config.c:6:
   In file included from drivers/gpu/drm/i915/i915_drv.h:39:
   In file included from include/linux/i2c.h:18:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:22:
..


vim +/skcd +771 include/linux/cgroup-defs.h

1ed1328792ff46 Tejun Heo       2015-09-16  712  
1ed1328792ff46 Tejun Heo       2015-09-16  713  /**
1ed1328792ff46 Tejun Heo       2015-09-16  714   * cgroup_threadgroup_change_begin - threadgroup exclusion for cgroups
1ed1328792ff46 Tejun Heo       2015-09-16  715   * @tsk: target task
1ed1328792ff46 Tejun Heo       2015-09-16  716   *
780de9dd2720de Ingo Molnar     2017-02-02  717   * Allows cgroup operations to synchronize against threadgroup changes
780de9dd2720de Ingo Molnar     2017-02-02  718   * using a percpu_rw_semaphore.
1ed1328792ff46 Tejun Heo       2015-09-16  719   */
1ed1328792ff46 Tejun Heo       2015-09-16 @720  static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
1ed1328792ff46 Tejun Heo       2015-09-16  721  {
1ed1328792ff46 Tejun Heo       2015-09-16  722  	percpu_down_read(&cgroup_threadgroup_rwsem);
1ed1328792ff46 Tejun Heo       2015-09-16  723  }
1ed1328792ff46 Tejun Heo       2015-09-16  724  
1ed1328792ff46 Tejun Heo       2015-09-16  725  /**
1ed1328792ff46 Tejun Heo       2015-09-16  726   * cgroup_threadgroup_change_end - threadgroup exclusion for cgroups
1ed1328792ff46 Tejun Heo       2015-09-16  727   * @tsk: target task
1ed1328792ff46 Tejun Heo       2015-09-16  728   *
780de9dd2720de Ingo Molnar     2017-02-02  729   * Counterpart of cgroup_threadcgroup_change_begin().
1ed1328792ff46 Tejun Heo       2015-09-16  730   */
1ed1328792ff46 Tejun Heo       2015-09-16  731  static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
1ed1328792ff46 Tejun Heo       2015-09-16  732  {
1ed1328792ff46 Tejun Heo       2015-09-16  733  	percpu_up_read(&cgroup_threadgroup_rwsem);
1ed1328792ff46 Tejun Heo       2015-09-16  734  }
7d7efec368d537 Tejun Heo       2015-05-13  735  
7d7efec368d537 Tejun Heo       2015-05-13  736  #else	/* CONFIG_CGROUPS */
7d7efec368d537 Tejun Heo       2015-05-13  737  
cb4a316752709b Aleksa Sarai    2015-06-06  738  #define CGROUP_SUBSYS_COUNT 0
cb4a316752709b Aleksa Sarai    2015-06-06  739  
780de9dd2720de Ingo Molnar     2017-02-02  740  static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
780de9dd2720de Ingo Molnar     2017-02-02  741  {
780de9dd2720de Ingo Molnar     2017-02-02  742  	might_sleep();
780de9dd2720de Ingo Molnar     2017-02-02  743  }
780de9dd2720de Ingo Molnar     2017-02-02  744  
7d7efec368d537 Tejun Heo       2015-05-13  745  static inline void cgroup_threadgroup_change_end(struct task_struct *tsk) {}
7d7efec368d537 Tejun Heo       2015-05-13  746  
b4a04ab7a37b49 Tejun Heo       2015-05-13  747  #endif	/* CONFIG_CGROUPS */
7d7efec368d537 Tejun Heo       2015-05-13  748  
2a56a1fec290bf Tejun Heo       2015-12-07  749  #ifdef CONFIG_SOCK_CGROUP_DATA
2a56a1fec290bf Tejun Heo       2015-12-07  750  
bd1060a1d67128 Tejun Heo       2015-12-07  751  /*
bd1060a1d67128 Tejun Heo       2015-12-07  752   * sock_cgroup_data is embedded at sock->sk_cgrp_data and contains
bd1060a1d67128 Tejun Heo       2015-12-07  753   * per-socket cgroup information except for memcg association.
bd1060a1d67128 Tejun Heo       2015-12-07  754   *
f36377d0c40cce Daniel Borkmann 2021-07-06  755   * On legacy hierarchies, net_prio and net_cls controllers directly
f36377d0c40cce Daniel Borkmann 2021-07-06  756   * set attributes on each sock which can then be tested by the network
f36377d0c40cce Daniel Borkmann 2021-07-06  757   * layer. On the default hierarchy, each sock is associated with the
f36377d0c40cce Daniel Borkmann 2021-07-06  758   * cgroup it was created in and the networking layer can match the
f36377d0c40cce Daniel Borkmann 2021-07-06  759   * cgroup directly.
bd1060a1d67128 Tejun Heo       2015-12-07  760   */
2a56a1fec290bf Tejun Heo       2015-12-07  761  struct sock_cgroup_data {
f36377d0c40cce Daniel Borkmann 2021-07-06  762  	struct cgroup	*cgroup; /* v2 */
f36377d0c40cce Daniel Borkmann 2021-07-06  763  #if defined(CONFIG_CGROUP_NET_CLASSID)
f36377d0c40cce Daniel Borkmann 2021-07-06  764  	u32		classid; /* v1 */
f36377d0c40cce Daniel Borkmann 2021-07-06  765  #endif
f36377d0c40cce Daniel Borkmann 2021-07-06  766  #if defined(CONFIG_CGROUP_NET_PRIO)
f36377d0c40cce Daniel Borkmann 2021-07-06  767  	u16		prioidx; /* v1 */
bd1060a1d67128 Tejun Heo       2015-12-07  768  #endif
2a56a1fec290bf Tejun Heo       2015-12-07  769  };
2a56a1fec290bf Tejun Heo       2015-12-07  770  
4dcb31d4649df3 Eric Dumazet    2018-03-14 @771  static inline u16 sock_cgroup_prioidx(const struct sock_cgroup_data *skcd)
2a56a1fec290bf Tejun Heo       2015-12-07  772  {
f36377d0c40cce Daniel Borkmann 2021-07-06  773  #if defined(CONFIG_CGROUP_NET_PRIO)
f36377d0c40cce Daniel Borkmann 2021-07-06  774  	return READ_ONCE(skcd->prioidx);
f36377d0c40cce Daniel Borkmann 2021-07-06  775  #else
f36377d0c40cce Daniel Borkmann 2021-07-06  776  	return 1;
f36377d0c40cce Daniel Borkmann 2021-07-06  777  #endif
2a56a1fec290bf Tejun Heo       2015-12-07  778  }
2a56a1fec290bf Tejun Heo       2015-12-07  779  
4dcb31d4649df3 Eric Dumazet    2018-03-14  780  static inline u32 sock_cgroup_classid(const struct sock_cgroup_data *skcd)
2a56a1fec290bf Tejun Heo       2015-12-07  781  {
f36377d0c40cce Daniel Borkmann 2021-07-06  782  #if defined(CONFIG_CGROUP_NET_CLASSID)
f36377d0c40cce Daniel Borkmann 2021-07-06  783  	return READ_ONCE(skcd->classid);
f36377d0c40cce Daniel Borkmann 2021-07-06  784  #else
f36377d0c40cce Daniel Borkmann 2021-07-06  785  	return 0;
f36377d0c40cce Daniel Borkmann 2021-07-06  786  #endif
2a56a1fec290bf Tejun Heo       2015-12-07  787  }
2a56a1fec290bf Tejun Heo       2015-12-07  788  
2a56a1fec290bf Tejun Heo       2015-12-07 @789  static inline void sock_cgroup_set_prioidx(struct sock_cgroup_data *skcd,
2a56a1fec290bf Tejun Heo       2015-12-07 @790  					   u16 prioidx)
2a56a1fec290bf Tejun Heo       2015-12-07  791  {
f36377d0c40cce Daniel Borkmann 2021-07-06  792  #if defined(CONFIG_CGROUP_NET_PRIO)
f36377d0c40cce Daniel Borkmann 2021-07-06  793  	WRITE_ONCE(skcd->prioidx, prioidx);
f36377d0c40cce Daniel Borkmann 2021-07-06  794  #endif
2a56a1fec290bf Tejun Heo       2015-12-07  795  }
2a56a1fec290bf Tejun Heo       2015-12-07  796  
2a56a1fec290bf Tejun Heo       2015-12-07  797  static inline void sock_cgroup_set_classid(struct sock_cgroup_data *skcd,
2a56a1fec290bf Tejun Heo       2015-12-07 @798  					   u32 classid)
2a56a1fec290bf Tejun Heo       2015-12-07  799  {
f36377d0c40cce Daniel Borkmann 2021-07-06  800  #if defined(CONFIG_CGROUP_NET_CLASSID)
f36377d0c40cce Daniel Borkmann 2021-07-06  801  	WRITE_ONCE(skcd->classid, classid);
f36377d0c40cce Daniel Borkmann 2021-07-06  802  #endif
2a56a1fec290bf Tejun Heo       2015-12-07  803  }
2a56a1fec290bf Tejun Heo       2015-12-07  804  

:::::: The code at line 771 was first introduced by commit
:::::: 4dcb31d4649df36297296b819437709f5407059c net: use skb_to_full_sk() in skb_update_prio()

:::::: TO: Eric Dumazet <edumazet@google.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38393 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd'
  2021-09-11  0:38 [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' kernel test robot
@ 2021-09-13 15:19 ` Daniel Borkmann
  2021-09-13 18:00   ` Nathan Chancellor
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2021-09-13 15:19 UTC (permalink / raw)
  To: kernel test robot
  Cc: llvm, kbuild-all, linux-kernel, philip.li, alexei.starovoitov, andrii

[ +Philip ]

On 9/11/21 2:38 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-cgrp
> head:   5a6e78baee7515884b93a90c5d03db601bc9063a
> commit: f36377d0c40cce0cdeaff50031c268bc640d94f0 [2/4] bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode
> config: i386-randconfig-r032-20210910 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f36377d0c40cce0cdeaff50031c268bc640d94f0
>          git remote add dborkman https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git
>          git fetch --no-tags dborkman pr/bpf-cgrp
>          git checkout f36377d0c40cce0cdeaff50031c268bc640d94f0
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):

Not sure how useful these warnings below are given it is quite conventional in the kernel
to have some static inline helper which e.g. look:

static inline int bla(struct foo *bar)
{
#ifdef CONFIG_<XYZ>
         return ... /// do something with bar
#else
         return 0;
#endif
}

I presume consensus here is to ignore these given also the gazillion other cases in the
kernel tree. In other words, goal on -Wunused-parameter for kernel would be to really
only catch cases where a parameter is indeed in all cases unused and should be removed
from the signature.

Thanks,
Daniel

>     In file included from include/linux/cgroup.h:28:
>     In file included from include/linux/cgroup-defs.h:22:
>     In file included from include/linux/bpf-cgroup.h:5:
>     include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter]
>     static inline int bpf_trampoline_link_prog(struct bpf_prog *prog,
>                                                                 ^
>     include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter]
>                                                struct bpf_trampoline *tr)
>                                                                       ^
>     include/linux/bpf.h:775:63: warning: unused parameter 'prog' [-Wunused-parameter]
>     static inline int bpf_trampoline_unlink_prog(struct bpf_prog *prog,
>                                                                   ^
>     include/linux/bpf.h:776:34: warning: unused parameter 'tr' [-Wunused-parameter]
>                                                  struct bpf_trampoline *tr)
>                                                                         ^
>     include/linux/bpf.h:780:61: warning: unused parameter 'key' [-Wunused-parameter]
>     static inline struct bpf_trampoline *bpf_trampoline_get(u64 key,
>                                                                 ^
>     include/linux/bpf.h:781:39: warning: unused parameter 'tgt_info' [-Wunused-parameter]
>                                                             struct bpf_attach_target_info *tgt_info)
>                                                                                            ^
>     include/linux/bpf.h:785:62: warning: unused parameter 'tr' [-Wunused-parameter]
>     static inline void bpf_trampoline_put(struct bpf_trampoline *tr) {}
>                                                                  ^
>     include/linux/bpf.h:790:70: warning: unused parameter 'd' [-Wunused-parameter]
>     static inline void bpf_dispatcher_change_prog(struct bpf_dispatcher *d,
>                                                                          ^
>     include/linux/bpf.h:791:29: warning: unused parameter 'from' [-Wunused-parameter]
>                                                   struct bpf_prog *from,
>                                                                    ^
>     include/linux/bpf.h:792:29: warning: unused parameter 'to' [-Wunused-parameter]
>                                                   struct bpf_prog *to) {}
>                                                                    ^
>     include/linux/bpf.h:793:55: warning: unused parameter 'address' [-Wunused-parameter]
>     static inline bool is_bpf_image_address(unsigned long address)
>                                                           ^
>     include/linux/bpf.h:1012:68: warning: unused parameter 'type_id' [-Wunused-parameter]
>     static inline const struct bpf_struct_ops *bpf_struct_ops_find(u32 type_id)
>                                                                        ^
>     include/linux/bpf.h:1016:52: warning: unused parameter 'btf' [-Wunused-parameter]
>     static inline void bpf_struct_ops_init(struct btf *btf,
>                                                        ^
>     include/linux/bpf.h:1017:37: warning: unused parameter 'log' [-Wunused-parameter]
>                                            struct bpf_verifier_log *log)
>                                                                     ^
>     include/linux/bpf.h:1020:51: warning: unused parameter 'data' [-Wunused-parameter]
>     static inline bool bpf_try_module_get(const void *data, struct module *owner)
>                                                       ^
>     include/linux/bpf.h:1024:47: warning: unused parameter 'data' [-Wunused-parameter]
>     static inline void bpf_module_put(const void *data, struct module *owner)
>                                                   ^
>     include/linux/bpf.h:1028:70: warning: unused parameter 'map' [-Wunused-parameter]
>     static inline int bpf_struct_ops_map_sys_lookup_elem(struct bpf_map *map,
>                                                                          ^
>     include/linux/bpf.h:1029:18: warning: unused parameter 'key' [-Wunused-parameter]
>                                                          void *key,
>                                                                ^
>     include/linux/bpf.h:1030:18: warning: unused parameter 'value' [-Wunused-parameter]
>                                                          void *value)
>                                                                ^
>     include/linux/bpf.h:1407:44: warning: unused parameter 'map' [-Wunused-parameter]
>     bpf_map_kmalloc_node(const struct bpf_map *map, size_t size, gfp_t flags,
>                                                ^
>     include/linux/bpf.h:1414:39: warning: unused parameter 'map' [-Wunused-parameter]
>     bpf_map_kzalloc(const struct bpf_map *map, size_t size, gfp_t flags)
>                                           ^
>     include/linux/bpf.h:1420:44: warning: unused parameter 'map' [-Wunused-parameter]
>     bpf_map_alloc_percpu(const struct bpf_map *map, size_t size, size_t align,
>                                                ^
>     In file included from drivers/gpu/drm/i915/i915_drv.c:39:
>     In file included from include/linux/vga_switcheroo.h:34:
>     In file included from include/linux/fb.h:6:
>     In file included from include/uapi/linux/fb.h:6:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:13:
>     In file included from include/linux/cgroup.h:28:
>     In file included from include/linux/cgroup-defs.h:23:
>     In file included from include/linux/psi_types.h:4:
>     include/linux/kthread.h:218:72: warning: unused parameter 'css' [-Wunused-parameter]
>     static inline void kthread_associate_blkcg(struct cgroup_subsys_state *css) { }
>                                                                            ^
>     In file included from drivers/gpu/drm/i915/i915_drv.c:39:
>     In file included from include/linux/vga_switcheroo.h:34:
>     In file included from include/linux/fb.h:6:
>     In file included from include/uapi/linux/fb.h:6:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:13:
>     In file included from include/linux/cgroup.h:28:
>     include/linux/cgroup-defs.h:720:72: warning: unused parameter 'tsk' [-Wunused-parameter]
>     static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
>                                                                            ^
>     include/linux/cgroup-defs.h:731:70: warning: unused parameter 'tsk' [-Wunused-parameter]
>     static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
>                                                                          ^
>>> include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline u16 sock_cgroup_prioidx(const struct sock_cgroup_data *skcd)
>                                                                          ^
>     include/linux/cgroup-defs.h:780:70: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline u32 sock_cgroup_classid(const struct sock_cgroup_data *skcd)
>                                                                          ^
>     include/linux/cgroup-defs.h:789:69: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline void sock_cgroup_set_prioidx(struct sock_cgroup_data *skcd,
>                                                                         ^
>>> include/linux/cgroup-defs.h:790:13: warning: unused parameter 'prioidx' [-Wunused-parameter]
>                                                u16 prioidx)
>                                                    ^
>     include/linux/cgroup-defs.h:797:69: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline void sock_cgroup_set_classid(struct sock_cgroup_data *skcd,
>                                                                         ^
>>> include/linux/cgroup-defs.h:798:13: warning: unused parameter 'classid' [-Wunused-parameter]
>                                                u32 classid)
>                                                    ^
>     In file included from drivers/gpu/drm/i915/i915_drv.c:39:
>     In file included from include/linux/vga_switcheroo.h:34:
>     In file included from include/linux/fb.h:6:
>     In file included from include/uapi/linux/fb.h:6:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
>     In file included from include/linux/writeback.h:12:
>     include/linux/backing-dev-defs.h:282:52: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline bool wb_tryget(struct bdi_writeback *wb)
>                                                        ^
>     include/linux/backing-dev-defs.h:287:49: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline void wb_get(struct bdi_writeback *wb)
>                                                     ^
>     include/linux/backing-dev-defs.h:291:49: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline void wb_put(struct bdi_writeback *wb)
>                                                     ^
>     include/linux/backing-dev-defs.h:295:54: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
>                                                          ^
>     include/linux/backing-dev-defs.h:295:72: warning: unused parameter 'nr' [-Wunused-parameter]
>     static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
>                                                                            ^
>     include/linux/backing-dev-defs.h:299:51: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline bool wb_dying(struct bdi_writeback *wb)
>                                                       ^
>     In file included from drivers/gpu/drm/i915/i915_drv.c:39:
>     In file included from include/linux/vga_switcheroo.h:34:
>     In file included from include/linux/fb.h:6:
>     In file included from include/uapi/linux/fb.h:6:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
>     In file included from include/linux/writeback.h:13:
>     In file included from include/linux/blk_types.h:10:
>     In file included from include/linux/bvec.h:10:
>     In file included from include/linux/highmem.h:12:
>     In file included from arch/x86/include/asm/cacheflush.h:8:
>     include/asm-generic/cacheflush.h:21:53: warning: unused parameter 'mm' [-Wunused-parameter]
>     static inline void flush_cache_mm(struct mm_struct *mm)
>                                                         ^
>     include/asm-generic/cacheflush.h:27:57: warning: unused parameter 'mm' [-Wunused-parameter]
>     static inline void flush_cache_dup_mm(struct mm_struct *mm)
>                                                             ^
>     include/asm-generic/cacheflush.h:33:61: warning: unused parameter 'vma' [-Wunused-parameter]
>     static inline void flush_cache_range(struct vm_area_struct *vma,
>                                                                 ^
>     include/asm-generic/cacheflush.h:34:24: warning: unused parameter 'start' [-Wunused-parameter]
>                                          unsigned long start,
>                                                        ^
>     include/asm-generic/cacheflush.h:35:24: warning: unused parameter 'end' [-Wunused-parameter]
>                                          unsigned long end)
>                                                        ^
>     include/asm-generic/cacheflush.h:41:60: warning: unused parameter 'vma' [-Wunused-parameter]
>     static inline void flush_cache_page(struct vm_area_struct *vma,
>                                                                ^
>     include/asm-generic/cacheflush.h:42:23: warning: unused parameter 'vmaddr' [-Wunused-parameter]
>                                         unsigned long vmaddr,
>                                                       ^
>     include/asm-generic/cacheflush.h:43:23: warning: unused parameter 'pfn' [-Wunused-parameter]
>                                         unsigned long pfn)
>                                                       ^
>     include/asm-generic/cacheflush.h:49:51: warning: unused parameter 'page' [-Wunused-parameter]
>     static inline void flush_dcache_page(struct page *page)
>                                                       ^
>     include/asm-generic/cacheflush.h:57:65: warning: unused parameter 'mapping' [-Wunused-parameter]
>     static inline void flush_dcache_mmap_lock(struct address_space *mapping)
>                                                                     ^
>     include/asm-generic/cacheflush.h:63:67: warning: unused parameter 'mapping' [-Wunused-parameter]
>     static inline void flush_dcache_mmap_unlock(struct address_space *mapping)
>                                                                       ^
>     include/asm-generic/cacheflush.h:69:53: warning: unused parameter 'start' [-Wunused-parameter]
>     static inline void flush_icache_range(unsigned long start, unsigned long end)
>                                                         ^
>     include/asm-generic/cacheflush.h:69:74: warning: unused parameter 'end' [-Wunused-parameter]
>     static inline void flush_icache_range(unsigned long start, unsigned long end)
>                                                                              ^
>     include/asm-generic/cacheflush.h:79:61: warning: unused parameter 'vma' [-Wunused-parameter]
>     static inline void flush_icache_page(struct vm_area_struct *vma,
>                                                                 ^
>     include/asm-generic/cacheflush.h:80:23: warning: unused parameter 'page' [-Wunused-parameter]
>                                          struct page *page)
>                                                       ^
>     include/asm-generic/cacheflush.h:86:66: warning: unused parameter 'vma' [-Wunused-parameter]
>     static inline void flush_icache_user_page(struct vm_area_struct *vma,
>                                                                      ^
>     include/asm-generic/cacheflush.h:87:22: warning: unused parameter 'page' [-Wunused-parameter]
>                                                struct page *page,
>                                                             ^
>     include/asm-generic/cacheflush.h:88:23: warning: unused parameter 'addr' [-Wunused-parameter]
>                                                unsigned long addr, int len)
>                                                              ^
>     include/asm-generic/cacheflush.h:88:33: warning: unused parameter 'len' [-Wunused-parameter]
>                                                unsigned long addr, int len)
> --
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:13:
>     In file included from include/linux/cgroup.h:28:
>     In file included from include/linux/cgroup-defs.h:22:
>     In file included from include/linux/bpf-cgroup.h:5:
>     include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter]
>     static inline int bpf_trampoline_link_prog(struct bpf_prog *prog,
>                                                                 ^
>     include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter]
>                                                struct bpf_trampoline *tr)
>                                                                       ^
>     include/linux/bpf.h:775:63: warning: unused parameter 'prog' [-Wunused-parameter]
>     static inline int bpf_trampoline_unlink_prog(struct bpf_prog *prog,
>                                                                   ^
>     include/linux/bpf.h:776:34: warning: unused parameter 'tr' [-Wunused-parameter]
>                                                  struct bpf_trampoline *tr)
>                                                                         ^
>     include/linux/bpf.h:780:61: warning: unused parameter 'key' [-Wunused-parameter]
>     static inline struct bpf_trampoline *bpf_trampoline_get(u64 key,
>                                                                 ^
>     include/linux/bpf.h:781:39: warning: unused parameter 'tgt_info' [-Wunused-parameter]
>                                                             struct bpf_attach_target_info *tgt_info)
>                                                                                            ^
>     include/linux/bpf.h:785:62: warning: unused parameter 'tr' [-Wunused-parameter]
>     static inline void bpf_trampoline_put(struct bpf_trampoline *tr) {}
>                                                                  ^
>     include/linux/bpf.h:790:70: warning: unused parameter 'd' [-Wunused-parameter]
>     static inline void bpf_dispatcher_change_prog(struct bpf_dispatcher *d,
>                                                                          ^
>     include/linux/bpf.h:791:29: warning: unused parameter 'from' [-Wunused-parameter]
>                                                   struct bpf_prog *from,
>                                                                    ^
>     include/linux/bpf.h:792:29: warning: unused parameter 'to' [-Wunused-parameter]
>                                                   struct bpf_prog *to) {}
>                                                                    ^
>     include/linux/bpf.h:793:55: warning: unused parameter 'address' [-Wunused-parameter]
>     static inline bool is_bpf_image_address(unsigned long address)
>                                                           ^
>     include/linux/bpf.h:1012:68: warning: unused parameter 'type_id' [-Wunused-parameter]
>     static inline const struct bpf_struct_ops *bpf_struct_ops_find(u32 type_id)
>                                                                        ^
>     include/linux/bpf.h:1016:52: warning: unused parameter 'btf' [-Wunused-parameter]
>     static inline void bpf_struct_ops_init(struct btf *btf,
>                                                        ^
>     include/linux/bpf.h:1017:37: warning: unused parameter 'log' [-Wunused-parameter]
>                                            struct bpf_verifier_log *log)
>                                                                     ^
>     include/linux/bpf.h:1020:51: warning: unused parameter 'data' [-Wunused-parameter]
>     static inline bool bpf_try_module_get(const void *data, struct module *owner)
>                                                       ^
>     include/linux/bpf.h:1024:47: warning: unused parameter 'data' [-Wunused-parameter]
>     static inline void bpf_module_put(const void *data, struct module *owner)
>                                                   ^
>     include/linux/bpf.h:1028:70: warning: unused parameter 'map' [-Wunused-parameter]
>     static inline int bpf_struct_ops_map_sys_lookup_elem(struct bpf_map *map,
>                                                                          ^
>     include/linux/bpf.h:1029:18: warning: unused parameter 'key' [-Wunused-parameter]
>                                                          void *key,
>                                                                ^
>     include/linux/bpf.h:1030:18: warning: unused parameter 'value' [-Wunused-parameter]
>                                                          void *value)
>                                                                ^
>     include/linux/bpf.h:1407:44: warning: unused parameter 'map' [-Wunused-parameter]
>     bpf_map_kmalloc_node(const struct bpf_map *map, size_t size, gfp_t flags,
>                                                ^
>     include/linux/bpf.h:1414:39: warning: unused parameter 'map' [-Wunused-parameter]
>     bpf_map_kzalloc(const struct bpf_map *map, size_t size, gfp_t flags)
>                                           ^
>     include/linux/bpf.h:1420:44: warning: unused parameter 'map' [-Wunused-parameter]
>     bpf_map_alloc_percpu(const struct bpf_map *map, size_t size, size_t align,
>                                                ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:13:
>     In file included from include/linux/cgroup.h:28:
>     In file included from include/linux/cgroup-defs.h:23:
>     In file included from include/linux/psi_types.h:4:
>     include/linux/kthread.h:218:72: warning: unused parameter 'css' [-Wunused-parameter]
>     static inline void kthread_associate_blkcg(struct cgroup_subsys_state *css) { }
>                                                                            ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:13:
>     In file included from include/linux/cgroup.h:28:
>     include/linux/cgroup-defs.h:720:72: warning: unused parameter 'tsk' [-Wunused-parameter]
>     static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
>                                                                            ^
>     include/linux/cgroup-defs.h:731:70: warning: unused parameter 'tsk' [-Wunused-parameter]
>     static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
>                                                                          ^
>>> include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline u16 sock_cgroup_prioidx(const struct sock_cgroup_data *skcd)
>                                                                          ^
>     include/linux/cgroup-defs.h:780:70: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline u32 sock_cgroup_classid(const struct sock_cgroup_data *skcd)
>                                                                          ^
>     include/linux/cgroup-defs.h:789:69: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline void sock_cgroup_set_prioidx(struct sock_cgroup_data *skcd,
>                                                                         ^
>>> include/linux/cgroup-defs.h:790:13: warning: unused parameter 'prioidx' [-Wunused-parameter]
>                                                u16 prioidx)
>                                                    ^
>     include/linux/cgroup-defs.h:797:69: warning: unused parameter 'skcd' [-Wunused-parameter]
>     static inline void sock_cgroup_set_classid(struct sock_cgroup_data *skcd,
>                                                                         ^
>>> include/linux/cgroup-defs.h:798:13: warning: unused parameter 'classid' [-Wunused-parameter]
>                                                u32 classid)
>                                                    ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
>     In file included from include/linux/writeback.h:12:
>     include/linux/backing-dev-defs.h:282:52: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline bool wb_tryget(struct bdi_writeback *wb)
>                                                        ^
>     include/linux/backing-dev-defs.h:287:49: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline void wb_get(struct bdi_writeback *wb)
>                                                     ^
>     include/linux/backing-dev-defs.h:291:49: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline void wb_put(struct bdi_writeback *wb)
>                                                     ^
>     include/linux/backing-dev-defs.h:295:54: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
>                                                          ^
>     include/linux/backing-dev-defs.h:295:72: warning: unused parameter 'nr' [-Wunused-parameter]
>     static inline void wb_put_many(struct bdi_writeback *wb, unsigned long nr)
>                                                                            ^
>     include/linux/backing-dev-defs.h:299:51: warning: unused parameter 'wb' [-Wunused-parameter]
>     static inline bool wb_dying(struct bdi_writeback *wb)
>                                                       ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
>     In file included from include/linux/writeback.h:14:
>     In file included from include/linux/blk-cgroup.h:23:
>     In file included from include/linux/blkdev.h:8:
>     include/linux/genhd.h:302:60: warning: unused parameter 'bdev' [-Wunused-parameter]
>     static inline int bd_link_disk_holder(struct block_device *bdev,
>                                                                ^
>     include/linux/genhd.h:303:27: warning: unused parameter 'disk' [-Wunused-parameter]
>                                           struct gendisk *disk)
>                                                           ^
>     include/linux/genhd.h:307:63: warning: unused parameter 'bdev' [-Wunused-parameter]
>     static inline void bd_unlink_disk_holder(struct block_device *bdev,
>                                                                   ^
>     include/linux/genhd.h:308:23: warning: unused parameter 'disk' [-Wunused-parameter]
>                                              struct gendisk *disk)
>                                                              ^
>     include/linux/genhd.h:311:63: warning: unused parameter 'disk' [-Wunused-parameter]
>     static inline int bd_register_pending_holders(struct gendisk *disk)
>                                                                   ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
>     In file included from include/linux/writeback.h:14:
>     In file included from include/linux/blk-cgroup.h:23:
>     In file included from include/linux/blkdev.h:17:
>     include/linux/bio.h:394:14: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
>             if (sectors >= bio_sectors(bio))
>                 ~~~~~~~ ^  ~~~~~~~~~~~~~~~~
>     include/linux/bio.h:516:51: warning: unused parameter 'bio' [-Wunused-parameter]
>     static inline void bio_associate_blkg(struct bio *bio) { }
>                                                       ^
>     include/linux/bio.h:517:60: warning: unused parameter 'bio' [-Wunused-parameter]
>     static inline void bio_associate_blkg_from_css(struct bio *bio,
>                                                                ^
>     include/linux/bio.h:518:41: warning: unused parameter 'css' [-Wunused-parameter]
>                                                    struct cgroup_subsys_state *css)
>                                                                                ^
>     include/linux/bio.h:520:59: warning: unused parameter 'dst' [-Wunused-parameter]
>     static inline void bio_clone_blkg_association(struct bio *dst,
>                                                               ^
>     include/linux/bio.h:521:24: warning: unused parameter 'src' [-Wunused-parameter]
>                                                   struct bio *src) { }
>                                                               ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
>     In file included from include/linux/writeback.h:14:
>     In file included from include/linux/blk-cgroup.h:23:
>     include/linux/blkdev.h:866:58: warning: unused parameter 'rq' [-Wunused-parameter]
>     static inline void rq_flush_dcache_pages(struct request *rq)
>                                                              ^
>     In file included from drivers/gpu/drm/i915/i915_config.c:6:
>     In file included from drivers/gpu/drm/i915/i915_drv.h:39:
>     In file included from include/linux/i2c.h:18:
>     In file included from include/linux/regulator/consumer.h:35:
>     In file included from include/linux/suspend.h:5:
>     In file included from include/linux/swap.h:9:
>     In file included from include/linux/memcontrol.h:22:
> ..

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd'
  2021-09-13 15:19 ` Daniel Borkmann
@ 2021-09-13 18:00   ` Nathan Chancellor
  2021-09-14  4:05     ` [kbuild-all] " Rong Chen
  0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2021-09-13 18:00 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: kernel test robot, llvm, kbuild-all, linux-kernel, philip.li,
	alexei.starovoitov, andrii

Hi Daniel,

On Mon, Sep 13, 2021 at 05:19:26PM +0200, Daniel Borkmann wrote:
> [ +Philip ]
> 
> On 9/11/21 2:38 AM, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-cgrp
> > head:   5a6e78baee7515884b93a90c5d03db601bc9063a
> > commit: f36377d0c40cce0cdeaff50031c268bc640d94f0 [2/4] bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode
> > config: i386-randconfig-r032-20210910 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > reproduce (this is a W=1 build):
> >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >          chmod +x ~/bin/make.cross
> >          # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f36377d0c40cce0cdeaff50031c268bc640d94f0
> >          git remote add dborkman https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git
> >          git fetch --no-tags dborkman pr/bpf-cgrp
> >          git checkout f36377d0c40cce0cdeaff50031c268bc640d94f0
> >          # save the attached .config to linux build tree
> >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> 
> Not sure how useful these warnings below are given it is quite conventional in the kernel
> to have some static inline helper which e.g. look:
> 
> static inline int bla(struct foo *bar)
> {
> #ifdef CONFIG_<XYZ>
>         return ... /// do something with bar
> #else
>         return 0;
> #endif
> }
> 
> I presume consensus here is to ignore these given also the gazillion other cases in the
> kernel tree. In other words, goal on -Wunused-parameter for kernel would be to really
> only catch cases where a parameter is indeed in all cases unused and should be removed
> from the signature.

Unfortunately, it looks like you are getting bit by a tangential issue
here:

https://lore.kernel.org/r/YSQE2f5teuvKLkON@Ryzen-9-3900X.localdomain/

The full include log:

In file included from drivers/gpu/drm/i915/display/intel_dpll.c:7:
In file included from drivers/gpu/drm/i915/display/intel_de.h:9:
In file included from ./drivers/gpu/drm/i915/i915_drv.h:39:
In file included from ./include/linux/i2c.h:18:
In file included from ./include/linux/regulator/consumer.h:35:
In file included from ./include/linux/suspend.h:5:
In file included from ./include/linux/swap.h:9:
In file included from ./include/linux/memcontrol.h:13:
In file included from ./include/linux/cgroup.h:28:
In file included from ./include/linux/cgroup-defs.h:22:
In file included from ./include/linux/bpf-cgroup.h:5:
./include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter]
static inline int bpf_trampoline_link_prog(struct bpf_prog *prog,
                                                            ^
./include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter]
                                           struct bpf_trampoline *tr)
                                                                  ^
...

The fixes are here:

https://lore.kernel.org/r/20210824022640.2170859-1-nathan@kernel.org/
https://lore.kernel.org/r/20210824232237.2085342-1-nathan@kernel.org/

I will push to get these fixes accepted as quickly as possible.

Philip, would it be possible for you guys to avoid sending reports for
i386 configurations that contain any of the following three
configurations for the time being?

CONFIG_MCRUSOE=y
CONFIG_MEFFICEON=y
CONFIG_MCYRIXIII=y

They are resulting in a lot of false positives, as I have linked above.

Cheers,
Nathan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kbuild-all] Re: [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd'
  2021-09-13 18:00   ` Nathan Chancellor
@ 2021-09-14  4:05     ` Rong Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Rong Chen @ 2021-09-14  4:05 UTC (permalink / raw)
  To: Nathan Chancellor, Daniel Borkmann
  Cc: kernel test robot, llvm, kbuild-all, linux-kernel,
	alexei.starovoitov, andrii



On 9/14/21 2:00 AM, Nathan Chancellor wrote:
> Hi Daniel,
>
> On Mon, Sep 13, 2021 at 05:19:26PM +0200, Daniel Borkmann wrote:
>> [ +Philip ]
>>
>> On 9/11/21 2:38 AM, kernel test robot wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-cgrp
>>> head:   5a6e78baee7515884b93a90c5d03db601bc9063a
>>> commit: f36377d0c40cce0cdeaff50031c268bc640d94f0 [2/4] bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode
>>> config: i386-randconfig-r032-20210910 (attached as .config)
>>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
>>> reproduce (this is a W=1 build):
>>>           wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>           chmod +x ~/bin/make.cross
>>>           # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f36377d0c40cce0cdeaff50031c268bc640d94f0
>>>           git remote add dborkman https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git
>>>           git fetch --no-tags dborkman pr/bpf-cgrp
>>>           git checkout f36377d0c40cce0cdeaff50031c268bc640d94f0
>>>           # save the attached .config to linux build tree
>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All warnings (new ones prefixed by >>):
>> Not sure how useful these warnings below are given it is quite conventional in the kernel
>> to have some static inline helper which e.g. look:
>>
>> static inline int bla(struct foo *bar)
>> {
>> #ifdef CONFIG_<XYZ>
>>          return ... /// do something with bar
>> #else
>>          return 0;
>> #endif
>> }
>>
>> I presume consensus here is to ignore these given also the gazillion other cases in the
>> kernel tree. In other words, goal on -Wunused-parameter for kernel would be to really
>> only catch cases where a parameter is indeed in all cases unused and should be removed
>> from the signature.
> Unfortunately, it looks like you are getting bit by a tangential issue
> here:
>
> https://lore.kernel.org/r/YSQE2f5teuvKLkON@Ryzen-9-3900X.localdomain/
>
> The full include log:
>
> In file included from drivers/gpu/drm/i915/display/intel_dpll.c:7:
> In file included from drivers/gpu/drm/i915/display/intel_de.h:9:
> In file included from ./drivers/gpu/drm/i915/i915_drv.h:39:
> In file included from ./include/linux/i2c.h:18:
> In file included from ./include/linux/regulator/consumer.h:35:
> In file included from ./include/linux/suspend.h:5:
> In file included from ./include/linux/swap.h:9:
> In file included from ./include/linux/memcontrol.h:13:
> In file included from ./include/linux/cgroup.h:28:
> In file included from ./include/linux/cgroup-defs.h:22:
> In file included from ./include/linux/bpf-cgroup.h:5:
> ./include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter]
> static inline int bpf_trampoline_link_prog(struct bpf_prog *prog,
>                                                              ^
> ./include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter]
>                                             struct bpf_trampoline *tr)
>                                                                    ^
> ...
>
> The fixes are here:
>
> https://lore.kernel.org/r/20210824022640.2170859-1-nathan@kernel.org/
> https://lore.kernel.org/r/20210824232237.2085342-1-nathan@kernel.org/
>
> I will push to get these fixes accepted as quickly as possible.
>
> Philip, would it be possible for you guys to avoid sending reports for
> i386 configurations that contain any of the following three
> configurations for the time being?
>
> CONFIG_MCRUSOE=y
> CONFIG_MEFFICEON=y
> CONFIG_MCYRIXIII=y
>
> They are resulting in a lot of false positives, as I have linked above.

Hi Nathan,

Thanks for the advice, we have disabled these config.

Best Regards,
Rong Chen

>
> Cheers,
> Nathan
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-14  4:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11  0:38 [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' kernel test robot
2021-09-13 15:19 ` Daniel Borkmann
2021-09-13 18:00   ` Nathan Chancellor
2021-09-14  4:05     ` [kbuild-all] " Rong Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).