From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF51BC4332F for ; Sat, 11 Sep 2021 14:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4DBD61247 for ; Sat, 11 Sep 2021 14:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236239AbhIKORV (ORCPT ); Sat, 11 Sep 2021 10:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236102AbhIKORR (ORCPT ); Sat, 11 Sep 2021 10:17:17 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE34C061574 for ; Sat, 11 Sep 2021 07:16:04 -0700 (PDT) Received: from dslb-084-059-243-091.084.059.pools.vodafone-ip.de ([84.59.243.91] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mP3nU-0006bt-Pc; Sat, 11 Sep 2021 16:16:00 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 03/12] staging: r8188eu: remove write-only variable cpwm Date: Sat, 11 Sep 2021 16:15:12 +0200 Message-Id: <20210911141521.24901-4-martin@kaiser.cx> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210911141521.24901-1-martin@kaiser.cx> References: <20210911141521.24901-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpwm in struct pwrctrl_priv is never read. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_pwrctrl.c | 5 ----- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_pwrctrl.c b/drivers/staging/r8188eu/core/rtw_pwrctrl.c index daae91f82e97..2a0ee3aac700 100644 --- a/drivers/staging/r8188eu/core/rtw_pwrctrl.c +++ b/drivers/staging/r8188eu/core/rtw_pwrctrl.c @@ -204,8 +204,6 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv) if ((padapter->bSurpriseRemoved) || (!padapter->hw_init_completed)) { - pwrpriv->cpwm = PS_STATE_S4; - return; } @@ -217,8 +215,6 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv) pwrpriv->rpwm = pslv; pwrpriv->tog += 0x80; - pwrpriv->cpwm = pslv; - } static u8 PS_RDY_CHECK(struct adapter *padapter) @@ -423,7 +419,6 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter) pwrctrlpriv->bFwCurrentInPSMode = false; pwrctrlpriv->rpwm = 0; - pwrctrlpriv->cpwm = PS_STATE_S4; pwrctrlpriv->pwr_mode = PS_MODE_ACTIVE; pwrctrlpriv->smart_ps = padapter->registrypriv.smart_ps; diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/staging/r8188eu/include/rtw_pwrctrl.h index 6a0efb010d06..c5804a48072b 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -152,8 +152,6 @@ enum { /* for ips_mode */ struct pwrctrl_priv { struct semaphore lock; volatile u8 rpwm; /* requested power state for fw */ - volatile u8 cpwm; /* fw current power state. updated when - * 1. read from HCPWM 2. driver lowers power level */ volatile u8 tog; /* toggling */ volatile u8 cpwm_tog; /* toggling */ -- 2.20.1