LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: <alexandru.tachici@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] iio: adc: ad7192: Add IRQ flag
Date: Sat, 11 Sep 2021 18:39:21 +0100	[thread overview]
Message-ID: <20210911183921.1381d776@jic23-huawei> (raw)
In-Reply-To: <20210906065630.16325-2-alexandru.tachici@analog.com>

On Mon, 6 Sep 2021 09:56:28 +0300
<alexandru.tachici@analog.com> wrote:

> From: Alexandru Tachici <alexandru.tachici@analog.com>
> 
> IRQ type in ad_sigma_delta_info struct was missing.
> 
> In Sigma-Delta devices the SDO line is also used as an interrupt.
> Leaving IRQ on level instead of falling might trigger a sample read
> when the IRQ is enabled, as the SDO line is already low. Not sure
> if SDO line will always imediately go high in ad_sd_buffer_postenable
> before the IRQ is enabled.
> 
> Also the datasheet seem to explicitly say the falling edge of the SDO
> should be used as an interrupt:
> From the AD7192 datasheet: "The DOUT/RDY falling edge can be used
> as an interrupt to a processor,"
> 
> Fixes: da4d3d6bb9f6 ("iio: adc: ad-sigma-delta: Allow custom IRQ flags")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>

As in thread discussing previous version.  This one should probably be left
to firmware to configure.  It's not 'wrong' before this point as firmware
should be specifying it correctly.  That allows for the interrupt line
to the processor to be inverted and other silliness that happens on real
boards.

Jonathan

> ---
>  drivers/iio/adc/ad7192.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index ee8ed9481025..2121a812b0c3 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -293,6 +293,7 @@ static const struct ad_sigma_delta_info ad7192_sigma_delta_info = {
>  	.has_registers = true,
>  	.addr_shift = 3,
>  	.read_mask = BIT(6),
> +	.irq_flags = IRQF_TRIGGER_FALLING,
>  };
>  
>  static const struct ad_sd_calib_data ad7192_calib_arr[8] = {


  reply	other threads:[~2021-09-11 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06  6:56 [PATCH v2 0/3] iio: adc: Fix flags in sigma-delta drivers alexandru.tachici
2021-09-06  6:56 ` [PATCH v2 1/3] iio: adc: ad7192: Add IRQ flag alexandru.tachici
2021-09-11 17:39   ` Jonathan Cameron [this message]
2021-09-11 17:44     ` Jonathan Cameron
2021-09-06  6:56 ` [PATCH v2 2/3] iio: adc: ad7780: Fix " alexandru.tachici
2021-09-11 17:45   ` Jonathan Cameron
2021-09-06  6:56 ` [PATCH v2 3/3] iio: adc: ad7793: " alexandru.tachici
2021-09-11 17:46   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210911183921.1381d776@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=alexandru.tachici@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2 1/3] iio: adc: ad7192: Add IRQ flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).