LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: CGEL <cgel.zte@gmail.com>, Sumit Garg <sumit.garg@linaro.org>,
	op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
	jing yangyang <jing.yangyang@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer
Date: Mon, 13 Sep 2021 11:21:43 +0200	[thread overview]
Message-ID: <20210913092143.GA165502@jade> (raw)
In-Reply-To: <20210902103428.bdbkybvi6he6mgy2@maple.lan>

On Thu, Sep 02, 2021 at 11:34:28AM +0100, Daniel Thompson wrote:
> On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:
> > From: jing yangyang <jing.yangyang@zte.com.cn>
> > 
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer.
> > 
> > ./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer
> > 
> > This issue was detected with the help of Coccinelle.
> > 
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> 
> This should not affect code generation since both pages and *pages are
> pointers but the change looks good to me.
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Thanks for reviewing, I agree with your analysis. 
I'm picking this up as a bugfix for V5.15.

Cheers,
Jens

      reply	other threads:[~2021-09-13  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  3:21 CGEL
2021-09-02 10:34 ` Daniel Thompson
2021-09-13  9:21   ` Jens Wiklander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913092143.GA165502@jade \
    --to=jens.wiklander@linaro.org \
    --cc=cgel.zte@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=jing.yangyang@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=sumit.garg@linaro.org \
    --cc=zealci@zte.com.cn \
    --subject='Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).