LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Nathan Chancellor <nathan@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] compiler-gcc.h: drop checks for older GCC versions
Date: Mon, 13 Sep 2021 09:26:38 -0700 [thread overview]
Message-ID: <202109130926.15C4D3486F@keescook> (raw)
In-Reply-To: <20210910234047.1019925-10-ndesaulniers@google.com>
On Fri, Sep 10, 2021 at 04:40:46PM -0700, Nick Desaulniers wrote:
> Now that GCC 5.1 is the minimally supported default, drop the values we
> don't use.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> include/linux/compiler-gcc.h | 4 +---
> tools/include/linux/compiler-gcc.h | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 3f7f6fa0e051..fd82ce169ce9 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -98,10 +98,8 @@
>
> #if GCC_VERSION >= 70000
> #define KASAN_ABI_VERSION 5
> -#elif GCC_VERSION >= 50000
> +#else
> #define KASAN_ABI_VERSION 4
> -#elif GCC_VERSION >= 40902
> -#define KASAN_ABI_VERSION 3
> #endif
>
> #if __has_attribute(__no_sanitize_address__)
Reviewed-by: Kees Cook <keescook@chromium.org>
> diff --git a/tools/include/linux/compiler-gcc.h b/tools/include/linux/compiler-gcc.h
> index a590a1dfafd9..43d9a46d36f0 100644
> --- a/tools/include/linux/compiler-gcc.h
> +++ b/tools/include/linux/compiler-gcc.h
> @@ -16,9 +16,7 @@
> # define __fallthrough __attribute__ ((fallthrough))
> #endif
>
> -#if GCC_VERSION >= 40300
> -# define __compiletime_error(message) __attribute__((error(message)))
> -#endif /* GCC_VERSION >= 40300 */
> +#define __compiletime_error(message) __attribute__((error(message)))
>
> /* &a[0] degrades to a pointer: a different type from an array */
> #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
This part could be applied regardless (it's a missed 4.3 check, yes?)
--
Kees Cook
next prev parent reply other threads:[~2021-09-13 16:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 23:40 [PATCH 00/10] raise minimum GCC version to 5.1 Nick Desaulniers
2021-09-10 23:40 ` [PATCH 01/10] Documentation: raise minimum supported version of GCC " Nick Desaulniers
2021-09-10 23:55 ` Nathan Chancellor
2021-09-11 0:16 ` Nick Desaulniers
2021-09-13 16:22 ` Kees Cook
2021-09-10 23:40 ` [PATCH 02/10] compiler.h: drop fallback overflow checkers Nick Desaulniers
2021-09-11 0:04 ` Nathan Chancellor
2021-09-14 15:33 ` Nick Desaulniers
2021-09-14 16:04 ` Nathan Chancellor
2021-09-13 16:21 ` Kees Cook
2021-09-10 23:40 ` [PATCH 03/10] mm/ksm: remove old GCC 4.9+ check Nick Desaulniers
2021-09-11 0:07 ` Nathan Chancellor
2021-09-13 16:22 ` Kees Cook
2021-09-10 23:40 ` [PATCH 04/10] Kconfig.debug: drop GCC 5+ version check for DWARF5 Nick Desaulniers
2021-09-11 0:08 ` Nathan Chancellor
2021-09-13 16:23 ` Kees Cook
2021-09-10 23:40 ` [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I Nick Desaulniers
2021-09-11 0:09 ` Nathan Chancellor
2021-09-13 16:23 ` Kees Cook
2021-10-05 0:40 ` Palmer Dabbelt
2021-10-05 0:50 ` Kees Cook
2021-10-05 0:57 ` Palmer Dabbelt
2021-09-10 23:40 ` [PATCH 06/10] powerpc: remove GCC version check for UPD_CONSTR Nick Desaulniers
2021-09-10 23:48 ` Nathan Chancellor
2021-09-11 10:43 ` Michael Ellerman
2021-09-11 15:34 ` Christophe Leroy
2021-09-10 23:40 ` [PATCH 07/10] arm64: remove GCC version check for ARCH_SUPPORTS_INT128 Nick Desaulniers
2021-09-11 0:10 ` Nathan Chancellor
2021-09-13 16:25 ` Kees Cook
2021-09-16 13:23 ` Catalin Marinas
2021-09-10 23:40 ` [PATCH 08/10] Makefile: drop GCC < 5 -fno-var-tracking-assignments workaround Nick Desaulniers
2021-09-11 0:11 ` Nathan Chancellor
2021-09-13 16:25 ` Kees Cook
2021-09-10 23:40 ` [PATCH 09/10] compiler-gcc.h: drop checks for older GCC versions Nick Desaulniers
2021-09-11 0:12 ` Nathan Chancellor
2021-09-13 16:26 ` Kees Cook [this message]
2021-09-10 23:40 ` [PATCH 10/10] vmlinux.lds.h: remove old check for GCC 4.9 Nick Desaulniers
2021-09-10 23:50 ` Nathan Chancellor
2021-09-14 15:21 ` Nick Desaulniers
2021-09-13 16:28 ` Kees Cook
2021-09-11 2:19 ` [PATCH 00/10] raise minimum GCC version to 5.1 Kees Cook
2021-09-11 10:42 ` Michael Ellerman
2021-09-13 9:49 ` Pavel Machek
2021-09-13 16:20 ` Kees Cook
2021-09-13 11:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109130926.15C4D3486F@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).