LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Robin van der Gracht <robin@protonic.nl>,
	Miguel Ojeda <ojeda@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Paul Burton <paulburton@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>,
	devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v6 04/19] auxdisplay: img-ascii-lcd: Add helper variable dev
Date: Tue, 14 Sep 2021 16:38:20 +0200	[thread overview]
Message-ID: <20210914143835.511051-5-geert@linux-m68k.org> (raw)
In-Reply-To: <20210914143835.511051-1-geert@linux-m68k.org>

img_ascii_lcd_probe() has many users of "pdev->dev".  Add a shorthand to
simplify the code.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v6:
  - No changes,

v5:
  - No changes,

v4:
  - No changes,

v3:
  - No changes,

v2:
  - No changes.
---
 drivers/auxdisplay/img-ascii-lcd.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index e33ce0151cdfd150..2b6e41ec57544faa 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -365,26 +365,25 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
 {
 	const struct of_device_id *match;
 	const struct img_ascii_lcd_config *cfg;
+	struct device *dev = &pdev->dev;
 	struct img_ascii_lcd_ctx *ctx;
 	int err;
 
-	match = of_match_device(img_ascii_lcd_matches, &pdev->dev);
+	match = of_match_device(img_ascii_lcd_matches, dev);
 	if (!match)
 		return -ENODEV;
 
 	cfg = match->data;
-	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx) + cfg->num_chars,
-			   GFP_KERNEL);
+	ctx = devm_kzalloc(dev, sizeof(*ctx) + cfg->num_chars, GFP_KERNEL);
 	if (!ctx)
 		return -ENOMEM;
 
 	if (cfg->external_regmap) {
-		ctx->regmap = syscon_node_to_regmap(pdev->dev.parent->of_node);
+		ctx->regmap = syscon_node_to_regmap(dev->parent->of_node);
 		if (IS_ERR(ctx->regmap))
 			return PTR_ERR(ctx->regmap);
 
-		if (of_property_read_u32(pdev->dev.of_node, "offset",
-					 &ctx->offset))
+		if (of_property_read_u32(dev->of_node, "offset", &ctx->offset))
 			return -EINVAL;
 	} else {
 		ctx->base = devm_platform_ioremap_resource(pdev, 0);
@@ -408,7 +407,7 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
 	if (err)
 		goto out_del_timer;
 
-	err = device_create_file(&pdev->dev, &dev_attr_message);
+	err = device_create_file(dev, &dev_attr_message);
 	if (err)
 		goto out_del_timer;
 
-- 
2.25.1


  parent reply	other threads:[~2021-09-14 14:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 14:38 [PATCH v6 00/19] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 01/19] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 02/19] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 03/19] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-09-14 14:38 ` Geert Uytterhoeven [this message]
2021-09-14 14:38 ` [PATCH v6 05/19] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 06/19] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 07/19] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 08/19] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 09/19] auxdisplay: ht16k33: Connect backlight to fbdev Geert Uytterhoeven
2021-09-29 14:21   ` Robin van der Gracht
2021-09-14 14:38 ` [PATCH v6 10/19] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 11/19] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 12/19] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 13/19] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 14/19] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-09-30  6:36   ` Robin van der Gracht
2021-09-14 14:38 ` [PATCH v6 15/19] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-09-30  6:58   ` Robin van der Gracht
2021-09-14 14:38 ` [PATCH v6 16/19] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-09-30  7:09   ` Robin van der Gracht
2021-09-14 14:38 ` [PATCH v6 17/19] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-09-30  7:37   ` Robin van der Gracht
2021-09-14 14:38 ` [PATCH v6 18/19] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven
2021-09-14 14:38 ` [PATCH v6 19/19] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven
2021-09-30 10:57   ` Robin van der Gracht
2021-10-01 15:51     ` Geert Uytterhoeven
2021-10-04  8:26       ` Robin van der Gracht
2021-10-12 15:08         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914143835.511051-5-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=ojeda@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    --subject='Re: [PATCH v6 04/19] auxdisplay: img-ascii-lcd: Add helper variable dev' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).