From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BBF7C433FE for ; Wed, 15 Sep 2021 13:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D49661250 for ; Wed, 15 Sep 2021 13:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234804AbhIONxZ (ORCPT ); Wed, 15 Sep 2021 09:53:25 -0400 Received: from verein.lst.de ([213.95.11.211]:36435 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234453AbhIONxW (ORCPT ); Wed, 15 Sep 2021 09:53:22 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C0A0867357; Wed, 15 Sep 2021 15:52:01 +0200 (CEST) Date: Wed, 15 Sep 2021 15:52:01 +0200 From: Christoph Hellwig To: Vasily Averin Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in __vmalloc_area_node() Message-ID: <20210915135201.GB14571@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 02:43:10PM +0300, Vasily Averin wrote: > Commit f255935b9767 ("mm: cleanup the gfp_mask handling in > __vmalloc_area_node") added __GFP_NOWARN to gfp_mask unconditionally > however it disabled all output inside warn_alloc() call. > This patch saves original gfp_mask and provides it to all warn_alloc() calls. > > Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_area_node") > Cc: Christoph Hellwig > > Signed-off-by: Vasily Averin Looks fine, thanks. Reviewed-by: Christoph Hellwig