LKML Archive on
help / color / mirror / Atom feed
From: Herbert Xu <>
To: Colin King <>
Cc: "David S . Miller" <>,,,
Subject: Re: [PATCH] crypto: img-hash: remove need for error return variable ret
Date: Fri, 17 Sep 2021 11:21:09 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Sep 10, 2021 at 01:15:32PM +0100, Colin King wrote:
> From: Colin Ian King <>
> The assignment to error return variable ret and then the jump to
> an error exit path can be simplified by just returning the error
> return at the failure point. This allows variable ret and the
> error return path to be removed. This cleans up a static analysis
> warninng that variable ret is being assigned (value never being
> used) and being re-assigned later.
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <>
> ---
>  drivers/crypto/img-hash.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Patch applied.  Thanks.
Email: Herbert Xu <>
Home Page:
PGP Key:

      reply	other threads:[~2021-09-17  3:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 12:15 Colin King
2021-09-17  3:21 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] crypto: img-hash: remove need for error return variable ret' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).