LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Oskar Senft <osk@google.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: hwmon: Add nct7802 bindings
Date: Thu, 16 Sep 2021 20:29:09 -0700	[thread overview]
Message-ID: <20210917032909.GB2520170@roeck-us.net> (raw)
In-Reply-To: <CABoTLcTJgGCrMJc4cKczz=u-ZSLpf2JYZjrMpe6k6XAG+QbJdg@mail.gmail.com>

On Thu, Sep 16, 2021 at 11:09:16PM -0400, Oskar Senft wrote:
> Ok, I experimented with that and I think I'm starting to get an idea
> how the DT bindings YAML works.
> 
> > > Yes, let's do that. I'd like us to keep the "sensors" subnode to have a clear
> > > association and differentiator to other sub-nodes such as "regulators".
> > > Open is if we can use "temperature-sensor@0" or if it would have to be
> > > a chip specific "ltd", but I think we can sort that out after suggesting
> > > an initial set of bindings to Rob.
> 
> However, I found that when I use the name@x syntax, the schema
> validator also requires the use of a reg or ranges property. But then
> doing so requires to set the #address-cells and #size-cells
> properties, which - I think - makes things weird.
> 
> So these two examples are options that validate:
>     i2c {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         nct7802@28 {
>             compatible = "nuvoton,nct7802";
>             reg = <0x28>;
> 
>             temperature-sensors {
>                 ltd {
>                   status = "disabled";
>                   label = "mainboard temperature";
>                 };
> 
>                 rtd1 {
>                   status = "okay";
>                   label = "inlet temperature";
>                   type = <4> /* thermistor */;
>                 };
>             };
>         };
>     };
> 
> or
> 
>     i2c {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         nct7802@28 {
>             compatible = "nuvoton,nct7802";
>             reg = <0x28>;
> 
>             temperature-sensors {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> 
>                 sensor@0 {
>                   reg = <0>;
>                   status = "disabled";
>                   label = "mainboard temperature";
>                 };
> 
>                 sensor@1 {
>                   reg = <1>;
>                   status = "okay";
>                   label = "inlet temperature";
>                   type = <4> /* thermistor */;
>                 };
>             };
>         };
>     };
> 
> In the second case we end up having to duplicate information, i.e.
> "sensor@1" and "reg = <1>". Also, I have not yet found a way to
> validate that the "@x" is identical to the "reg = <x>". I believe that
> this is just how it is in device trees, but I want to make sure this
> is what we want?
> 
> Thoughts?
> 
Comparing those two, I prefer the first option. Can you write that up
in a yaml file to present to Rob ? If he doesn't like it, we can still
suggest the second variant as an alternative.

Thanks,
Guenter

  reply	other threads:[~2021-09-17  3:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 13:03 Oskar Senft
2021-09-10 16:10 ` Guenter Roeck
2021-09-10 20:44   ` Oskar Senft
2021-09-10 21:28     ` Guenter Roeck
2021-09-14 12:41       ` Oskar Senft
2021-09-14 15:08         ` Guenter Roeck
2021-09-14 17:11           ` Oskar Senft
2021-09-14 17:33             ` Guenter Roeck
2021-09-16 19:19               ` Oskar Senft
2021-09-16 19:34                 ` Guenter Roeck
2021-09-16 19:53                   ` Oskar Senft
2021-09-16 20:07                     ` Guenter Roeck
2021-09-16 20:10                       ` Oskar Senft
2021-09-17  3:09                         ` Oskar Senft
2021-09-17  3:29                           ` Guenter Roeck [this message]
2021-09-12  4:03     ` Guenter Roeck
2021-09-10 21:03 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917032909.GB2520170@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osk@google.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH] dt-bindings: hwmon: Add nct7802 bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).