LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe()
@ 2021-09-17  4:22 Cai Huoqing
  2021-09-17  4:22 ` [PATCH 2/6] fbdev: pxa168fb: " Cai Huoqing
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/da8xx-fb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index 005ac3c17aa1..ae76a2111c77 100644
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1354,10 +1354,9 @@ static int fb_probe(struct platform_device *device)
 		return PTR_ERR(da8xx_fb_reg_base);
 
 	tmp_lcdc_clk = devm_clk_get(&device->dev, "fck");
-	if (IS_ERR(tmp_lcdc_clk)) {
-		dev_err(&device->dev, "Can not get device clock\n");
-		return PTR_ERR(tmp_lcdc_clk);
-	}
+	if (IS_ERR(tmp_lcdc_clk))
+		return dev_err_probe(&device->dev, PTR_ERR(tmp_lcdc_clk),
+				     "Can not get device clock\n");
 
 	pm_runtime_enable(&device->dev);
 	pm_runtime_get_sync(&device->dev);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-17  4:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-17  4:22 ` [PATCH 2/6] fbdev: pxa168fb: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 3/6] fbdev: pxa3xx-gcu: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 4/6] fbdev: ssd1307fb: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 5/6] fbdev: s3c-fb: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 6/6] fbdev: mmp: " Cai Huoqing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).