LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/4] fbdev: omapfb: panel-lgphilips-lb035q02: Make use of the helper function dev_err_probe()
@ 2021-09-17  4:24 Cai Huoqing
  2021-09-17  4:24 ` [PATCH 2/4] fbdev: omapfb: lcd_ams_delta: " Cai Huoqing
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:24 UTC (permalink / raw)
  To: caihuoqing; +Cc: linux-fbdev, linux-omap, dri-devel, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 .../fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
index 1bec7a4422e8..6befd22dbd5c 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
@@ -244,10 +244,9 @@ static int lb035q02_probe_of(struct spi_device *spi)
 	struct gpio_desc *gpio;
 
 	gpio = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
-	if (IS_ERR(gpio)) {
-		dev_err(&spi->dev, "failed to parse enable gpio\n");
-		return PTR_ERR(gpio);
-	}
+	if (IS_ERR(gpio))
+		return dev_err_probe(&spi->dev, PTR_ERR(gpio),
+				     "failed to parse enable gpio\n");
 
 	ddata->enable_gpio = gpio;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-17  4:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17  4:24 [PATCH 1/4] fbdev: omapfb: panel-lgphilips-lb035q02: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-17  4:24 ` [PATCH 2/4] fbdev: omapfb: lcd_ams_delta: " Cai Huoqing
2021-09-17  4:24 ` [PATCH 3/4] fbdev: omapfb: panel-sharp-ls037v7dw01: " Cai Huoqing
2021-09-17  4:24 ` [PATCH 4/4] fbdev: omapfb: panel-tpo-td043mtea1: " Cai Huoqing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).