From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693D2C433F5 for ; Fri, 17 Sep 2021 07:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DA8261164 for ; Fri, 17 Sep 2021 07:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241269AbhIQHVZ (ORCPT ); Fri, 17 Sep 2021 03:21:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240202AbhIQHUz (ORCPT ); Fri, 17 Sep 2021 03:20:55 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84DE9C0613E7 for ; Fri, 17 Sep 2021 00:19:20 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id v24so26375451eda.3 for ; Fri, 17 Sep 2021 00:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fC6pZbFQ2+fltpypwSfWsk6CC/Yz/PYqojM5gLQPlFU=; b=dkCjGvHLTXe08jqcQOEeAUBqbMsinkXw0Nr4mUpdMZCpzWDK6mZ/oO7H4ZLX6vP2kC Us3//P8T0AiIOXhDW9LuFSy3ONiULUrn+ITx5+UBsIvXFNsQmTuwZclRUjr3LbpSOel1 Xod2jWoH46GfaN4QgYst8bO8Pp1CVdml0sdyNusYBCFwKJ2jeBrR1HTgfB83NuNVHwtP 5IFuRvbFmI9b5fSdGFpS0SwiLYf9kQUWUDhl9znzJkASy2mIN2ve55cYGgXnUxPVAAtF AQ29jRcLdsYhCFJoht9rB5ZR44G+wjMJfW4sHRgs+Y9SFHAj+ZnD7fY8CAiEf1nXpQwl Yd6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fC6pZbFQ2+fltpypwSfWsk6CC/Yz/PYqojM5gLQPlFU=; b=KBu/AVbaQ6a4ScPHQ+mI5qMFFfemb8Zeiq8x77nTAQP0RHPJqqRpN1C06p8P6OBIc2 jmzm5Wax6Jpx0whJ+jrnZ8xbWed8N4IQI75rd1CtxOlPfIlWe+iVfyn1yTTu9mHDyvwJ 6Az07WTEsfdeQTicRvKxw4T8z0DJJRanxmurKK/Eqk93Q4jyksvjRS/LToCQFdA6doHK X1ZMVdtXWQjOY7DfKExUwCt9zYwUw/mL4THr3ibMHlbmq5/Xd5uvHRRUR78wy/7z5ZCO V1EV/a++n/tSiypUW7i2yvSgOBuAELeFNBC6rRPuinDC6hi+sQ31Zn+K5RulUNz431uw 8HAQ== X-Gm-Message-State: AOAM532CsGF62wOSOhGD9JZEERCl/ysPHMI+heaPlHSk42pzJ6iEIRn0 MwxmXwsTyrcWFiKY7er9Q9A= X-Google-Smtp-Source: ABdhPJxELZKKuGyi3vj9kR53/x4iHrudLSRAGaQbYjH+mvmD76OnNbnzuaoNcUatY3C4Zhz6RqGZ2w== X-Received: by 2002:a17:906:498b:: with SMTP id p11mr10699311eju.295.1631863159082; Fri, 17 Sep 2021 00:19:19 -0700 (PDT) Received: from localhost.localdomain.it (host-79-47-104-104.retail.telecomitalia.it. [79.47.104.104]) by smtp.gmail.com with ESMTPSA id q19sm2297140edc.74.2021.09.17.00.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 00:19:18 -0700 (PDT) From: "Fabio M. De Francesco" To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter Cc: "Fabio M . De Francesco" Subject: [PATCH v7 14/19] staging: r8188eu: remove struct _io_ops Date: Fri, 17 Sep 2021 09:18:32 +0200 Message-Id: <20210917071837.10926-15-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210917071837.10926-1-fmdefrancesco@gmail.com> References: <20210917071837.10926-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin Finally struct _io_ops is unused, so remove it. Reviewed-by: Dan Carpenter Co-developed-by: Fabio M. De Francesco Signed-off-by: Fabio M. De Francesco Signed-off-by: Pavel Skripkin --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 6 ----- drivers/staging/r8188eu/include/rtw_io.h | 25 --------------------- drivers/staging/r8188eu/include/usb_ops.h | 2 -- 3 files changed, 33 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 2516cfc464a9..117213c9f984 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -558,12 +558,6 @@ void rtl8188eu_xmit_tasklet(unsigned long priv) } } -void rtl8188eu_set_intf_ops(struct _io_ops *pops) -{ - - memset((u8 *)pops, 0, sizeof(struct _io_ops)); -} - void rtl8188eu_set_hw_type(struct adapter *adapt) { adapt->chip_type = RTL8188E; diff --git a/drivers/staging/r8188eu/include/rtw_io.h b/drivers/staging/r8188eu/include/rtw_io.h index 2b9b64f1ac80..c6a078210eeb 100644 --- a/drivers/staging/r8188eu/include/rtw_io.h +++ b/drivers/staging/r8188eu/include/rtw_io.h @@ -84,30 +84,6 @@ struct intf_priv; struct intf_hdl; struct io_queue; -struct _io_ops { - u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr); - u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr); - u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); - int (*_write8)(struct intf_hdl *pintfhdl, u32 addr, u8 val); - int (*_write16)(struct intf_hdl *pintfhdl, u32 addr, u16 val); - int (*_write32)(struct intf_hdl *pintfhdl, u32 addr, u32 val); - int (*_writeN)(struct intf_hdl *pintfhdl, u32 addr, u32 length, - u8 *pdata); - int (*_write8_async)(struct intf_hdl *pintfhdl, u32 addr, u8 val); - int (*_write16_async)(struct intf_hdl *pintfhdl, u32 addr, u16 val); - int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val); - void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, - u8 *pmem); - void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, - u8 *pmem); - u32 (*_read_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, - u8 *pmem); - u32 (*_write_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, - u8 *pmem); - void (*_read_port_cancel)(struct intf_hdl *pintfhdl); - void (*_write_port_cancel)(struct intf_hdl *pintfhdl); -}; - struct io_req { struct list_head list; u32 addr; @@ -125,7 +101,6 @@ struct io_req { struct intf_hdl { struct adapter *padapter; struct dvobj_priv *pintf_dev; - struct _io_ops io_ops; }; struct reg_protocol_rd { diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8188eu/include/usb_ops.h index c53cc54b6b87..1939b781b097 100644 --- a/drivers/staging/r8188eu/include/usb_ops.h +++ b/drivers/staging/r8188eu/include/usb_ops.h @@ -21,8 +21,6 @@ void rtl8188eu_set_hw_type(struct adapter *padapter); #define hal_set_hw_type rtl8188eu_set_hw_type -void rtl8188eu_set_intf_ops(struct _io_ops *pops); -#define usb_set_intf_ops rtl8188eu_set_intf_ops /* * Increase and check if the continual_urb_error of this @param dvobjprivei -- 2.33.0