From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BC8C433F5 for ; Thu, 23 Sep 2021 14:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 192FD610D1 for ; Thu, 23 Sep 2021 14:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241748AbhIWOxq (ORCPT ); Thu, 23 Sep 2021 10:53:46 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:56921 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241739AbhIWOxo (ORCPT ); Thu, 23 Sep 2021 10:53:44 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0EDAA58022E; Thu, 23 Sep 2021 10:52:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 23 Sep 2021 10:52:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ECL/W0JHBzjsvTqx0apumlX8TFj I0aM1RfQ42lFm1yE=; b=e6mKC9bJBNCh+RXWafVvCV5Jf03xh/NidQDc5NIYfz2 S9Pw1VcH/VNQ5sq6XQAJRmDkwrEuxYWnpX/IMHpVmijM0Iv8llJldRYrBe/nAFSM VDnf98qQdI6MYKGpw4jSNd78eEDcCzrtPWuqiJPEUFRaZJSsPYUj14kcGxbyKoLJ IeNW6UbvHe9CaigyX7itvsWJul78oSE0A2VikawBYxZhydMenl+Hbk8dnGMSoxqh 6aBfFMaaA1W56NXvYmEsVTm4C3NIgXXa/1e1UdMjMZsy/xusnDFRDIDRI7eYbmjB zrW1bzFnzgTakISMpzaEocmKJfJKRW7ME4QGMcF8JDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ECL/W0 JHBzjsvTqx0apumlX8TFjI0aM1RfQ42lFm1yE=; b=G0chn8iQj5pMkUwxH5bJGa 3Or2RCZdRX955IK/flCpC+fgvZPI1egFi6Kk4k4EN8qiLqq3sHYLcZ9RIMISx1dM 15OpIalBCnjxMwqMiUph0o/uWSFr1xhY6DWENqW49G4s3yKksQPPfJOWl9Qj8/x2 lEA5vwq5TWgZx/DA2hiviZ3oq/7M/wHtRhn6xaqQ9Ig1dpdDBtlfyXNAO6/kl7Gu AvMyxUV1dA96gPyzRrI794ax/fLsNujxvs9RNWHudVMqMOh6lKaS3gvxdi0vCKxT fc2TyJl6rx4JiXNWqTvjjSbyuETmYPINNlZ/Uy1zwvxYmn85+FcPI+0sk6Lrm35A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeiledgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Sep 2021 10:52:10 -0400 (EDT) Date: Thu, 23 Sep 2021 16:52:08 +0200 From: Maxime Ripard To: Nathan Chancellor Cc: Randy Dunlap , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , linux-kernel@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , Boris Brezillon , linux-rpi-kernel@lists.infradead.org, Hans Verkuil , bcm-kernel-feedback-list@broadcom.com, Emma Anholt , Nicolas Saenz Julienne , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Openrisc Subject: Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc) Message-ID: <20210923145208.433zaqldird2vnxk@gilmour> References: <20210819135931.895976-1-maxime@cerno.tech> <20210819135931.895976-2-maxime@cerno.tech> <8a5cdcf5-33ed-398f-243a-b8889fd754e3@infradead.org> <20210922084156.xqru5fdjkarbkyew@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ytg6q5sndyazppt3" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ytg6q5sndyazppt3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nathan, On Wed, Sep 22, 2021 at 08:49:50AM -0700, Nathan Chancellor wrote: > On Wed, Sep 22, 2021 at 10:41:56AM +0200, Maxime Ripard wrote: > > Hi Randy, > >=20 > > On Sun, Sep 19, 2021 at 09:40:44AM -0700, Randy Dunlap wrote: > > > On 8/19/21 6:59 AM, Maxime Ripard wrote: > > > > We already depend on runtime PM to get the power domains and clocks= for > > > > most of the devices supported by the vc4 driver, so let's just sele= ct it > > > > to make sure it's there, and remove the ifdef. > > > >=20 > > > > Signed-off-by: Maxime Ripard > > > > --- > > > > drivers/gpu/drm/vc4/Kconfig | 1 + > > > > drivers/gpu/drm/vc4/vc4_hdmi.c | 2 -- > > > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > >=20 > > > > diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kcon= fig > > > > index 118e8a426b1a..f774ab340863 100644 > > > > --- a/drivers/gpu/drm/vc4/Kconfig > > > > +++ b/drivers/gpu/drm/vc4/Kconfig > > > > @@ -9,6 +9,7 @@ config DRM_VC4 > > > > select DRM_KMS_CMA_HELPER > > > > select DRM_GEM_CMA_HELPER > > > > select DRM_PANEL_BRIDGE > > > > + select PM > > > > select SND_PCM > > > > select SND_PCM_ELD > > > > select SND_SOC_GENERIC_DMAENGINE_PCM > > > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/v= c4_hdmi.c > > > > index c2876731ee2d..602203b2d8e1 100644 > > > > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > > > > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > > > > @@ -2107,7 +2107,6 @@ static int vc5_hdmi_init_resources(struct vc4= _hdmi *vc4_hdmi) > > > > return 0; > > > > } > > > > -#ifdef CONFIG_PM > > > > static int vc4_hdmi_runtime_suspend(struct device *dev) > > > > { > > > > struct vc4_hdmi *vc4_hdmi =3D dev_get_drvdata(dev); > > > > @@ -2128,7 +2127,6 @@ static int vc4_hdmi_runtime_resume(struct dev= ice *dev) > > > > return 0; > > > > } > > > > -#endif > > > > static int vc4_hdmi_bind(struct device *dev, struct device *maste= r, void *data) > > > > { > > > >=20 > > >=20 > > > Hi, > > >=20 > > > FYI. > > >=20 > > > This still causes a build error on arch/openrisc/ since it does not s= upport > > > CONFIG_PM (it does not source "kernel/power/Kconfig" like some other = arches do): > > >=20 > > > ./arch/riscv/Kconfig:source "kernel/power/Kconfig" > > > ./arch/x86/Kconfig:source "kernel/power/Kconfig" > > > ./arch/nds32/Kconfig:source "kernel/power/Kconfig" > > > ./arch/sh/Kconfig:source "kernel/power/Kconfig" > > > ./arch/arc/Kconfig:source "kernel/power/Kconfig" > > > ./arch/arm64/Kconfig:source "kernel/power/Kconfig" > > > ./arch/xtensa/Kconfig:source "kernel/power/Kconfig" > > > ./arch/sparc/Kconfig:source "kernel/power/Kconfig" > > > ./arch/arm/Kconfig:source "kernel/power/Kconfig" > > > ./arch/mips/Kconfig:source "kernel/power/Kconfig" > > > ./arch/powerpc/Kconfig:source "kernel/power/Kconfig" > > > ./arch/um/Kconfig:source "kernel/power/Kconfig" > > > ./arch/ia64/Kconfig:source "kernel/power/Kconfig" > > >=20 > > > so with > > > CONFIG_DRM_VC4=3Dy > > > # CONFIG_DRM_VC4_HDMI_CEC is not set > > >=20 > > > I still see > > > ../drivers/gpu/drm/vc4/vc4_hdmi.c:2139:12: warning: 'vc4_hdmi_runtime= _suspend' defined but not used [-Wunused-function] > > > 2139 | static int vc4_hdmi_runtime_suspend(struct device *dev) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > >=20 > > With what version did you get that build error? -rc2 shouldn't have it > > anymore since the runtime_pm hooks introduction got reverted. >=20 > -next still contains these patches as Stephen effectively reverted the > changes in Linus' tree when merging in the drm-misc-fixes tree: >=20 > https://lore.kernel.org/r/20210920090729.19458953@canb.auug.org.au/ Ah, indeed, thanks. What's the typical fix for these errors? I guess adding a depends on ARM || ARM64 || COMPILE_TEST would work? Maxime --ytg6q5sndyazppt3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYUyUmAAKCRDj7w1vZxhR xbxSAQD2+DTtAckkOgIkW5XhuxgVb3l6s27uLrWlriXbewaI7gD+N6tDqdxX9c8I OI6BWbSVexzvlP+2PqO6lPRQNi+kiA0= =dOL2 -----END PGP SIGNATURE----- --ytg6q5sndyazppt3--