LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe()
@ 2021-09-28 14:19 Cai Huoqing
  2021-09-28 14:19 ` [PATCH v3 2/9] iio: adc: imx7d_adc: " Cai Huoqing
                   ` (8 more replies)
  0 siblings, 9 replies; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
v1->v2: Remove the separate line of PTR_ERR().

 drivers/iio/adc/ab8500-gpadc.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/ab8500-gpadc.c b/drivers/iio/adc/ab8500-gpadc.c
index 7b5212ba5501..c58d0e2ae538 100644
--- a/drivers/iio/adc/ab8500-gpadc.c
+++ b/drivers/iio/adc/ab8500-gpadc.c
@@ -1146,11 +1146,9 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
 
 	/* The VTVout LDO used to power the AB8500 GPADC */
 	gpadc->vddadc = devm_regulator_get(dev, "vddadc");
-	if (IS_ERR(gpadc->vddadc)) {
-		ret = PTR_ERR(gpadc->vddadc);
-		dev_err(dev, "failed to get vddadc\n");
-		return ret;
-	}
+	if (IS_ERR(gpadc->vddadc))
+		return dev_err_probe(dev, PTR_ERR(gpadc->vddadc),
+				     "failed to get vddadc\n");
 
 	ret = regulator_enable(gpadc->vddadc);
 	if (ret) {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 2/9] iio: adc: imx7d_adc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-29 16:26   ` Jonathan Cameron
  2021-09-28 14:19 ` [PATCH v3 3/9] iio: adc: lpc18xx_adc: " Cai Huoqing
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/iio/adc/imx7d_adc.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
index 4969a5f941e3..f47360cbff3b 100644
--- a/drivers/iio/adc/imx7d_adc.c
+++ b/drivers/iio/adc/imx7d_adc.c
@@ -496,19 +496,13 @@ static int imx7d_adc_probe(struct platform_device *pdev)
 		return irq;
 
 	info->clk = devm_clk_get(dev, "adc");
-	if (IS_ERR(info->clk)) {
-		ret = PTR_ERR(info->clk);
-		dev_err(dev, "Failed getting clock, err = %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(info->clk))
+		return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n");
 
 	info->vref = devm_regulator_get(dev, "vref");
-	if (IS_ERR(info->vref)) {
-		ret = PTR_ERR(info->vref);
-		dev_err(dev,
-			"Failed getting reference voltage, err = %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(info->vref))
+		return dev_err_probe(dev, PTR_ERR(info->vref),
+				     "Failed getting reference voltage\n");
 
 	platform_set_drvdata(pdev, indio_dev);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 3/9] iio: adc: lpc18xx_adc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
  2021-09-28 14:19 ` [PATCH v3 2/9] iio: adc: imx7d_adc: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-28 14:19 ` [PATCH v3 4/9] iio: adc: max1118: " Cai Huoqing
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
v1->v2: Remove the separate line of PTR_ERR().

 drivers/iio/adc/lpc18xx_adc.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
index 3566990ae87d..caa7feb4219f 100644
--- a/drivers/iio/adc/lpc18xx_adc.c
+++ b/drivers/iio/adc/lpc18xx_adc.c
@@ -137,19 +137,17 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
 		return PTR_ERR(adc->base);
 
 	adc->clk = devm_clk_get(&pdev->dev, NULL);
-	if (IS_ERR(adc->clk)) {
-		dev_err(&pdev->dev, "error getting clock\n");
-		return PTR_ERR(adc->clk);
-	}
+	if (IS_ERR(adc->clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(adc->clk),
+				     "error getting clock\n");
 
 	rate = clk_get_rate(adc->clk);
 	clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET);
 
 	adc->vref = devm_regulator_get(&pdev->dev, "vref");
-	if (IS_ERR(adc->vref)) {
-		dev_err(&pdev->dev, "error getting regulator\n");
-		return PTR_ERR(adc->vref);
-	}
+	if (IS_ERR(adc->vref))
+		return dev_err_probe(&pdev->dev, PTR_ERR(adc->vref),
+				     "error getting regulator\n");
 
 	indio_dev->name = dev_name(&pdev->dev);
 	indio_dev->info = &lpc18xx_adc_info;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 4/9] iio: adc: max1118: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
  2021-09-28 14:19 ` [PATCH v3 2/9] iio: adc: imx7d_adc: " Cai Huoqing
  2021-09-28 14:19 ` [PATCH v3 3/9] iio: adc: lpc18xx_adc: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-28 14:19 ` [PATCH v3 5/9] iio: adc: max1241: " Cai Huoqing
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/iio/adc/max1118.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/adc/max1118.c b/drivers/iio/adc/max1118.c
index 8cec9d949083..a41bc570be21 100644
--- a/drivers/iio/adc/max1118.c
+++ b/drivers/iio/adc/max1118.c
@@ -221,10 +221,9 @@ static int max1118_probe(struct spi_device *spi)
 
 	if (id->driver_data == max1118) {
 		adc->reg = devm_regulator_get(&spi->dev, "vref");
-		if (IS_ERR(adc->reg)) {
-			dev_err(&spi->dev, "failed to get vref regulator\n");
-			return PTR_ERR(adc->reg);
-		}
+		if (IS_ERR(adc->reg))
+			return dev_err_probe(&spi->dev, PTR_ERR(adc->reg),
+					     "failed to get vref regulator\n");
 		ret = regulator_enable(adc->reg);
 		if (ret)
 			return ret;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 5/9] iio: adc: max1241: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (2 preceding siblings ...)
  2021-09-28 14:19 ` [PATCH v3 4/9] iio: adc: max1118: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-29 16:40   ` Jonathan Cameron
  2021-09-28 14:19 ` [PATCH v3 6/9] iio: adc: meson_saradc: " Cai Huoqing
                   ` (4 subsequent siblings)
  8 siblings, 1 reply; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/iio/adc/max1241.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c
index b60f8448f21a..130ca8dc6fa0 100644
--- a/drivers/iio/adc/max1241.c
+++ b/drivers/iio/adc/max1241.c
@@ -148,10 +148,9 @@ static int max1241_probe(struct spi_device *spi)
 	mutex_init(&adc->lock);
 
 	adc->vdd = devm_regulator_get(dev, "vdd");
-	if (IS_ERR(adc->vdd)) {
-		dev_err(dev, "failed to get vdd regulator\n");
-		return PTR_ERR(adc->vdd);
-	}
+	if (IS_ERR(adc->vdd))
+		return dev_err_probe(dev, PTR_ERR(adc->vdd),
+				     "failed to get vdd regulator\n");
 
 	ret = regulator_enable(adc->vdd);
 	if (ret)
@@ -164,10 +163,9 @@ static int max1241_probe(struct spi_device *spi)
 	}
 
 	adc->vref = devm_regulator_get(dev, "vref");
-	if (IS_ERR(adc->vref)) {
-		dev_err(dev, "failed to get vref regulator\n");
-		return PTR_ERR(adc->vref);
-	}
+	if (IS_ERR(adc->vref))
+		return dev_err_probe(dev, PTR_ERR(adc->vref),
+				     "failed to get vref regulator\n");
 
 	ret = regulator_enable(adc->vref);
 	if (ret)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (3 preceding siblings ...)
  2021-09-28 14:19 ` [PATCH v3 5/9] iio: adc: max1241: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-10-02 13:01   ` Martin Blumenstingl
  2021-09-28 14:19 ` [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: " Cai Huoqing
                   ` (3 subsequent siblings)
  8 siblings, 1 reply; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
v1->v2: Remove the separate line of PTR_ERR().

 drivers/iio/adc/meson_saradc.c | 39 +++++++++++++-----------------
 1 file changed, 17 insertions(+), 22 deletions(-)

diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index 705d5e11a54b..014a77f98b98 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -1230,35 +1230,31 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
 		return ret;
 
 	priv->clkin = devm_clk_get(&pdev->dev, "clkin");
-	if (IS_ERR(priv->clkin)) {
-		dev_err(&pdev->dev, "failed to get clkin\n");
-		return PTR_ERR(priv->clkin);
-	}
+	if (IS_ERR(priv->clkin))
+		return dev_err_probe(&pdev->dev, PTR_ERR(priv->clkin),
+				     "failed to get clkin\n");
 
 	priv->core_clk = devm_clk_get(&pdev->dev, "core");
-	if (IS_ERR(priv->core_clk)) {
-		dev_err(&pdev->dev, "failed to get core clk\n");
-		return PTR_ERR(priv->core_clk);
-	}
+	if (IS_ERR(priv->core_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(priv->core_clk),
+				     "failed to get core clk\n");
 
 	priv->adc_clk = devm_clk_get(&pdev->dev, "adc_clk");
 	if (IS_ERR(priv->adc_clk)) {
-		if (PTR_ERR(priv->adc_clk) == -ENOENT) {
+		if (PTR_ERR(priv->adc_clk) == -ENOENT)
 			priv->adc_clk = NULL;
-		} else {
-			dev_err(&pdev->dev, "failed to get adc clk\n");
-			return PTR_ERR(priv->adc_clk);
-		}
+		else
+			return dev_err_probe(&pdev->dev, PTR_ERR(priv->adc_clk),
+					     "failed to get adc clk\n");
 	}
 
 	priv->adc_sel_clk = devm_clk_get(&pdev->dev, "adc_sel");
 	if (IS_ERR(priv->adc_sel_clk)) {
-		if (PTR_ERR(priv->adc_sel_clk) == -ENOENT) {
+		if (PTR_ERR(priv->adc_sel_clk) == -ENOENT)
 			priv->adc_sel_clk = NULL;
-		} else {
-			dev_err(&pdev->dev, "failed to get adc_sel clk\n");
-			return PTR_ERR(priv->adc_sel_clk);
-		}
+		else
+			return dev_err_probe(&pdev->dev, PTR_ERR(priv->adc_sel_clk),
+					     "failed to get adc_sel clk\n");
 	}
 
 	/* on pre-GXBB SoCs the SAR ADC itself provides the ADC clock: */
@@ -1265,10 +1265,9 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
 	}
 
 	priv->vref = devm_regulator_get(&pdev->dev, "vref");
-	if (IS_ERR(priv->vref)) {
-		dev_err(&pdev->dev, "failed to get vref regulator\n");
-		return PTR_ERR(priv->vref);
-	}
+	if (IS_ERR(priv->vref))
+		return dev_err_probe(&pdev->dev, PTR_ERR(priv->vref),
+				     "failed to get vref regulator\n");
 
 	priv->calibscale = MILLION;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (4 preceding siblings ...)
  2021-09-28 14:19 ` [PATCH v3 6/9] iio: adc: meson_saradc: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-28 14:30   ` Linus Walleij
  2021-09-28 14:19 ` [PATCH v3 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
                   ` (2 subsequent siblings)
  8 siblings, 1 reply; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

BTW, change the return value from 'ENXIO' to 'ENODEV',
perfer ENODEV which means no such device.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
v2->v3: Update the changelog.

 drivers/iio/adc/qcom-pm8xxx-xoadc.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
index 0610bf254771..21d7eff645c3 100644
--- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
+++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
@@ -910,16 +910,15 @@ static int pm8xxx_xoadc_probe(struct platform_device *pdev)
 	map = dev_get_regmap(dev->parent, NULL);
 	if (!map) {
 		dev_err(dev, "parent regmap unavailable.\n");
-		return -ENXIO;
+		return -ENODEV;
 	}
 	adc->map = map;
 
 	/* Bring up regulator */
 	adc->vref = devm_regulator_get(dev, "xoadc-ref");
-	if (IS_ERR(adc->vref)) {
-		dev_err(dev, "failed to get XOADC VREF regulator\n");
-		return PTR_ERR(adc->vref);
-	}
+	if (IS_ERR(adc->vref))
+		return dev_err_probe(dev, PTR_ERR(adc->vref),
+				     "failed to get XOADC VREF regulator\n");
 	ret = regulator_enable(adc->vref);
 	if (ret) {
 		dev_err(dev, "failed to enable XOADC VREF regulator\n");
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 8/9] iio: adc: rockchip_saradc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (5 preceding siblings ...)
  2021-09-28 14:19 ` [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-29 16:55   ` Jonathan Cameron
  2021-09-28 14:19 ` [PATCH v3 9/9] iio: adc: ti-ads7950: " Cai Huoqing
  2021-09-29 16:20 ` [PATCH v3 1/9] iio: adc: ab8500-gpadc: " Jonathan Cameron
  8 siblings, 1 reply; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
v1->v2: Remove the separate line of PTR_ERR().

 drivers/iio/adc/rockchip_saradc.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index a56a0d7337ca..57419ccb3c70 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -392,11 +392,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
 	}
 
 	info->vref = devm_regulator_get(&pdev->dev, "vref");
-	if (IS_ERR(info->vref)) {
-		dev_err(&pdev->dev, "failed to get regulator, %ld\n",
-			PTR_ERR(info->vref));
-		return PTR_ERR(info->vref);
-	}
+	if (IS_ERR(info->vref))
+		return dev_err_probe(&pdev->dev, PTR_ERR(info->vref),
+				     "failed to get regulator\n");
 
 	if (info->reset)
 		rockchip_saradc_reset_controller(info->reset);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3 9/9] iio: adc: ti-ads7950: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (6 preceding siblings ...)
  2021-09-28 14:19 ` [PATCH v3 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
@ 2021-09-28 14:19 ` Cai Huoqing
  2021-09-29 16:20 ` [PATCH v3 1/9] iio: adc: ab8500-gpadc: " Jonathan Cameron
  8 siblings, 0 replies; 17+ messages in thread
From: Cai Huoqing @ 2021-09-28 14:19 UTC (permalink / raw)
  To: caihuoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Andy Gross, Bjorn Andersson,
	Heiko Stuebner, linux-arm-kernel, linux-iio, linux-kernel,
	linux-amlogic, linux-arm-msm, linux-rockchip

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/iio/adc/ti-ads7950.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
index a2b83f0bd526..a7efa3eada2c 100644
--- a/drivers/iio/adc/ti-ads7950.c
+++ b/drivers/iio/adc/ti-ads7950.c
@@ -600,8 +600,8 @@ static int ti_ads7950_probe(struct spi_device *spi)
 
 	st->reg = devm_regulator_get(&spi->dev, "vref");
 	if (IS_ERR(st->reg)) {
-		dev_err(&spi->dev, "Failed to get regulator \"vref\"\n");
-		ret = PTR_ERR(st->reg);
+		ret = dev_err_probe(&spi->dev, PTR_ERR(st->reg),
+				     "Failed to get regulator \"vref\"\n");
 		goto error_destroy_mutex;
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 ` [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: " Cai Huoqing
@ 2021-09-28 14:30   ` Linus Walleij
  0 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2021-09-28 14:30 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Jonathan Cameron, Lars-Peter Clausen, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	Linux ARM, linux-iio, linux-kernel,
	open list:ARM/Amlogic Meson...,
	MSM, open list:ARM/Rockchip SoC...

On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> BTW, change the return value from 'ENXIO' to 'ENODEV',
> perfer ENODEV which means no such device.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v2->v3: Update the changelog.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (7 preceding siblings ...)
  2021-09-28 14:19 ` [PATCH v3 9/9] iio: adc: ti-ads7950: " Cai Huoqing
@ 2021-09-29 16:20 ` Jonathan Cameron
  8 siblings, 0 replies; 17+ messages in thread
From: Jonathan Cameron @ 2021-09-29 16:20 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Linus Walleij, Lars-Peter Clausen, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

On Tue, 28 Sep 2021 22:19:47 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

I believe we could in theory get an -EPROBE_DEFER from
platform_get_irq_by_name() so we should handle that one similarly.

I have no idea if can actually happen on this platform, but seems to me
that we should be thorough given how easy it is to do here.

Thanks,

Jonathan

> ---
> v1->v2: Remove the separate line of PTR_ERR().
> 
>  drivers/iio/adc/ab8500-gpadc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/ab8500-gpadc.c b/drivers/iio/adc/ab8500-gpadc.c
> index 7b5212ba5501..c58d0e2ae538 100644
> --- a/drivers/iio/adc/ab8500-gpadc.c
> +++ b/drivers/iio/adc/ab8500-gpadc.c
> @@ -1146,11 +1146,9 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
>  
>  	/* The VTVout LDO used to power the AB8500 GPADC */
>  	gpadc->vddadc = devm_regulator_get(dev, "vddadc");
> -	if (IS_ERR(gpadc->vddadc)) {
> -		ret = PTR_ERR(gpadc->vddadc);
> -		dev_err(dev, "failed to get vddadc\n");
> -		return ret;
> -	}
> +	if (IS_ERR(gpadc->vddadc))
> +		return dev_err_probe(dev, PTR_ERR(gpadc->vddadc),
> +				     "failed to get vddadc\n");
>  
>  	ret = regulator_enable(gpadc->vddadc);
>  	if (ret) {


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 2/9] iio: adc: imx7d_adc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 ` [PATCH v3 2/9] iio: adc: imx7d_adc: " Cai Huoqing
@ 2021-09-29 16:26   ` Jonathan Cameron
  0 siblings, 0 replies; 17+ messages in thread
From: Jonathan Cameron @ 2021-09-29 16:26 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Linus Walleij, Lars-Peter Clausen, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

On Tue, 28 Sep 2021 22:19:48 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Hi Cai,

It is currently not printing a message, but should we handle the same
for platform_get_irq?

One other minor comment inline.  Actual change here is fine.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/imx7d_adc.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
> index 4969a5f941e3..f47360cbff3b 100644
> --- a/drivers/iio/adc/imx7d_adc.c
> +++ b/drivers/iio/adc/imx7d_adc.c
> @@ -496,19 +496,13 @@ static int imx7d_adc_probe(struct platform_device *pdev)
>  		return irq;
>  
>  	info->clk = devm_clk_get(dev, "adc");
> -	if (IS_ERR(info->clk)) {
> -		ret = PTR_ERR(info->clk);
> -		dev_err(dev, "Failed getting clock, err = %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(info->clk))
> +		return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n");

Where it doesn't hurt readabilty preferred to keep below 80 chars.

>  
>  	info->vref = devm_regulator_get(dev, "vref");
> -	if (IS_ERR(info->vref)) {
> -		ret = PTR_ERR(info->vref);
> -		dev_err(dev,
> -			"Failed getting reference voltage, err = %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(info->vref))
> +		return dev_err_probe(dev, PTR_ERR(info->vref),
> +				     "Failed getting reference voltage\n");
>  
>  	platform_set_drvdata(pdev, indio_dev);
>  


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 5/9] iio: adc: max1241: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 ` [PATCH v3 5/9] iio: adc: max1241: " Cai Huoqing
@ 2021-09-29 16:40   ` Jonathan Cameron
  0 siblings, 0 replies; 17+ messages in thread
From: Jonathan Cameron @ 2021-09-29 16:40 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Linus Walleij, Lars-Peter Clausen, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

On Tue, 28 Sep 2021 22:19:51 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Hi Cai,

Please also add a message to the
devm_gpiod_get_optional() and similar handling so that we
maintain information on that as well.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/max1241.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c
> index b60f8448f21a..130ca8dc6fa0 100644
> --- a/drivers/iio/adc/max1241.c
> +++ b/drivers/iio/adc/max1241.c
> @@ -148,10 +148,9 @@ static int max1241_probe(struct spi_device *spi)
>  	mutex_init(&adc->lock);
>  
>  	adc->vdd = devm_regulator_get(dev, "vdd");
> -	if (IS_ERR(adc->vdd)) {
> -		dev_err(dev, "failed to get vdd regulator\n");
> -		return PTR_ERR(adc->vdd);
> -	}
> +	if (IS_ERR(adc->vdd))
> +		return dev_err_probe(dev, PTR_ERR(adc->vdd),
> +				     "failed to get vdd regulator\n");
>  
>  	ret = regulator_enable(adc->vdd);
>  	if (ret)
> @@ -164,10 +163,9 @@ static int max1241_probe(struct spi_device *spi)
>  	}
>  
>  	adc->vref = devm_regulator_get(dev, "vref");
> -	if (IS_ERR(adc->vref)) {
> -		dev_err(dev, "failed to get vref regulator\n");
> -		return PTR_ERR(adc->vref);
> -	}
> +	if (IS_ERR(adc->vref))
> +		return dev_err_probe(dev, PTR_ERR(adc->vref),
> +				     "failed to get vref regulator\n");
>  
>  	ret = regulator_enable(adc->vref);
>  	if (ret)


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 8/9] iio: adc: rockchip_saradc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 ` [PATCH v3 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
@ 2021-09-29 16:55   ` Jonathan Cameron
  0 siblings, 0 replies; 17+ messages in thread
From: Jonathan Cameron @ 2021-09-29 16:55 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Linus Walleij, Lars-Peter Clausen, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

On Tue, 28 Sep 2021 22:19:54 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

In this driver, there is also a call to
devm_reset_control_get_exclusive() which I think can return
-EPROBE_DEFER

There isn't a message printed on that particular patch, but it would
be good to add something generic. Same for platform_get_irq()

There are some devm_clk_get() calls as well which likewise probably
want handling in a similar fashion as you have done in other patches.

Thanks,

Jonathan


> ---
> v1->v2: Remove the separate line of PTR_ERR().
> 
>  drivers/iio/adc/rockchip_saradc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index a56a0d7337ca..57419ccb3c70 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -392,11 +392,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>  	}
>  
>  	info->vref = devm_regulator_get(&pdev->dev, "vref");
> -	if (IS_ERR(info->vref)) {
> -		dev_err(&pdev->dev, "failed to get regulator, %ld\n",
> -			PTR_ERR(info->vref));
> -		return PTR_ERR(info->vref);
> -	}
> +	if (IS_ERR(info->vref))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(info->vref),
> +				     "failed to get regulator\n");
>  
>  	if (info->reset)
>  		rockchip_saradc_reset_controller(info->reset);


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
  2021-09-28 14:19 ` [PATCH v3 6/9] iio: adc: meson_saradc: " Cai Huoqing
@ 2021-10-02 13:01   ` Martin Blumenstingl
  2021-10-02 16:09     ` Jonathan Cameron
  0 siblings, 1 reply; 17+ messages in thread
From: Martin Blumenstingl @ 2021-10-02 13:01 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Linus Walleij, Jonathan Cameron, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
as well as:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
# Odroid-C1

Thanks for your contribution!


Best regards,
Martin

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
  2021-10-02 13:01   ` Martin Blumenstingl
@ 2021-10-02 16:09     ` Jonathan Cameron
  2021-10-02 17:06       ` Martin Blumenstingl
  0 siblings, 1 reply; 17+ messages in thread
From: Jonathan Cameron @ 2021-10-02 16:09 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: Cai Huoqing, Linus Walleij, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

On Sat, 2 Oct 2021 15:01:56 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:

> On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> >
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>  
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> as well as:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> # Odroid-C1
Hi Martin,

Confusing tag.  Was the second meant to be a Tested-by?

Thanks,

Jonathan
> 
> Thanks for your contribution!
> 
> 
> Best regards,
> Martin


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
  2021-10-02 16:09     ` Jonathan Cameron
@ 2021-10-02 17:06       ` Martin Blumenstingl
  0 siblings, 0 replies; 17+ messages in thread
From: Martin Blumenstingl @ 2021-10-02 17:06 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Cai Huoqing, Linus Walleij, Lars-Peter Clausen, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Vladimir Zapolskiy, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Andy Gross, Bjorn Andersson, Heiko Stuebner,
	linux-arm-kernel, linux-iio, linux-kernel, linux-amlogic,
	linux-arm-msm, linux-rockchip

Hi Jonathan,

On Sat, Oct 2, 2021 at 6:05 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 2 Oct 2021 15:01:56 +0200
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
>
> > On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> > >
> > > When possible use dev_err_probe help to properly deal with the
> > > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > > in the devices_deferred debugfs file.
> > > Using dev_err_probe() can reduce code size, and the error value
> > > gets printed.
> > >
> > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > as well as:
> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > # Odroid-C1
> Hi Martin,
>
> Confusing tag.  Was the second meant to be a Tested-by?
my bad - it is indeed supposed to be:
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Testing was done on a Meson8b Odroid-C1 board.


Best regards,
Martin

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-10-02 17:10 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-28 14:19 ` [PATCH v3 2/9] iio: adc: imx7d_adc: " Cai Huoqing
2021-09-29 16:26   ` Jonathan Cameron
2021-09-28 14:19 ` [PATCH v3 3/9] iio: adc: lpc18xx_adc: " Cai Huoqing
2021-09-28 14:19 ` [PATCH v3 4/9] iio: adc: max1118: " Cai Huoqing
2021-09-28 14:19 ` [PATCH v3 5/9] iio: adc: max1241: " Cai Huoqing
2021-09-29 16:40   ` Jonathan Cameron
2021-09-28 14:19 ` [PATCH v3 6/9] iio: adc: meson_saradc: " Cai Huoqing
2021-10-02 13:01   ` Martin Blumenstingl
2021-10-02 16:09     ` Jonathan Cameron
2021-10-02 17:06       ` Martin Blumenstingl
2021-09-28 14:19 ` [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: " Cai Huoqing
2021-09-28 14:30   ` Linus Walleij
2021-09-28 14:19 ` [PATCH v3 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
2021-09-29 16:55   ` Jonathan Cameron
2021-09-28 14:19 ` [PATCH v3 9/9] iio: adc: ti-ads7950: " Cai Huoqing
2021-09-29 16:20 ` [PATCH v3 1/9] iio: adc: ab8500-gpadc: " Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).