LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 6/6] dyndbg: no vpr-info on empty queries
Date: Wed, 29 Sep 2021 12:37:35 -0600	[thread overview]
Message-ID: <20210929183735.6630-7-jim.cromie@gmail.com> (raw)
In-Reply-To: <20210929183735.6630-1-jim.cromie@gmail.com>

when `echo $cmd > control` contains multiple queries, extra query
separators (;\n) can parse as empty statements.  This is normal, and
pr-info on empty command is just noise.  Also change varname.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8230fdc66d9d..1b83f8f897c3 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -520,9 +520,9 @@ static int ddebug_exec_query(char *query_string, const char *modname)
 static int ddebug_exec_queries(char *query, const char *modname)
 {
 	char *split;
-	int i, errs = 0, exitcode = 0, rc, nfound = 0;
+	int qct, errs = 0, exitcode = 0, rc, nfound = 0;
 
-	for (i = 0; query; query = split) {
+	for (qct = 0; query; query = split) {
 		split = strpbrk(query, ";\n");
 		if (split)
 			*split++ = '\0';
@@ -531,7 +531,7 @@ static int ddebug_exec_queries(char *query, const char *modname)
 		if (!query || !*query || *query == '#')
 			continue;
 
-		v2pr_info("query %d: <%s> mod:<%s>\n", i, query, modname ?: "*");
+		v2pr_info("query %d: <%s> mod:<%s>\n", qct, query, modname ?: "*");
 
 		rc = ddebug_exec_query(query, modname);
 		if (rc < 0) {
@@ -540,10 +540,11 @@ static int ddebug_exec_queries(char *query, const char *modname)
 		} else {
 			nfound += rc;
 		}
-		i++;
+		qct++;
 	}
-	v2pr_info("processed %d queries, with %d matches, %d errs\n",
-		 i, nfound, errs);
+	if (qct)
+		v2pr_info("processed %d queries, with %d matches, %d errs\n",
+			  qct, nfound, errs);
 
 	if (exitcode)
 		return exitcode;
-- 
2.31.1


  parent reply	other threads:[~2021-09-29 18:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 18:37 [PATCH 0/6] dyndbg updates for 5.15-rcX Jim Cromie
2021-09-29 18:37 ` [PATCH 1/6] dyndbg: recode for stronger precondition Jim Cromie
2021-09-30  6:06   ` Greg KH
2021-09-29 18:37 ` [PATCH 2/6] dyndbg: show module in vpr-info in dd-exec-queries Jim Cromie
2021-09-29 18:37 ` [PATCH 3/6] dyndbg: rationalize verbosity Jim Cromie
2021-09-30  6:10   ` Greg KH
2021-10-02 20:58     ` jim.cromie
2021-09-29 18:37 ` [PATCH 4/6] dyndbg: use alt-quotes in vpr-infos, not those user might use Jim Cromie
2021-09-29 18:37 ` [PATCH 5/6] dyndbg: vpr-info on remove-module complete, not starting Jim Cromie
2021-09-29 18:37 ` Jim Cromie [this message]
2021-09-30  6:05 ` [PATCH 0/6] dyndbg updates for 5.15-rcX Greg KH
2021-09-30 21:33   ` jim.cromie
2021-10-01  7:38     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929183735.6630-7-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 6/6] dyndbg: no vpr-info on empty queries' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).