From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74180C433EF for ; Wed, 29 Sep 2021 19:27:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 564F461505 for ; Wed, 29 Sep 2021 19:27:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346649AbhI2T3C (ORCPT ); Wed, 29 Sep 2021 15:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346608AbhI2T2v (ORCPT ); Wed, 29 Sep 2021 15:28:51 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DAD5C06161C for ; Wed, 29 Sep 2021 12:27:09 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id bd28so12561452edb.9 for ; Wed, 29 Sep 2021 12:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QClhxZ+AZAH6ofVBThAd6ZW1zKMJBDT7Zzv3Fto76P4=; b=IhcbDfUTa5/W63+yfTgQ3RjESsADU5/VV6eZzy+rUk/dRzudvbRjcHrpVO6LFnHVaS Fcypmx9zfs2kb4EJDOaF7oBZooGslbP3uoNEAEUYsXPxYG05spW5FWoMgU8+5xaf/B6C pPQToOZoGWztw7HFXulEAxW7ygPHu2g1tLrpi3/bbtGtlnhAhW6R0GtJUKLZ+go9ogg0 BhGbJNfIkvR8Y+bTbtBzjZjfcBbQA+/D7iYA2M+tBs8ePax/sQ/AagksUp1ofaWjDM/H EGa/Y20DwcYL1JyRSvlSaIkLsiGV11vjw4Lbgy11ei389MosB5dF4jJD44gVJG2kTDmH IbzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QClhxZ+AZAH6ofVBThAd6ZW1zKMJBDT7Zzv3Fto76P4=; b=BfdnXT8/9Z0xEPixwELjq2CNPvkF+AJvGV27HW0izdV9BMezzSa3H+sZ64v2Wg5tdl NfXOTfxluIsRR5jCnt9ahmGIJ8SAKGlGdPb9HeKtyfu+5HRrZlogdZMaGq3kumrR7IO0 S69BAQC/5TVk+dwjYdkJuEs1ItoTdlKXrqFjKSvgTioxGZ3lBz7JkU9uxkl8y7l9OfpA s3+uG/W9J2cq2Gw7gKVYTHnH6Vn/0uXYsDiBmH3x6gSLK4JfxpKEE8ddnuV0eWkoCFfD peNoL1Yo/l7GuD74g7FlTGtIrKiIBEgRGDDf+xc3N0mCgEuX/LDr4hpS9FV5QZHo+5Aa 7uSQ== X-Gm-Message-State: AOAM53055vr3DFM41+FWKaCC/XQ/GhZOjl3IwRT0ggmmnwTsath2perT kNOUJSdEmWwY0XtOv5FKRgk= X-Google-Smtp-Source: ABdhPJzQIybsSib1X0VkmETAR/KO81KibL8P4RyyOVk0vzJMy6hFwiPUntFUR51xkUO7B+01nwwU7w== X-Received: by 2002:a17:906:2817:: with SMTP id r23mr1786822ejc.285.1632943627879; Wed, 29 Sep 2021 12:27:07 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::bfc8]) by smtp.gmail.com with ESMTPSA id f10sm449019edu.70.2021.09.29.12.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 12:27:07 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/7] staging: r8188eu: remove init_recv_priv from struct hal_ops Date: Wed, 29 Sep 2021 21:26:54 +0200 Message-Id: <20210929192657.9569-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210929192657.9569-1-straube.linux@gmail.com> References: <20210929192657.9569-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove init_recv_priv from struct hal_ops and remove its wrapper rtw_hal_init_recv_priv(). Call rtl8188eu_init_recv_priv() directly instead. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_recv.c | 3 ++- drivers/staging/r8188eu/hal/hal_intf.c | 8 -------- drivers/staging/r8188eu/hal/usb_halinit.c | 1 - drivers/staging/r8188eu/include/hal_intf.h | 2 -- 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c index 7bbbe412a5cd..3054cc6459c5 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -9,6 +9,7 @@ #include "../include/mlme_osdep.h" #include "../include/usb_ops.h" #include "../include/wifi.h" +#include "../include/rtl8188e_recv.h" static u8 SNAP_ETH_TYPE_IPX[2] = {0x81, 0x37}; static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80, 0xf3}; @@ -82,7 +83,7 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter) sema_init(&precvpriv->allrxreturnevt, 0); - res = rtw_hal_init_recv_priv(padapter); + res = rtl8188eu_init_recv_priv(padapter); timer_setup(&precvpriv->signal_stat_timer, rtw_signal_stat_timer_hdl, 0); precvpriv->signal_stat_sampling_interval = 1000; /* ms */ diff --git a/drivers/staging/r8188eu/hal/hal_intf.c b/drivers/staging/r8188eu/hal/hal_intf.c index ff06307f07c7..ad327c495b5d 100644 --- a/drivers/staging/r8188eu/hal/hal_intf.c +++ b/drivers/staging/r8188eu/hal/hal_intf.c @@ -72,14 +72,6 @@ u32 rtw_hal_inirp_deinit(struct adapter *adapt) return _FAIL; } -s32 rtw_hal_init_recv_priv(struct adapter *adapt) -{ - if (adapt->HalFunc.init_recv_priv) - return adapt->HalFunc.init_recv_priv(adapt); - - return _FAIL; -} - void rtw_hal_free_recv_priv(struct adapter *adapt) { if (adapt->HalFunc.free_recv_priv) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c index 93733c59ba58..6465be895574 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -2153,7 +2153,6 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt) halfunc->inirp_init = &rtl8188eu_inirp_init; halfunc->inirp_deinit = &rtl8188eu_inirp_deinit; - halfunc->init_recv_priv = &rtl8188eu_init_recv_priv; halfunc->free_recv_priv = &rtl8188eu_free_recv_priv; halfunc->SetHwRegHandler = &SetHwReg8188EU; diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index 915f16f3d452..a74250f6d9dd 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -128,7 +128,6 @@ struct hal_ops { u32 (*inirp_init)(struct adapter *padapter); u32 (*inirp_deinit)(struct adapter *padapter); - s32 (*init_recv_priv)(struct adapter *padapter); void (*free_recv_priv)(struct adapter *padapter); void (*SetHwRegHandler)(struct adapter *padapter, u8 variable, @@ -186,7 +185,6 @@ void rtw_hal_get_hwreg(struct adapter *padapter, u8 variable, u8 *val); u32 rtw_hal_inirp_init(struct adapter *padapter); u32 rtw_hal_inirp_deinit(struct adapter *padapter); -s32 rtw_hal_init_recv_priv(struct adapter *padapter); void rtw_hal_free_recv_priv(struct adapter *padapter); void rtw_hal_update_ra_mask(struct adapter *padapter, u32 mac_id, u8 level); -- 2.33.0