LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>, rjw@rjwysocki.net
Cc: kbuild-all@lists.01.org, rui.zhang@intel.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	paul@pgazz.com, jeho@cs.utexas.edu, julianbraha@gmail.com,
	Necip Fazil Yildiran <fazilyildiran@gmail.com>
Subject: Re: [PATCH v2] PM: Kconfig: fix unmet dependency for PM_SLEEP_SMP
Date: Thu, 30 Sep 2021 11:14:05 +0800	[thread overview]
Message-ID: <202109301145.7wZErs31-lkp@intel.com> (raw)
In-Reply-To: <20210323141405.55115-1-fazilyildiran@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4810 bytes --]

Hi Necip,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Necip-Fazil-Yildiran/PM-Kconfig-fix-unmet-dependency-for-PM_SLEEP_SMP/20210929-162901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a4e6f95a891ac08bd09d62e3e6dae239b150f4c1
config: i386-randconfig-c001-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/761d2cbd7ffe7612fdc9084465070e008edd48a7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Necip-Fazil-Yildiran/PM-Kconfig-fix-unmet-dependency-for-PM_SLEEP_SMP/20210929-162901
        git checkout 761d2cbd7ffe7612fdc9084465070e008edd48a7
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/x86/power/cpu.c:288:5: warning: no previous prototype for 'hibernate_resume_nonboot_cpu_disable' [-Wmissing-prototypes]
     288 | int hibernate_resume_nonboot_cpu_disable(void)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/power/cpu.c: In function 'hibernate_resume_nonboot_cpu_disable':
>> arch/x86/power/cpu.c:313:8: error: implicit declaration of function 'freeze_secondary_cpus'; did you mean 'thaw_secondary_cpus'? [-Werror=implicit-function-declaration]
     313 |  ret = freeze_secondary_cpus(0);
         |        ^~~~~~~~~~~~~~~~~~~~~
         |        thaw_secondary_cpus
   cc1: some warnings being treated as errors


vim +313 arch/x86/power/cpu.c

406f992e4a372d Rafael J. Wysocki 2016-07-14  287  
406f992e4a372d Rafael J. Wysocki 2016-07-14 @288  int hibernate_resume_nonboot_cpu_disable(void)
406f992e4a372d Rafael J. Wysocki 2016-07-14  289  {
406f992e4a372d Rafael J. Wysocki 2016-07-14  290  	void (*play_dead)(void) = smp_ops.play_dead;
406f992e4a372d Rafael J. Wysocki 2016-07-14  291  	int ret;
406f992e4a372d Rafael J. Wysocki 2016-07-14  292  
406f992e4a372d Rafael J. Wysocki 2016-07-14  293  	/*
406f992e4a372d Rafael J. Wysocki 2016-07-14  294  	 * Ensure that MONITOR/MWAIT will not be used in the "play dead" loop
406f992e4a372d Rafael J. Wysocki 2016-07-14  295  	 * during hibernate image restoration, because it is likely that the
406f992e4a372d Rafael J. Wysocki 2016-07-14  296  	 * monitored address will be actually written to at that time and then
406f992e4a372d Rafael J. Wysocki 2016-07-14  297  	 * the "dead" CPU will attempt to execute instructions again, but the
406f992e4a372d Rafael J. Wysocki 2016-07-14  298  	 * address in its instruction pointer may not be possible to resolve
406f992e4a372d Rafael J. Wysocki 2016-07-14  299  	 * any more at that point (the page tables used by it previously may
406f992e4a372d Rafael J. Wysocki 2016-07-14  300  	 * have been overwritten by hibernate image data).
ec527c318036a6 Jiri Kosina       2019-05-30  301  	 *
ec527c318036a6 Jiri Kosina       2019-05-30  302  	 * First, make sure that we wake up all the potentially disabled SMT
ec527c318036a6 Jiri Kosina       2019-05-30  303  	 * threads which have been initially brought up and then put into
ec527c318036a6 Jiri Kosina       2019-05-30  304  	 * mwait/cpuidle sleep.
ec527c318036a6 Jiri Kosina       2019-05-30  305  	 * Those will be put to proper (not interfering with hibernation
ec527c318036a6 Jiri Kosina       2019-05-30  306  	 * resume) sleep afterwards, and the resumed kernel will decide itself
ec527c318036a6 Jiri Kosina       2019-05-30  307  	 * what to do with them.
406f992e4a372d Rafael J. Wysocki 2016-07-14  308  	 */
ec527c318036a6 Jiri Kosina       2019-05-30  309  	ret = cpuhp_smt_enable();
ec527c318036a6 Jiri Kosina       2019-05-30  310  	if (ret)
ec527c318036a6 Jiri Kosina       2019-05-30  311  		return ret;
406f992e4a372d Rafael J. Wysocki 2016-07-14  312  	smp_ops.play_dead = resume_play_dead;
565558558985b1 Qais Yousef       2020-04-30 @313  	ret = freeze_secondary_cpus(0);
406f992e4a372d Rafael J. Wysocki 2016-07-14  314  	smp_ops.play_dead = play_dead;
406f992e4a372d Rafael J. Wysocki 2016-07-14  315  	return ret;
406f992e4a372d Rafael J. Wysocki 2016-07-14  316  }
406f992e4a372d Rafael J. Wysocki 2016-07-14  317  #endif
406f992e4a372d Rafael J. Wysocki 2016-07-14  318  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36371 bytes --]

      parent reply	other threads:[~2021-09-30  3:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 14:14 Necip Fazil Yildiran
2021-03-23 15:23 ` Rafael J. Wysocki
2021-09-29 18:43 ` kernel test robot
2021-09-30  3:14 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109301145.7wZErs31-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=fazilyildiran@gmail.com \
    --cc=jeho@cs.utexas.edu \
    --cc=julianbraha@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=paul@pgazz.com \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --subject='Re: [PATCH v2] PM: Kconfig: fix unmet dependency for PM_SLEEP_SMP' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).