LKML Archive on
help / color / mirror / Atom feed
From: Lucas De Marchi <>
To: Masahiro Yamada <>
Cc: intel-gfx <>,
	Daniel Vetter <>,
	dri-devel <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH v2 3/3] Move IS_CONFIG_NONZERO() to kconfig.h
Date: Thu, 30 Sep 2021 08:55:47 -0700	[thread overview]
Message-ID: <20210930155547.rtz6pdae42gqvm6p@ldmartin-desk2> (raw)
In-Reply-To: <>

On Thu, Sep 30, 2021 at 11:01:36PM +0900, Masahiro Yamada wrote:
>On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi
><> wrote:
>> The check for config value doesn't really belong to i915_utils.h - we
>> are trying to eliminate that utils helper and share them when possible
>> with other drivers and subsystems.
>> Rationale for having such macro is in commit
>> babaab2f4738 ("drm/i915: Encapsulate kconfig constant values inside boolean predicates")
>> whereas later it is improved to not break the build if used with
>> undefined configs. The caveat is detailed in the documentation: unlike
>> IS_ENABLED(): it's not preprocessor-only logic so can't be used for
>> things like `#if IS_CONFIG_NONZERO(...)`
>> Signed-off-by: Lucas De Marchi <>
>Hypothetical "it would be nice to have ..." is really unneeded.
>       if (context && CONFIG_DRM_I915_FENCE_TIMEOUT > 0)
>                     return
>is enough, and much cleaner.
>This warning is shown only when a constant is used
>together with '&&'.
>Most of IS_ACTIVE can go away.
>Given that, there are not many places where the IS_ACTIVE macro
>is useful, even in the i915 driver.
>For a few sources of the warnings,
>replacing it with  != 0 or > 0 is just fine.

humn... maybe. Let me do a conversion in that direction and see what is
the outcome.

My original intention was to make IS_ENABLED() even uglier to cover the
int case, but after some tries it seems impossible to do on preprocessor
context, so I thought maybe it would be ok as a separate one.

>Of course, such an ugly macro is not worth being moved to <linux/kconfig.h>

if we don't handle the undefined case and only worry about encapsulating
it inside a boolean predicate, the macro would be very simple. Would
that be worth having in kconfig.h maybe?

Lucas De Marchi

  reply	other threads:[~2021-09-30 15:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 18:33 [PATCH v2 0/3] Rename IS_ACTIVE() and move " Lucas De Marchi
2021-09-29 18:33 ` [PATCH v2 1/3] drm/i915: rename IS_ACTIVE Lucas De Marchi
2021-09-30 10:46   ` Jani Nikula
2021-09-30 15:47     ` Lucas De Marchi
2021-09-29 18:33 ` [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined Lucas De Marchi
2021-09-29 21:08   ` Andrzej Hajda
2021-09-29 22:54     ` Lucas De Marchi
2021-09-30  7:01       ` Andrzej Hajda
2021-09-30 10:00   ` Steven Price
2021-09-30 15:43     ` Lucas De Marchi
2021-09-29 18:33 ` [PATCH v2 3/3] Move IS_CONFIG_NONZERO() to kconfig.h Lucas De Marchi
2021-09-30 14:01   ` Masahiro Yamada
2021-09-30 15:55     ` Lucas De Marchi [this message]
2021-10-01  2:33       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210930155547.rtz6pdae42gqvm6p@ldmartin-desk2 \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 3/3] Move IS_CONFIG_NONZERO() to kconfig.h' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).