LKML Archive on
help / color / mirror / Atom feed
From: Heikki Krogerus <>
To: Greg Kroah-Hartman <>,
	"Rafael J. Wysocki" <>
Cc: Bjorn Helgaas <>,
	Andy Shevchenko <>,
	Zhangfei Gao <>,,
Subject: [PATCH v3 1/3] PCI: Convert to device_create_managed_software_node()
Date: Wed,  6 Oct 2021 14:26:41 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

In quirk_huawei_pcie_sva(), use device_create_managed_software_node()
instead of device_add_properties() to set the "dma-can-stall"

This is the last user of device_add_properties() that relied on
device_del() to take care of also calling device_remove_properties().
After this change we can finally get rid of that
device_remove_properties() call in device_del().

After that device_remove_properties() call has been removed from
device_del(), the software nodes that hold the additional device
properties become reusable and shareable as there is no longer a
default assumption that those nodes are lifetime bound the first
device they are associated with.

Reviewed-by: Andy Shevchenko <>
Acked-by: Zhangfei Gao <>
Signed-off-by: Heikki Krogerus <>
 drivers/pci/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index b6b4c803bdc94..fe5eedba47908 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1850,7 +1850,7 @@ static void quirk_huawei_pcie_sva(struct pci_dev *pdev)
 	 * can set it directly.
 	if (!pdev->dev.of_node &&
-	    device_add_properties(&pdev->dev, properties))
+	    device_create_managed_software_node(&pdev->dev, properties, NULL))
 		pci_warn(pdev, "could not add stall property");
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa250, quirk_huawei_pcie_sva);

  reply	other threads:[~2021-10-06 11:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 11:26 [PATCH v3 0/3] device property: Remove device_add_properties() Heikki Krogerus
2021-10-06 11:26 ` Heikki Krogerus [this message]
2021-10-06 18:47   ` [PATCH v3 1/3] PCI: Convert to device_create_managed_software_node() Bjorn Helgaas
2021-10-07 11:03     ` Heikki Krogerus
2021-10-07 19:35       ` Bjorn Helgaas
2021-10-06 11:26 ` [PATCH v3 2/3] driver core: Don't call device_remove_properties() from device_del() Heikki Krogerus
2021-10-06 11:26 ` [PATCH v3 3/3] device property: Remove device_add_properties() API Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v3 1/3] PCI: Convert to device_create_managed_software_node()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).