LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To: Codrin Ciubotariu - M19940 <Codrin.Ciubotariu@microchip.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	Ludovic Desroches - M43218 <Ludovic.Desroches@microchip.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] i2c: at91: Add support for programmable clock source
Date: Wed, 13 Oct 2021 13:41:44 +0200	[thread overview]
Message-ID: <20211013114144.7j4scdaq2rjfmiwn@soft-dev3-1.localhost> (raw)
In-Reply-To: <8a775c67-00a3-1dbe-daa3-09a537f482d8@microchip.com>

The 10/13/2021 08:49, Codrin Ciubotariu - M19940 wrote:
> On 12.10.2021 17:07, Horatiu Vultur wrote:
> > Add support to be able to set BRSRCCLK. This feature is support on lan966x
> > 
> > Horatiu Vultur (2):
> >    dt-bindings: i2c: at91: Extend compatible list for lan966x
> >    i2c: at91: add support for brsrcclk
> > 
> >   .../devicetree/bindings/i2c/i2c-at91.txt      |  6 +++--
> >   drivers/i2c/busses/i2c-at91-core.c            | 16 +++++++++++++
> >   drivers/i2c/busses/i2c-at91-master.c          | 23 +++++++++++++++++--
> >   drivers/i2c/busses/i2c-at91.h                 |  1 +
> >   4 files changed, 42 insertions(+), 4 deletions(-)
> > 
> 
> Hi Horatiu,

Hi Codrin,

> 
>  From what I understand, on your DTS, you replaced the peripheral clock 
> with the GCLK in the I2C node. This means that you are forcing all the 
> variants that support clk_brsrcclk to treat the current clock as GCLK. 
> This is not necessarily correct, since this newer variants can also work 
> fine with only the peripheral clock and we should keep these option 
> available.
> 
> I would add an optional GCLK clock binding in the I2C node. This way 
> GCLK will be used only if it is present in DT and clk_brsrcclk set.

Thanks for the explanation.

I think actually I will drop this patch series because apparently
lan966x works fine also with the peripheral clock. So then no changes
are required.

If you think is worth it, I can do another version with the proposed
changes.

> 
> Best regards,
> Codrin

-- 
/Horatiu

  reply	other threads:[~2021-10-13 11:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 14:07 Horatiu Vultur
2021-10-12 14:07 ` [PATCH 1/2] dt-bindings: i2c: at91: Extend compatible list for lan966x Horatiu Vultur
2021-10-22 23:37   ` Rob Herring
2021-10-12 14:07 ` [PATCH 2/2] i2c: at91: add support for brsrcclk Horatiu Vultur
2021-10-13  8:49 ` [PATCH 0/2] i2c: at91: Add support for programmable clock source Codrin.Ciubotariu
2021-10-13 11:41   ` Horatiu Vultur - M31836 [this message]
2021-10-13 13:10     ` Codrin.Ciubotariu
2021-11-05 21:47     ` Wolfram Sang
2021-11-08  8:35       ` Codrin.Ciubotariu
2021-11-08  9:29         ` Horatiu Vultur - M31836
2021-11-29 10:06           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211013114144.7j4scdaq2rjfmiwn@soft-dev3-1.localhost \
    --to=horatiu.vultur@microchip.com \
    --cc=Codrin.Ciubotariu@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 0/2] i2c: at91: Add support for programmable clock source' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).