LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Ansuel Smith <ansuelsmth@gmail.com> To: Andrew Lunn <andrew@lunn.ch>, Vivien Didelot <vivien.didelot@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Rob Herring <robh+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Pavel Machek <pavel@ucw.cz>, Ansuel Smith <ansuelsmth@gmail.com>, John Crispin <john@phrozen.org>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-leds@vger.kernel.org Subject: [RFC PATCH v2 2/5] leds: add function to configure offload leds Date: Mon, 8 Nov 2021 01:24:57 +0100 [thread overview] Message-ID: <20211108002500.19115-3-ansuelsmth@gmail.com> (raw) In-Reply-To: <20211108002500.19115-1-ansuelsmth@gmail.com> Add configure_offload helper to configure how the LED should work in offload mode. The function require to support the particular trigger and will use the passed offload_flags to elaborate the data and apply the correct configuration. This function will then be used by the offload trigger to request and update offload configuration. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- Documentation/leds/leds-class.rst | 24 ++++++++++++++++++++++++ include/linux/leds.h | 28 ++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) diff --git a/Documentation/leds/leds-class.rst b/Documentation/leds/leds-class.rst index 5bf6e5d471ce..0a3bbe71dac7 100644 --- a/Documentation/leds/leds-class.rst +++ b/Documentation/leds/leds-class.rst @@ -190,6 +190,30 @@ If the second argument (enable) to the trigger_offload() method is false, any active HW offloading must be deactivated. In this case errors are not permitted in the trigger_offload() method and the driver will be set to the new trigger. +The offload trigger will use the function configure_offload() provided by the driver +that will configure the offloaded mode for the LED. +This function passes as the first argument (offload_flags) a u32 flag. +The second argument (cmd) of the configure_offload() method can be used to do various +operations for the specific trigger. We currently support ENABLE, DISABLE, READ and +SUPPORTED to enable, disable, read the state of the offload trigger and ask the LED +driver supports the specific offload trigger. + +In ENABLE/DISABLE configure_offload() should configure the LED to enable/disable the +requested trigger (flags). +In READ configure_offload() should return 0 or 1 based on the status of the requested +trigger (flags). +In SUPPORTED configure_offload() should return 0 or 1 if the LED driver supports the +requested trigger (flags) or not. + +The u32 flag is specific to the trigger and change across them. It's in the LED +driver interest know how to elaborate this flag and to declare support for a +particular offload trigger. For this exact reason explicit support for the specific +trigger is mandatory or the driver returns -EOPNOTSUPP if asked to enter offload mode +with a not supported trigger. +If the driver returns -EOPNOTSUPP on configure_offload(), the trigger activation will +fail as the driver doesn't support that specific offload trigger or doesn't know +how to handle the provided flags. + Known Issues ============ diff --git a/include/linux/leds.h b/include/linux/leds.h index 949ab461287f..2a1e60e4d73e 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -67,6 +67,15 @@ struct led_hw_trigger_type { int dummy; }; +#ifdef CONFIG_LEDS_OFFLOAD_TRIGGERS +enum offload_trigger_cmd { + TRIGGER_ENABLE, /* Enable the offload trigger */ + TRIGGER_DISABLE, /* Disable the offload trigger */ + TRIGGER_READ, /* Read the status of the offload trigger */ + TRIGGER_SUPPORTED, /* Ask the driver if the trigger is supported */ +}; +#endif + struct led_classdev { const char *name; unsigned int brightness; @@ -160,6 +169,14 @@ struct led_classdev { /* some LEDs cne be driven by HW */ int (*trigger_offload)(struct led_classdev *led_cdev, bool enable); + /* Function to configure how the LEDs should work in offload mode. + * The function require to support the trigger and will use the + * passed flags to elaborate the trigger requested and apply the + * correct configuration. + */ + int (*configure_offload)(struct led_classdev *led_cdev, + u32 offload_flags, + enum offload_trigger_cmd cmd); #endif #endif @@ -417,6 +434,17 @@ static inline void *led_get_trigger_data(struct led_classdev *led_cdev) } #ifdef CONFIG_LEDS_OFFLOAD_TRIGGERS +bool led_trigger_offload_is_supported(struct led_classdev *led_cdev, u32 flags) +{ + int ret; + + ret = led_cdev->configure_offload(led_cdev, flags, TRIGGER_SUPPORTED); + if (ret > 0) + return true; + + return false; +} + static inline int led_trigger_offload(struct led_classdev *led_cdev) { int ret; -- 2.32.0
next prev parent reply other threads:[~2021-11-08 0:25 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-08 0:24 [RFC PATCH v2 0/5] Adds support for PHY LEDs with offload triggers Ansuel Smith 2021-11-08 0:24 ` [RFC PATCH v2 1/5] leds: trigger: add API for HW offloading of triggers Ansuel Smith 2021-11-08 2:29 ` Randy Dunlap 2021-11-08 14:04 ` Andrew Lunn 2021-11-08 15:16 ` Ansuel Smith 2021-11-08 16:13 ` Marek Behún 2021-11-08 16:46 ` Ansuel Smith 2021-11-08 17:35 ` Marek Behún 2021-11-08 17:58 ` Ansuel Smith 2021-11-08 18:41 ` Marek Behún 2021-11-08 19:08 ` Ansuel Smith 2021-11-08 19:17 ` Marek Behún 2021-11-08 17:46 ` Andrew Lunn 2021-11-08 17:56 ` Marek Behún 2021-11-08 19:53 ` Andrew Lunn 2021-11-08 20:03 ` Vladimir Oltean 2021-11-08 20:11 ` Marek Behún 2021-11-08 20:15 ` Ansuel Smith 2021-11-08 17:37 ` Andrew Lunn 2021-11-08 0:24 ` Ansuel Smith [this message] 2021-11-08 2:22 ` [RFC PATCH v2 2/5] leds: add function to configure offload leds Randy Dunlap 2021-11-08 0:24 ` [RFC PATCH v2 3/5] leds: trigger: add offload-phy-activity trigger Ansuel Smith 2021-11-08 2:24 ` Randy Dunlap 2021-11-08 14:17 ` Andrew Lunn 2021-11-08 15:19 ` Ansuel Smith 2021-11-08 0:24 ` [RFC PATCH v2 4/5] net: dsa: qca8k: add LEDs support Ansuel Smith 2021-11-08 2:26 ` Randy Dunlap 2021-11-08 0:25 ` [RFC PATCH v2 5/5] dt-bindings: net: dsa: qca8k: add LEDs definition example Ansuel Smith
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211108002500.19115-3-ansuelsmth@gmail.com \ --to=ansuelsmth@gmail.com \ --cc=andrew@lunn.ch \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=john@phrozen.org \ --cc=kuba@kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).