LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [deller-parisc:HPMC_and_TOC_on_c8000 1/3] drivers/tty/sysrq.c:150:15: sparse: sparse: symbol 'hpmc_addr' was not declared. Should it be static?
@ 2021-11-08 10:35 kernel test robot
  2021-11-08 10:35 ` [RFC PATCH deller-parisc] hpmc_addr can be static kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-11-08 10:35 UTC (permalink / raw)
  To: Sven Schnelle; +Cc: kbuild-all, linux-kernel, Helge Deller

[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git HPMC_and_TOC_on_c8000
head:   96e1b009bc4030ae126df7e90ff9d434c5766d99
commit: c743202c8e5cfe0ee49a274751bf02bb893faa19 [1/3] hpmc trigger
config: i386-randconfig-s001-20211008 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?id=c743202c8e5cfe0ee49a274751bf02bb893faa19
        git remote add deller-parisc https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git
        git fetch --no-tags deller-parisc HPMC_and_TOC_on_c8000
        git checkout c743202c8e5cfe0ee49a274751bf02bb893faa19
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/ arch/x86/lib/ arch/x86/mm/ drivers/android/ drivers/base/ drivers/dma-buf/ drivers/gpu/drm/ drivers/input/ drivers/interconnect/ drivers/misc/mei/ drivers/misc/vmw_vmci/ drivers/mtd/devices/ drivers/net/ drivers/platform/chrome/ drivers/pwm/ drivers/spi/ drivers/staging/fwserial/ drivers/tty/ fs/cifs/ fs/nfs/ kernel/ mm/ net/sunrpc/ samples/ftrace/ samples/trace_events/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/tty/sysrq.c:150:15: sparse: sparse: symbol 'hpmc_addr' was not declared. Should it be static?
>> drivers/tty/sysrq.c:1189:19: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected unsigned long *[addressable] [toplevel] hpmc_addr @@     got void [noderef] __iomem * @@
   drivers/tty/sysrq.c:1189:19: sparse:     expected unsigned long *[addressable] [toplevel] hpmc_addr
   drivers/tty/sysrq.c:1189:19: sparse:     got void [noderef] __iomem *
   drivers/tty/sysrq.c: note: in included file (through include/linux/rculist.h, include/linux/sched/signal.h):
   include/linux/rcupdate.h:718:9: sparse: sparse: context imbalance in 'sysrq_handle_crash' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35984 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH deller-parisc] hpmc_addr can be static
  2021-11-08 10:35 [deller-parisc:HPMC_and_TOC_on_c8000 1/3] drivers/tty/sysrq.c:150:15: sparse: sparse: symbol 'hpmc_addr' was not declared. Should it be static? kernel test robot
@ 2021-11-08 10:35 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-11-08 10:35 UTC (permalink / raw)
  To: Sven Schnelle; +Cc: kbuild-all, linux-kernel, Helge Deller

drivers/tty/sysrq.c:150:15: warning: symbol 'hpmc_addr' was not declared. Should it be static?

Fixes: c743202c8e5c ("hpmc trigger")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 sysrq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index b8a982f12ba9f..c95b22fe3cd26 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -147,7 +147,7 @@ static const struct sysrq_key_op sysrq_unraw_op = {
 #define sysrq_unraw_op (*(const struct sysrq_key_op *)NULL)
 #endif /* CONFIG_VT */
 
-unsigned long *hpmc_addr;
+static unsigned long *hpmc_addr;
 static void sysrq_handle_crash(int key)
 {
 	/* release the RCU read lock before crashing */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-08 10:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 10:35 [deller-parisc:HPMC_and_TOC_on_c8000 1/3] drivers/tty/sysrq.c:150:15: sparse: sparse: symbol 'hpmc_addr' was not declared. Should it be static? kernel test robot
2021-11-08 10:35 ` [RFC PATCH deller-parisc] hpmc_addr can be static kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).