LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sfc: use swap() to make code cleaner
@ 2021-11-04 6:53 davidcomponentone
2021-11-08 11:05 ` Martin Habets
0 siblings, 1 reply; 2+ messages in thread
From: davidcomponentone @ 2021-11-04 6:53 UTC (permalink / raw)
To: ecree.xilinx
Cc: davidcomponentone, habetsm.xilinx, davem, kuba, hkallweit1,
bhelgaas, yuehaibing, arnd, yang.guang5, netdev, linux-kernel,
Zeal Robot
From: Yang Guang <yang.guang5@zte.com.cn>
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
---
drivers/net/ethernet/sfc/falcon/efx.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c
index c68837a951f4..314c9c69eb0e 100644
--- a/drivers/net/ethernet/sfc/falcon/efx.c
+++ b/drivers/net/ethernet/sfc/falcon/efx.c
@@ -817,9 +817,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries)
efx->rxq_entries = rxq_entries;
efx->txq_entries = txq_entries;
for (i = 0; i < efx->n_channels; i++) {
- channel = efx->channel[i];
- efx->channel[i] = other_channel[i];
- other_channel[i] = channel;
+ swap(efx->channel[i], other_channel[i]);
}
/* Restart buffer table allocation */
@@ -863,9 +861,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries)
efx->rxq_entries = old_rxq_entries;
efx->txq_entries = old_txq_entries;
for (i = 0; i < efx->n_channels; i++) {
- channel = efx->channel[i];
- efx->channel[i] = other_channel[i];
- other_channel[i] = channel;
+ swap(efx->channel[i], other_channel[i]);
}
goto out;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sfc: use swap() to make code cleaner
2021-11-04 6:53 [PATCH] sfc: use swap() to make code cleaner davidcomponentone
@ 2021-11-08 11:05 ` Martin Habets
0 siblings, 0 replies; 2+ messages in thread
From: Martin Habets @ 2021-11-08 11:05 UTC (permalink / raw)
To: davidcomponentone
Cc: ecree.xilinx, davem, kuba, hkallweit1, bhelgaas, yuehaibing,
arnd, yang.guang5, netdev, linux-kernel, Zeal Robot
On Thu, Nov 04, 2021 at 02:53:50PM +0800, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> ---
> drivers/net/ethernet/sfc/falcon/efx.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c
> index c68837a951f4..314c9c69eb0e 100644
> --- a/drivers/net/ethernet/sfc/falcon/efx.c
> +++ b/drivers/net/ethernet/sfc/falcon/efx.c
> @@ -817,9 +817,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries)
> efx->rxq_entries = rxq_entries;
> efx->txq_entries = txq_entries;
> for (i = 0; i < efx->n_channels; i++) {
> - channel = efx->channel[i];
> - efx->channel[i] = other_channel[i];
> - other_channel[i] = channel;
> + swap(efx->channel[i], other_channel[i]);
> }
The braces are no longer needed. Remove those.
Martin
>
> /* Restart buffer table allocation */
> @@ -863,9 +861,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries)
> efx->rxq_entries = old_rxq_entries;
> efx->txq_entries = old_txq_entries;
> for (i = 0; i < efx->n_channels; i++) {
> - channel = efx->channel[i];
> - efx->channel[i] = other_channel[i];
> - other_channel[i] = channel;
> + swap(efx->channel[i], other_channel[i]);
> }
> goto out;
> }
> --
> 2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-08 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 6:53 [PATCH] sfc: use swap() to make code cleaner davidcomponentone
2021-11-08 11:05 ` Martin Habets
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).