LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, Colin Cross <ccross@android.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Christoph Hellwig <hch@lst.de>, Tony Luck <tony.luck@intel.com>,
	linux-hardening@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] Revert "mark pstore-blk as broken"
Date: Thu, 18 Nov 2021 10:29:24 -0800	[thread overview]
Message-ID: <202111181026.D7EF6BCED@keescook> (raw)
In-Reply-To: <163710862474.168539.12611066078131838062.b4-ty@kernel.dk>

On Tue, Nov 16, 2021 at 05:23:44PM -0700, Jens Axboe wrote:
> On Tue, 16 Nov 2021 10:15:59 -0800, Kees Cook wrote:
> > This reverts commit d07f3b081ee632268786601f55e1334d1f68b997.
> > 
> > pstore-blk was fixed to avoid the unwanted APIs in commit 7bb9557b48fc
> > ("pstore/blk: Use the normal block device I/O path"), which landed in
> > the same release as the commit adding BROKEN.
> > 
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] Revert "mark pstore-blk as broken"
>       commit: d1faacbf67b1944f0e0c618dc581d929263f6fe9

Thanks! I realize now what Geert meant in an earlier thread that I
actually can't split this change from a warning fix that was living in
the pstore tree (and was masked by the now removed BROKEN). Can you take
this patch as well? I've removed it from my tree now...

https://lore.kernel.org/lkml/20211118182621.1280983-1-keescook@chromium.org/

-- 
Kees Cook

  reply	other threads:[~2021-11-18 18:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 18:15 Kees Cook
2021-11-17  0:23 ` Jens Axboe
2021-11-18 18:29   ` Kees Cook [this message]
2021-11-21 10:25     ` Geert Uytterhoeven
2021-11-21 13:36       ` Jens Axboe
2021-11-21 17:46         ` Linus Torvalds
2021-11-21 18:04           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111181026.D7EF6BCED@keescook \
    --to=keescook@chromium.org \
    --cc=anton@enomsg.org \
    --cc=axboe@kernel.dk \
    --cc=ccross@android.com \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --subject='Re: [PATCH] Revert "mark pstore-blk as broken"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).