From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C107C433EF for ; Sat, 20 Nov 2021 14:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237311AbhKTOQF (ORCPT ); Sat, 20 Nov 2021 09:16:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:54518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbhKTOQE (ORCPT ); Sat, 20 Nov 2021 09:16:04 -0500 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F345760551; Sat, 20 Nov 2021 14:12:58 +0000 (UTC) Date: Sat, 20 Nov 2021 14:17:50 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Jonathan Cameron , Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Yang Yingliang Subject: Re: [PATCH v2 0/2] iio: buffer: allocation and freeing buffers fix and optimization Message-ID: <20211120141750.3e7738cf@jic23-huawei> In-Reply-To: References: <20211013094923.2473-1-andriy.shevchenko@linux.intel.com> <20211017152611.13fb0357@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Nov 2021 13:12:24 +0200 Andy Shevchenko wrote: > On Sun, Oct 17, 2021 at 03:26:11PM +0100, Jonathan Cameron wrote: > > On Wed, 13 Oct 2021 12:49:21 +0300 > > Andy Shevchenko wrote: > > > > > Yang submitted a fix, but I think the code can be refactored a bit to be more > > > robust against similar mistakes in the future, if any. > > > > > > In v2: > > > - put SoB Yang's patch (it's good for backporting) > > > - added refactoring patch on top of Yang's fix > > > > > > Andy Shevchenko (1): > > > iio: buffer: Use dedicated variable in > > > iio_buffers_alloc_sysfs_and_mask() > > > > > > Yang Yingliang (1): > > > iio: buffer: Fix double-free in iio_buffers_alloc_sysfs_and_mask() > > > > > > drivers/iio/industrialio-buffer.c | 18 +++++++----------- > > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > > 1st patch applied to the fixes-togreg branch of iio.git. I may well end up > > sending these in the merge window anyway in which case I'll probably stick patch 2 > > on top of it before sending. If not I'll pick that up next cycle now. > > Is it a right time now? > Applied, but needed a bit of hand tweaking as patches have crossed with this. Pushed out as testing for 0-day to see if we missed anything. Thanks, Jonathan